* [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe()
@ 2021-02-10 3:16 ` Tang Bin
0 siblings, 0 replies; 4+ messages in thread
From: Tang Bin @ 2021-02-10 3:16 UTC (permalink / raw)
To: clabbe, herbert, davem
Cc: linux-crypto, linux-amlogic, linux-kernel, Tang Bin
The function meson_crypto_probe() is only called with an openfirmware
platform device. Therefore there is no need to check that the passed
in device is NULL.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/crypto/amlogic/amlogic-gxl-core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 466552acb..468a16f62 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -229,9 +229,6 @@ static int meson_crypto_probe(struct platform_device *pdev)
struct meson_dev *mc;
int err, i;
- if (!pdev->dev.of_node)
- return -ENODEV;
-
mc = devm_kzalloc(&pdev->dev, sizeof(*mc), GFP_KERNEL);
if (!mc)
return -ENOMEM;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe()
@ 2021-02-10 3:16 ` Tang Bin
0 siblings, 0 replies; 4+ messages in thread
From: Tang Bin @ 2021-02-10 3:16 UTC (permalink / raw)
To: clabbe, herbert, davem
Cc: linux-amlogic, Tang Bin, linux-crypto, linux-kernel
The function meson_crypto_probe() is only called with an openfirmware
platform device. Therefore there is no need to check that the passed
in device is NULL.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/crypto/amlogic/amlogic-gxl-core.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 466552acb..468a16f62 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -229,9 +229,6 @@ static int meson_crypto_probe(struct platform_device *pdev)
struct meson_dev *mc;
int err, i;
- if (!pdev->dev.of_node)
- return -ENODEV;
-
mc = devm_kzalloc(&pdev->dev, sizeof(*mc), GFP_KERNEL);
if (!mc)
return -ENOMEM;
--
2.20.1.windows.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe()
2021-02-10 3:16 ` Tang Bin
@ 2021-03-04 6:41 ` Herbert Xu
-1 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-03-04 6:41 UTC (permalink / raw)
To: Tang Bin; +Cc: clabbe, davem, linux-crypto, linux-amlogic, linux-kernel
On Wed, Feb 10, 2021 at 11:16:37AM +0800, Tang Bin wrote:
> The function meson_crypto_probe() is only called with an openfirmware
> platform device. Therefore there is no need to check that the passed
> in device is NULL.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/crypto/amlogic/amlogic-gxl-core.c | 3 ---
> 1 file changed, 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe()
@ 2021-03-04 6:41 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-03-04 6:41 UTC (permalink / raw)
To: Tang Bin; +Cc: clabbe, davem, linux-crypto, linux-amlogic, linux-kernel
On Wed, Feb 10, 2021 at 11:16:37AM +0800, Tang Bin wrote:
> The function meson_crypto_probe() is only called with an openfirmware
> platform device. Therefore there is no need to check that the passed
> in device is NULL.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> ---
> drivers/crypto/amlogic/amlogic-gxl-core.c | 3 ---
> 1 file changed, 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-04 6:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 3:16 [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe() Tang Bin
2021-02-10 3:16 ` Tang Bin
2021-03-04 6:41 ` Herbert Xu
2021-03-04 6:41 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.