* [PATCH] efi/apple-properties: Handle device properties with software node API
@ 2021-03-04 8:28 Heikki Krogerus
2021-03-04 8:30 ` Ard Biesheuvel
2021-03-04 9:44 ` Lukas Wunner
0 siblings, 2 replies; 4+ messages in thread
From: Heikki Krogerus @ 2021-03-04 8:28 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: linux-efi, linux-kernel
The old device property API is going to be removed.
Replacing the device_add_properties() call with the software
node API equivalent, device_create_managed_software_node().
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
drivers/firmware/efi/apple-properties.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
index e1926483ae2fd..4c3201e290e29 100644
--- a/drivers/firmware/efi/apple-properties.c
+++ b/drivers/firmware/efi/apple-properties.c
@@ -157,7 +157,7 @@ static int __init unmarshal_devices(struct properties_header *properties)
if (!entry[0].name)
goto skip_device;
- ret = device_add_properties(dev, entry); /* makes deep copy */
+ ret = device_create_managed_software_node(dev, entry, NULL);
if (ret)
dev_err(dev, "error %d assigning properties\n", ret);
--
2.30.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] efi/apple-properties: Handle device properties with software node API
2021-03-04 8:28 [PATCH] efi/apple-properties: Handle device properties with software node API Heikki Krogerus
@ 2021-03-04 8:30 ` Ard Biesheuvel
2021-03-04 9:44 ` Lukas Wunner
1 sibling, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2021-03-04 8:30 UTC (permalink / raw)
To: Heikki Krogerus, Lukas Wunner; +Cc: linux-efi, Linux Kernel Mailing List
(+ Lukas)
On Thu, 4 Mar 2021 at 09:28, Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/firmware/efi/apple-properties.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
> index e1926483ae2fd..4c3201e290e29 100644
> --- a/drivers/firmware/efi/apple-properties.c
> +++ b/drivers/firmware/efi/apple-properties.c
> @@ -157,7 +157,7 @@ static int __init unmarshal_devices(struct properties_header *properties)
> if (!entry[0].name)
> goto skip_device;
>
> - ret = device_add_properties(dev, entry); /* makes deep copy */
> + ret = device_create_managed_software_node(dev, entry, NULL);
> if (ret)
> dev_err(dev, "error %d assigning properties\n", ret);
>
> --
> 2.30.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] efi/apple-properties: Handle device properties with software node API
2021-03-04 8:28 [PATCH] efi/apple-properties: Handle device properties with software node API Heikki Krogerus
2021-03-04 8:30 ` Ard Biesheuvel
@ 2021-03-04 9:44 ` Lukas Wunner
2021-03-07 17:08 ` Ard Biesheuvel
1 sibling, 1 reply; 4+ messages in thread
From: Lukas Wunner @ 2021-03-04 9:44 UTC (permalink / raw)
To: Heikki Krogerus; +Cc: Ard Biesheuvel, linux-efi, linux-kernel
On Thu, Mar 04, 2021 at 11:28:37AM +0300, Heikki Krogerus wrote:
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
>
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Acked-by: Lukas Wunner <lukas@wunner.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] efi/apple-properties: Handle device properties with software node API
2021-03-04 9:44 ` Lukas Wunner
@ 2021-03-07 17:08 ` Ard Biesheuvel
0 siblings, 0 replies; 4+ messages in thread
From: Ard Biesheuvel @ 2021-03-07 17:08 UTC (permalink / raw)
To: Lukas Wunner; +Cc: Heikki Krogerus, linux-efi, Linux Kernel Mailing List
On Thu, 4 Mar 2021 at 10:46, Lukas Wunner <lukas@wunner.de> wrote:
>
> On Thu, Mar 04, 2021 at 11:28:37AM +0300, Heikki Krogerus wrote:
> > The old device property API is going to be removed.
> > Replacing the device_add_properties() call with the software
> > node API equivalent, device_create_managed_software_node().
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> Acked-by: Lukas Wunner <lukas@wunner.de>
Queued in efi/next
Thanks all.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-07 17:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 8:28 [PATCH] efi/apple-properties: Handle device properties with software node API Heikki Krogerus
2021-03-04 8:30 ` Ard Biesheuvel
2021-03-04 9:44 ` Lukas Wunner
2021-03-07 17:08 ` Ard Biesheuvel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.