* [PATCH 0/2] make rockchip pinctrl module able
@ 2021-03-05 0:39 ` Jianqun Xu
0 siblings, 0 replies; 14+ messages in thread
From: Jianqun Xu @ 2021-03-05 0:39 UTC (permalink / raw)
To: linus.walleij, heiko, catalin.marinas, will
Cc: linux-gpio, linux-rockchip, Jianqun Xu
Make the rockchip pinctrl driver able to be module by unselect
PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
Jianqun Xu (2):
arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
pinctrl: rockchip: make driver be tristate module
arch/arm64/Kconfig.platforms | 2 --
drivers/pinctrl/Kconfig | 6 +++++-
drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
3 files changed, 18 insertions(+), 3 deletions(-)
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
2021-03-05 0:39 ` Jianqun Xu
@ 2021-03-05 0:39 ` Jianqun Xu
-1 siblings, 0 replies; 14+ messages in thread
From: Jianqun Xu @ 2021-03-05 0:39 UTC (permalink / raw)
To: linus.walleij, heiko, catalin.marinas, will
Cc: linux-gpio, linux-rockchip, Jianqun Xu
Prepare to make pinctrl driver of rockchip to be module able, this patch
remove the select of PINCTRL_ROCKCHIP from ARCH_ROCKCHIP.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
arch/arm64/Kconfig.platforms | 2 --
drivers/pinctrl/Kconfig | 4 ++++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 6eecdef538bd..0371cc02b448 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -227,9 +227,7 @@ config ARCH_RENESAS
config ARCH_ROCKCHIP
bool "Rockchip Platforms"
select ARCH_HAS_RESET_CONTROLLER
- select GPIOLIB
select PINCTRL
- select PINCTRL_ROCKCHIP
select PM
select ROCKCHIP_TIMER
help
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 03c62e1cb395..bf88aac7bcc6 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -210,11 +210,15 @@ config PINCTRL_OXNAS
config PINCTRL_ROCKCHIP
bool
depends on OF
+ select GPIOLIB
select PINMUX
select GENERIC_PINCONF
select GENERIC_IRQ_CHIP
select MFD_SYSCON
select OF_GPIO
+ default ARCH_ROCKCHIP
+ help
+ This support pinctrl and gpio driver for Rockchip SoCs.
config PINCTRL_SINGLE
tristate "One-register-per-pin type device tree based pinctrl driver"
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
@ 2021-03-05 0:39 ` Jianqun Xu
0 siblings, 0 replies; 14+ messages in thread
From: Jianqun Xu @ 2021-03-05 0:39 UTC (permalink / raw)
To: linus.walleij, heiko, catalin.marinas, will
Cc: linux-gpio, linux-rockchip, Jianqun Xu
Prepare to make pinctrl driver of rockchip to be module able, this patch
remove the select of PINCTRL_ROCKCHIP from ARCH_ROCKCHIP.
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
arch/arm64/Kconfig.platforms | 2 --
drivers/pinctrl/Kconfig | 4 ++++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 6eecdef538bd..0371cc02b448 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -227,9 +227,7 @@ config ARCH_RENESAS
config ARCH_ROCKCHIP
bool "Rockchip Platforms"
select ARCH_HAS_RESET_CONTROLLER
- select GPIOLIB
select PINCTRL
- select PINCTRL_ROCKCHIP
select PM
select ROCKCHIP_TIMER
help
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 03c62e1cb395..bf88aac7bcc6 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -210,11 +210,15 @@ config PINCTRL_OXNAS
config PINCTRL_ROCKCHIP
bool
depends on OF
+ select GPIOLIB
select PINMUX
select GENERIC_PINCONF
select GENERIC_IRQ_CHIP
select MFD_SYSCON
select OF_GPIO
+ default ARCH_ROCKCHIP
+ help
+ This support pinctrl and gpio driver for Rockchip SoCs.
config PINCTRL_SINGLE
tristate "One-register-per-pin type device tree based pinctrl driver"
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
2021-03-05 0:39 ` Jianqun Xu
@ 2021-03-22 0:03 ` jay.xu
-1 siblings, 0 replies; 14+ messages in thread
From: jay.xu @ 2021-03-22 0:03 UTC (permalink / raw)
To: 许剑群,
Linus Walleij, Heiko Stübner, Catalin Marinas, Will Deacon
Cc: open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
Hi Heiko
I have seen [0] patch similar to this patch, but is there need to remove select GPIOLIB and PINCTRL_ROCKCHIP from ARCH_ROCKCHIP ?
[0]:https://patchwork.kernel.org/project/linux-rockchip/patch/20210316134059.2377081-1-geert+renesas@glider.be/
Best regards
--------------
jay.xu@rock-chips.com
>Prepare to make pinctrl driver of rockchip to be module able, this patch
>remove the select of PINCTRL_ROCKCHIP from ARCH_ROCKCHIP.
>
>Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>---
> arch/arm64/Kconfig.platforms | 2 --
> drivers/pinctrl/Kconfig | 4 ++++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>index 6eecdef538bd..0371cc02b448 100644
>--- a/arch/arm64/Kconfig.platforms
>+++ b/arch/arm64/Kconfig.platforms
>@@ -227,9 +227,7 @@ config ARCH_RENESAS
> config ARCH_ROCKCHIP
> bool "Rockchip Platforms"
> select ARCH_HAS_RESET_CONTROLLER
>- select GPIOLIB
> select PINCTRL
>- select PINCTRL_ROCKCHIP
> select PM
> select ROCKCHIP_TIMER
> help
>diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
>index 03c62e1cb395..bf88aac7bcc6 100644
>--- a/drivers/pinctrl/Kconfig
>+++ b/drivers/pinctrl/Kconfig
>@@ -210,11 +210,15 @@ config PINCTRL_OXNAS
> config PINCTRL_ROCKCHIP
> bool
> depends on OF
>+ select GPIOLIB
> select PINMUX
> select GENERIC_PINCONF
> select GENERIC_IRQ_CHIP
> select MFD_SYSCON
> select OF_GPIO
>+ default ARCH_ROCKCHIP
>+ help
>+ This support pinctrl and gpio driver for Rockchip SoCs.
>
> config PINCTRL_SINGLE
> tristate "One-register-per-pin type device tree based pinctrl driver"
>--
>2.25.1
>
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/2] arm64: remove select PINCTRL_ROCKCHIP from ARCH_ROCKCHIP
@ 2021-03-22 0:03 ` jay.xu
0 siblings, 0 replies; 14+ messages in thread
From: jay.xu @ 2021-03-22 0:03 UTC (permalink / raw)
To: 许剑群,
Linus Walleij, Heiko Stübner, Catalin Marinas, Will Deacon
Cc: open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
Hi Heiko
I have seen [0] patch similar to this patch, but is there need to remove select GPIOLIB and PINCTRL_ROCKCHIP from ARCH_ROCKCHIP ?
[0]:https://patchwork.kernel.org/project/linux-rockchip/patch/20210316134059.2377081-1-geert+renesas@glider.be/
Best regards
--------------
jay.xu@rock-chips.com
>Prepare to make pinctrl driver of rockchip to be module able, this patch
>remove the select of PINCTRL_ROCKCHIP from ARCH_ROCKCHIP.
>
>Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
>---
> arch/arm64/Kconfig.platforms | 2 --
> drivers/pinctrl/Kconfig | 4 ++++
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
>index 6eecdef538bd..0371cc02b448 100644
>--- a/arch/arm64/Kconfig.platforms
>+++ b/arch/arm64/Kconfig.platforms
>@@ -227,9 +227,7 @@ config ARCH_RENESAS
> config ARCH_ROCKCHIP
> bool "Rockchip Platforms"
> select ARCH_HAS_RESET_CONTROLLER
>- select GPIOLIB
> select PINCTRL
>- select PINCTRL_ROCKCHIP
> select PM
> select ROCKCHIP_TIMER
> help
>diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
>index 03c62e1cb395..bf88aac7bcc6 100644
>--- a/drivers/pinctrl/Kconfig
>+++ b/drivers/pinctrl/Kconfig
>@@ -210,11 +210,15 @@ config PINCTRL_OXNAS
> config PINCTRL_ROCKCHIP
> bool
> depends on OF
>+ select GPIOLIB
> select PINMUX
> select GENERIC_PINCONF
> select GENERIC_IRQ_CHIP
> select MFD_SYSCON
> select OF_GPIO
>+ default ARCH_ROCKCHIP
>+ help
>+ This support pinctrl and gpio driver for Rockchip SoCs.
>
> config PINCTRL_SINGLE
> tristate "One-register-per-pin type device tree based pinctrl driver"
>--
>2.25.1
>
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/2] pinctrl: rockchip: make driver be tristate module
2021-03-05 0:39 ` Jianqun Xu
@ 2021-03-05 0:39 ` Jianqun Xu
-1 siblings, 0 replies; 14+ messages in thread
From: Jianqun Xu @ 2021-03-05 0:39 UTC (permalink / raw)
To: linus.walleij, heiko, catalin.marinas, will
Cc: linux-gpio, linux-rockchip, Jianqun Xu
Make pinctrl-rockchip driver to be tristate module, support to build as
a module, this is useful for GKI.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
drivers/pinctrl/Kconfig | 2 +-
drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bf88aac7bcc6..04d1bd8b8d83 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -208,7 +208,7 @@ config PINCTRL_OXNAS
select MFD_SYSCON
config PINCTRL_ROCKCHIP
- bool
+ tristate "Rockchip gpio and pinctrl driver"
depends on OF
select GPIOLIB
select PINMUX
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index aa1a1c850d05..70dc03af5699 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -16,10 +16,12 @@
*/
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/io.h>
#include <linux/bitops.h>
#include <linux/gpio/driver.h>
+#include <linux/of_device.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/pinctrl/machine.h>
@@ -4256,3 +4258,14 @@ static int __init rockchip_pinctrl_drv_register(void)
return platform_driver_register(&rockchip_pinctrl_driver);
}
postcore_initcall(rockchip_pinctrl_drv_register);
+
+static void __exit rockchip_pinctrl_drv_unregister(void)
+{
+ platform_driver_unregister(&rockchip_pinctrl_driver);
+}
+module_exit(rockchip_pinctrl_drv_unregister);
+
+MODULE_DESCRIPTION("ROCKCHIP Pin Controller Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:pinctrl-rockchip");
+MODULE_DEVICE_TABLE(of, rockchip_pinctrl_dt_match);
--
2.25.1
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH 2/2] pinctrl: rockchip: make driver be tristate module
@ 2021-03-05 0:39 ` Jianqun Xu
0 siblings, 0 replies; 14+ messages in thread
From: Jianqun Xu @ 2021-03-05 0:39 UTC (permalink / raw)
To: linus.walleij, heiko, catalin.marinas, will
Cc: linux-gpio, linux-rockchip, Jianqun Xu
Make pinctrl-rockchip driver to be tristate module, support to build as
a module, this is useful for GKI.
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Jianqun Xu <jay.xu@rock-chips.com>
---
drivers/pinctrl/Kconfig | 2 +-
drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index bf88aac7bcc6..04d1bd8b8d83 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -208,7 +208,7 @@ config PINCTRL_OXNAS
select MFD_SYSCON
config PINCTRL_ROCKCHIP
- bool
+ tristate "Rockchip gpio and pinctrl driver"
depends on OF
select GPIOLIB
select PINMUX
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index aa1a1c850d05..70dc03af5699 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -16,10 +16,12 @@
*/
#include <linux/init.h>
+#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/io.h>
#include <linux/bitops.h>
#include <linux/gpio/driver.h>
+#include <linux/of_device.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/pinctrl/machine.h>
@@ -4256,3 +4258,14 @@ static int __init rockchip_pinctrl_drv_register(void)
return platform_driver_register(&rockchip_pinctrl_driver);
}
postcore_initcall(rockchip_pinctrl_drv_register);
+
+static void __exit rockchip_pinctrl_drv_unregister(void)
+{
+ platform_driver_unregister(&rockchip_pinctrl_driver);
+}
+module_exit(rockchip_pinctrl_drv_unregister);
+
+MODULE_DESCRIPTION("ROCKCHIP Pin Controller Driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:pinctrl-rockchip");
+MODULE_DEVICE_TABLE(of, rockchip_pinctrl_dt_match);
--
2.25.1
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] make rockchip pinctrl module able
2021-03-05 0:39 ` Jianqun Xu
@ 2021-03-10 22:57 ` Linus Walleij
-1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2021-03-10 22:57 UTC (permalink / raw)
To: Jianqun Xu
Cc: Heiko Stübner, Catalin Marinas, Will Deacon,
open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> Make the rockchip pinctrl driver able to be module by unselect
> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
This patch set fails like this:
ERROR: modpost: "irq_gc_set_wake"
[drivers/pinctrl/pinctrl-rockchip.ko] undefined!
make[3]: *** [../scripts/Makefile.modpost:132: Module.symvers] Error 1
make[3]: *** Deleting file 'Module.symvers'
make[2]: *** [/home/linus/linux-pinctrl/Makefile:1440: modules] Error 2
Probably this function needs to get exported. (Send a separate
patch for that.)
Yours,
Linus Walleij
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] make rockchip pinctrl module able
@ 2021-03-10 22:57 ` Linus Walleij
0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2021-03-10 22:57 UTC (permalink / raw)
To: Jianqun Xu
Cc: Heiko Stübner, Catalin Marinas, Will Deacon,
open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> Make the rockchip pinctrl driver able to be module by unselect
> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
This patch set fails like this:
ERROR: modpost: "irq_gc_set_wake"
[drivers/pinctrl/pinctrl-rockchip.ko] undefined!
make[3]: *** [../scripts/Makefile.modpost:132: Module.symvers] Error 1
make[3]: *** Deleting file 'Module.symvers'
make[2]: *** [/home/linus/linux-pinctrl/Makefile:1440: modules] Error 2
Probably this function needs to get exported. (Send a separate
patch for that.)
Yours,
Linus Walleij
Yours,
Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] make rockchip pinctrl module able
2021-03-05 0:39 ` Jianqun Xu
@ 2021-03-15 15:32 ` Linus Walleij
-1 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2021-03-15 15:32 UTC (permalink / raw)
To: Jianqun Xu
Cc: Heiko Stübner, Catalin Marinas, Will Deacon,
open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> Make the rockchip pinctrl driver able to be module by unselect
> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
Applied this again with the irqchip patch under, let's see how this
works!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/2] make rockchip pinctrl module able
@ 2021-03-15 15:32 ` Linus Walleij
0 siblings, 0 replies; 14+ messages in thread
From: Linus Walleij @ 2021-03-15 15:32 UTC (permalink / raw)
To: Jianqun Xu
Cc: Heiko Stübner, Catalin Marinas, Will Deacon,
open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
> Make the rockchip pinctrl driver able to be module by unselect
> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
Applied this again with the irqchip patch under, let's see how this
works!
Yours,
Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Re: [PATCH 0/2] make rockchip pinctrl module able
2021-03-15 15:32 ` Linus Walleij
@ 2021-03-16 0:07 ` jay.xu
-1 siblings, 0 replies; 14+ messages in thread
From: jay.xu @ 2021-03-16 0:07 UTC (permalink / raw)
To: Linus Walleij
Cc: Heiko Stübner, Catalin Marinas, Will Deacon,
open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
Thanks very much
--------------
jay.xu@rock-chips.com
>On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
>> Make the rockchip pinctrl driver able to be module by unselect
>> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
>
>Applied this again with the irqchip patch under, let's see how this
>works!
>
>Yours,
>Linus Walleij
>
>
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: Re: [PATCH 0/2] make rockchip pinctrl module able
@ 2021-03-16 0:07 ` jay.xu
0 siblings, 0 replies; 14+ messages in thread
From: jay.xu @ 2021-03-16 0:07 UTC (permalink / raw)
To: Linus Walleij
Cc: Heiko Stübner, Catalin Marinas, Will Deacon,
open list:GPIO SUBSYSTEM, open list:ARM/Rockchip SoC...
Thanks very much
--------------
jay.xu@rock-chips.com
>On Fri, Mar 5, 2021 at 1:39 AM Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
>> Make the rockchip pinctrl driver able to be module by unselect
>> PINCTRL_ROCKCHIP from ARCH_ROCKCHIP, then modify driver module define.
>
>Applied this again with the irqchip patch under, let's see how this
>works!
>
>Yours,
>Linus Walleij
>
>
>
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
^ permalink raw reply [flat|nested] 14+ messages in thread