All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs/squashfs: Fix compilation error
@ 2021-03-03  9:52 Pali Rohár
  2021-03-03 13:23 ` Tom Rini
  2021-03-05  2:02 ` Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Pali Rohár @ 2021-03-03  9:52 UTC (permalink / raw)
  To: u-boot

Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop
asm/global_data.h from common header") broke compilation of squashfs
filesystem when CONFIG_CMD_SQUASHFS=y is enabled.

Compilation is failing on error:

    aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu'

Fixes: 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header")
Suggested-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Pali Roh?r <pali@kernel.org>
---
Please include this change into U-Boot master branch which is currently
affected by this issue.
---
 fs/squashfs/sqfs_inode.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/squashfs/sqfs_inode.c b/fs/squashfs/sqfs_inode.c
index e76ec7cbdfd9..d25cfb53e75d 100644
--- a/fs/squashfs/sqfs_inode.c
+++ b/fs/squashfs/sqfs_inode.c
@@ -6,6 +6,7 @@
  */
 
 #include <asm/unaligned.h>
+#include <compiler.h>
 #include <errno.h>
 #include <stdint.h>
 #include <stdio.h>
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] fs/squashfs: Fix compilation error
  2021-03-03  9:52 [PATCH] fs/squashfs: Fix compilation error Pali Rohár
@ 2021-03-03 13:23 ` Tom Rini
  2021-03-05  2:02 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-03-03 13:23 UTC (permalink / raw)
  To: u-boot

On Wed, Mar 03, 2021 at 10:52:36AM +0100, Pali Roh?r wrote:

> Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop
> asm/global_data.h from common header") broke compilation of squashfs
> filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
> 
> Compilation is failing on error:
> 
>     aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu'
> 
> Fixes: 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header")
> Suggested-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Pali Roh?r <pali@kernel.org>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210303/13938892/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] fs/squashfs: Fix compilation error
  2021-03-03  9:52 [PATCH] fs/squashfs: Fix compilation error Pali Rohár
  2021-03-03 13:23 ` Tom Rini
@ 2021-03-05  2:02 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2021-03-05  2:02 UTC (permalink / raw)
  To: u-boot

On Wed, Mar 03, 2021 at 10:52:36AM +0100, Pali Roh?r wrote:

> Commit 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop
> asm/global_data.h from common header") broke compilation of squashfs
> filesystem when CONFIG_CMD_SQUASHFS=y is enabled.
> 
> Compilation is failing on error:
> 
>     aarch64-linux-gnu-ld.bfd: u-boot/fs/squashfs/sqfs_inode.c:121: undefined reference to `le32_to_cpu'
> 
> Fixes: 401d1c4f5d2d29c4bc4beaec95402ca23eb63295 ("common: Drop asm/global_data.h from common header")
> Suggested-by: Tom Rini <trini@konsulko.com>
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210304/178b773e/attachment.sig>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-05  2:02 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03  9:52 [PATCH] fs/squashfs: Fix compilation error Pali Rohár
2021-03-03 13:23 ` Tom Rini
2021-03-05  2:02 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.