* [PATCH] net: intel: iavf: fix error return code of iavf_init_get_resources()
@ 2021-03-05 3:10 ` Jia-Ju Bai
0 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2021-03-05 3:10 UTC (permalink / raw)
To: jesse.brandeburg, anthony.l.nguyen, davem, kuba
Cc: intel-wired-lan, netdev, linux-kernel, Jia-Ju Bai
When iavf_process_config() fails, no error return code of
iavf_init_get_resources() is assigned.
To fix this bug, err is assigned with the return value of
iavf_process_config(), and then err is checked.
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 0a867d64d467..dc5b3c06d1e0 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -1776,7 +1776,8 @@ static int iavf_init_get_resources(struct iavf_adapter *adapter)
goto err_alloc;
}
- if (iavf_process_config(adapter))
+ err = iavf_process_config(adapter);
+ if (err)
goto err_alloc;
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] net: intel: iavf: fix error return code of iavf_init_get_resources()
@ 2021-03-05 3:10 ` Jia-Ju Bai
0 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2021-03-05 3:10 UTC (permalink / raw)
To: intel-wired-lan
When iavf_process_config() fails, no error return code of
iavf_init_get_resources() is assigned.
To fix this bug, err is assigned with the return value of
iavf_process_config(), and then err is checked.
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index 0a867d64d467..dc5b3c06d1e0 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -1776,7 +1776,8 @@ static int iavf_init_get_resources(struct iavf_adapter *adapter)
goto err_alloc;
}
- if (iavf_process_config(adapter))
+ err = iavf_process_config(adapter);
+ if (err)
goto err_alloc;
adapter->current_op = VIRTCHNL_OP_UNKNOWN;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: intel: iavf: fix error return code of iavf_init_get_resources()
2021-03-05 3:10 ` [Intel-wired-lan] " Jia-Ju Bai
@ 2021-03-05 21:10 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-05 21:10 UTC (permalink / raw)
To: Jia-Ju Bai
Cc: jesse.brandeburg, anthony.l.nguyen, davem, kuba, intel-wired-lan,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 4 Mar 2021 19:10:10 -0800 you wrote:
> When iavf_process_config() fails, no error return code of
> iavf_init_get_resources() is assigned.
> To fix this bug, err is assigned with the return value of
> iavf_process_config(), and then err is checked.
>
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>
> [...]
Here is the summary with links:
- net: intel: iavf: fix error return code of iavf_init_get_resources()
https://git.kernel.org/netdev/net/c/6650d31f21b8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] net: intel: iavf: fix error return code of iavf_init_get_resources()
@ 2021-03-05 21:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-05 21:10 UTC (permalink / raw)
To: intel-wired-lan
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 4 Mar 2021 19:10:10 -0800 you wrote:
> When iavf_process_config() fails, no error return code of
> iavf_init_get_resources() is assigned.
> To fix this bug, err is assigned with the return value of
> iavf_process_config(), and then err is checked.
>
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>
> [...]
Here is the summary with links:
- net: intel: iavf: fix error return code of iavf_init_get_resources()
https://git.kernel.org/netdev/net/c/6650d31f21b8
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-05 21:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 3:10 [PATCH] net: intel: iavf: fix error return code of iavf_init_get_resources() Jia-Ju Bai
2021-03-05 3:10 ` [Intel-wired-lan] " Jia-Ju Bai
2021-03-05 21:10 ` patchwork-bot+netdevbpf
2021-03-05 21:10 ` [Intel-wired-lan] " patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.