All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm
@ 2021-03-05  6:41 Nishanth Menon
  2021-03-05  6:45 ` Nishanth Menon
  2021-03-05  7:04 ` [EXTERNAL,dunfell] " Lokesh Vutla
  0 siblings, 2 replies; 10+ messages in thread
From: Nishanth Menon @ 2021-03-05  6:41 UTC (permalink / raw)
  To: meta-ti; +Cc: Denys Dmytriyenko, Bajjuri, Praneeth, Nishanth Menon

"evm" prefix messes up the pattern matchup for J7200 and falls back into
default, as a result, we attempt to pull [1] instead of [2].

[1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
[2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz

Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
Signed-off-by: Nishanth Menon <nm@ti.com>
---
 recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
index ed62b876e4db..dffd51abda66 100644
--- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
+++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
@@ -31,7 +31,7 @@ DEFAULT_RTOS_VERSION_DOT_am65xx = "07.03.00.10"
 
 DEFAULT_RTOS_SOC = "undefined"
 DEFAULT_RTOS_SOC_j7 = "j721e"
-DEFAULT_RTOS_SOC_j7200-evm = "j7200"
+DEFAULT_RTOS_SOC_j7200 = "j7200"
 DEFAULT_RTOS_SOC_am65xx = "am65xx"
 DEFAULT_RTOS_SOC_am64xx = "am64x"
 
@@ -47,7 +47,7 @@ DEFAULT_FIRMWARE_URL_k3 = "${CORESDK_RTOS_WEBLINK}/${DEFAULT_FIRMWARE_FILE}"
 
 DEFAULT_FIRMWARE_SHA256SUM = "unknown"
 DEFAULT_FIRMWARE_SHA256SUM_j7 = "69cc16c30c895fe813002bd7bdb3d30e6ca622d86b008a6bf6e2a24b86550969"
-DEFAULT_FIRMWARE_SHA256SUM_j7200-evm = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
+DEFAULT_FIRMWARE_SHA256SUM_j7200 = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
 DEFAULT_FIRMWARE_SHA256SUM_am65xx = "aa121c10d3099dd61ef898717245ecee25b501170607c9a95afd741e05783a5d"
 DEFAULT_FIRMWARE_SHA256SUM_am64xx = "9e9efeef0b1dbb101de97e58cfda8bf052a697f2ea635fdf6ca5158fffdc212b"
 
-- 
2.25.1.377.g2d2118b814c1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  6:41 [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm Nishanth Menon
@ 2021-03-05  6:45 ` Nishanth Menon
  2021-03-05  8:06   ` Denys Dmytriyenko
       [not found]   ` <166963B5CCB828E3.16425@lists.yoctoproject.org>
  2021-03-05  7:04 ` [EXTERNAL,dunfell] " Lokesh Vutla
  1 sibling, 2 replies; 10+ messages in thread
From: Nishanth Menon @ 2021-03-05  6:45 UTC (permalink / raw)
  To: meta-ti; +Cc: Denys Dmytriyenko, Bajjuri, Praneeth

On 00:41-20210305, Nishanth Menon wrote:
> "evm" prefix messes up the pattern matchup for J7200 and falls back into
> default, as a result, we attempt to pull [1] instead of [2].
> 
> [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz

^^ above link should have been:
https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_10_firmware.tar.xz

if you need me to send a v2 with fixups, i can.. or if that is the only
comment, then might be helpful to get a fixup while applying..

> 
> Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> index ed62b876e4db..dffd51abda66 100644
> --- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> +++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> @@ -31,7 +31,7 @@ DEFAULT_RTOS_VERSION_DOT_am65xx = "07.03.00.10"
>  
>  DEFAULT_RTOS_SOC = "undefined"
>  DEFAULT_RTOS_SOC_j7 = "j721e"
> -DEFAULT_RTOS_SOC_j7200-evm = "j7200"
> +DEFAULT_RTOS_SOC_j7200 = "j7200"
>  DEFAULT_RTOS_SOC_am65xx = "am65xx"
>  DEFAULT_RTOS_SOC_am64xx = "am64x"
>  
> @@ -47,7 +47,7 @@ DEFAULT_FIRMWARE_URL_k3 = "${CORESDK_RTOS_WEBLINK}/${DEFAULT_FIRMWARE_FILE}"
>  
>  DEFAULT_FIRMWARE_SHA256SUM = "unknown"
>  DEFAULT_FIRMWARE_SHA256SUM_j7 = "69cc16c30c895fe813002bd7bdb3d30e6ca622d86b008a6bf6e2a24b86550969"
> -DEFAULT_FIRMWARE_SHA256SUM_j7200-evm = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> +DEFAULT_FIRMWARE_SHA256SUM_j7200 = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
>  DEFAULT_FIRMWARE_SHA256SUM_am65xx = "aa121c10d3099dd61ef898717245ecee25b501170607c9a95afd741e05783a5d"
>  DEFAULT_FIRMWARE_SHA256SUM_am64xx = "9e9efeef0b1dbb101de97e58cfda8bf052a697f2ea635fdf6ca5158fffdc212b"
>  
> -- 
> 2.25.1.377.g2d2118b814c1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXTERNAL,dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  6:41 [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm Nishanth Menon
  2021-03-05  6:45 ` Nishanth Menon
@ 2021-03-05  7:04 ` Lokesh Vutla
  2021-03-05  7:11   ` Nishanth Menon
  1 sibling, 1 reply; 10+ messages in thread
From: Lokesh Vutla @ 2021-03-05  7:04 UTC (permalink / raw)
  To: Nishanth Menon via lists.yoctoproject.org, meta-ti
  Cc: Denys Dmytriyenko, Bajjuri, Praneeth, Nishanth Menon



On 05/03/21 6:11 pm, Nishanth Menon via lists.yoctoproject.org wrote:
> "evm" prefix messes up the pattern matchup for J7200 and falls back into
> default, as a result, we attempt to pull [1] instead of [2].
> 
> [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> 
> Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> Signed-off-by: Nishanth Menon <nm@ti.com>

For the sake of completeness can you add default web link for j7200? I still
couldn't figure out how the weblink is populated when default is undefined.

  DEFAULT_RTOS_WEBLINK_j7200 =
"https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"

However, for the patch

Tested-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks and regards,
Lokesh



> 
> ---
> recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> index ed62b876e4db..dffd51abda66 100644
> --- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> +++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> @@ -31,7 +31,7 @@ DEFAULT_RTOS_VERSION_DOT_am65xx = "07.03.00.10"
>  
>  DEFAULT_RTOS_SOC = "undefined"
>  DEFAULT_RTOS_SOC_j7 = "j721e"
> -DEFAULT_RTOS_SOC_j7200-evm = "j7200"
> +DEFAULT_RTOS_SOC_j7200 = "j7200"
>  DEFAULT_RTOS_SOC_am65xx = "am65xx"
>  DEFAULT_RTOS_SOC_am64xx = "am64x"
>  
> @@ -47,7 +47,7 @@ DEFAULT_FIRMWARE_URL_k3 = "${CORESDK_RTOS_WEBLINK}/${DEFAULT_FIRMWARE_FILE}"
>  
>  DEFAULT_FIRMWARE_SHA256SUM = "unknown"
>  DEFAULT_FIRMWARE_SHA256SUM_j7 = "69cc16c30c895fe813002bd7bdb3d30e6ca622d86b008a6bf6e2a24b86550969"
> -DEFAULT_FIRMWARE_SHA256SUM_j7200-evm = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> +DEFAULT_FIRMWARE_SHA256SUM_j7200 = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
>  DEFAULT_FIRMWARE_SHA256SUM_am65xx = "aa121c10d3099dd61ef898717245ecee25b501170607c9a95afd741e05783a5d"
>  DEFAULT_FIRMWARE_SHA256SUM_am64xx = "9e9efeef0b1dbb101de97e58cfda8bf052a697f2ea635fdf6ca5158fffdc212b"
>  
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXTERNAL,dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  7:04 ` [EXTERNAL,dunfell] " Lokesh Vutla
@ 2021-03-05  7:11   ` Nishanth Menon
  2021-03-05  7:44     ` Lokesh Vutla
  2021-03-05  8:23     ` Denys Dmytriyenko
  0 siblings, 2 replies; 10+ messages in thread
From: Nishanth Menon @ 2021-03-05  7:11 UTC (permalink / raw)
  To: Lokesh Vutla
  Cc: Nishanth Menon via lists.yoctoproject.org, meta-ti,
	Denys Dmytriyenko, Bajjuri, Praneeth

On 12:34-20210305, Lokesh Vutla wrote:
> 
> 
> On 05/03/21 6:11 pm, Nishanth Menon via lists.yoctoproject.org wrote:
> > "evm" prefix messes up the pattern matchup for J7200 and falls back into
> > default, as a result, we attempt to pull [1] instead of [2].
> > 
> > [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > 
> > Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> For the sake of completeness can you add default web link for j7200? I still
> couldn't figure out how the weblink is populated when default is undefined.
> 
>   DEFAULT_RTOS_WEBLINK_j7200 =
> "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
> 

I believe _j7 does matchup j7200, hence it works and adding _j7200 will
be redundant..

DEFAULT_RTOS_WEBLINK_j7 = "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"

I am a noobie on this, so will be interested in folk's feedback.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXTERNAL,dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  7:11   ` Nishanth Menon
@ 2021-03-05  7:44     ` Lokesh Vutla
  2021-03-05  8:23     ` Denys Dmytriyenko
  1 sibling, 0 replies; 10+ messages in thread
From: Lokesh Vutla @ 2021-03-05  7:44 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Nishanth Menon via lists.yoctoproject.org, meta-ti,
	Denys Dmytriyenko, Bajjuri, Praneeth



On 05/03/21 12:41 pm, Nishanth Menon wrote:
> On 12:34-20210305, Lokesh Vutla wrote:
>>
>>
>> On 05/03/21 6:11 pm, Nishanth Menon via lists.yoctoproject.org wrote:
>>> "evm" prefix messes up the pattern matchup for J7200 and falls back into
>>> default, as a result, we attempt to pull [1] instead of [2].
>>>
>>> [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
>>> [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
>>>
>>> Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>
>> For the sake of completeness can you add default web link for j7200? I still
>> couldn't figure out how the weblink is populated when default is undefined.
>>
>>   DEFAULT_RTOS_WEBLINK_j7200 =
>> "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
>>
> 
> I believe _j7 does matchup j7200, hence it works and adding _j7200 will
> be redundant..
> 
> DEFAULT_RTOS_WEBLINK_j7 = "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"

looks like it is...
j7200 machine include conf/machine/include/j7.inc

which has SOC_FAMILY_append = ":j7"


I see URLs for all the SoCs except for j7200. Just trying to be consistent :)

Thanks and regards,
Lokesh

> 
> I am a noobie on this, so will be interested in folk's feedback.
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  6:45 ` Nishanth Menon
@ 2021-03-05  8:06   ` Denys Dmytriyenko
       [not found]   ` <166963B5CCB828E3.16425@lists.yoctoproject.org>
  1 sibling, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2021-03-05  8:06 UTC (permalink / raw)
  To: Nishanth Menon; +Cc: meta-ti, Bajjuri, Praneeth

On Fri, Mar 05, 2021 at 12:45:53AM -0600, Nishanth Menon wrote:
> On 00:41-20210305, Nishanth Menon wrote:
> > "evm" prefix messes up the pattern matchup for J7200 and falls back into
> > default, as a result, we attempt to pull [1] instead of [2].
> > 
> > [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> 
> ^^ above link should have been:
> https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_10_firmware.tar.xz
> 
> if you need me to send a v2 with fixups, i can.. or if that is the only
> comment, then might be helpful to get a fixup while applying..

I'm failing to see the issue here...

Of course, using "_j7200" instead of "_j7200-evm" is more preferred to cover 
other variants, like potential "j7200-hs-evm", but when building for j7200-evm 
should result in the same output. I would need to reproduce it - any another 
pointers?


> > Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> > ---
> >  recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > index ed62b876e4db..dffd51abda66 100644
> > --- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > +++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > @@ -31,7 +31,7 @@ DEFAULT_RTOS_VERSION_DOT_am65xx = "07.03.00.10"
> >  
> >  DEFAULT_RTOS_SOC = "undefined"
> >  DEFAULT_RTOS_SOC_j7 = "j721e"
> > -DEFAULT_RTOS_SOC_j7200-evm = "j7200"
> > +DEFAULT_RTOS_SOC_j7200 = "j7200"
> >  DEFAULT_RTOS_SOC_am65xx = "am65xx"
> >  DEFAULT_RTOS_SOC_am64xx = "am64x"
> >  
> > @@ -47,7 +47,7 @@ DEFAULT_FIRMWARE_URL_k3 = "${CORESDK_RTOS_WEBLINK}/${DEFAULT_FIRMWARE_FILE}"
> >  
> >  DEFAULT_FIRMWARE_SHA256SUM = "unknown"
> >  DEFAULT_FIRMWARE_SHA256SUM_j7 = "69cc16c30c895fe813002bd7bdb3d30e6ca622d86b008a6bf6e2a24b86550969"
> > -DEFAULT_FIRMWARE_SHA256SUM_j7200-evm = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> > +DEFAULT_FIRMWARE_SHA256SUM_j7200 = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> >  DEFAULT_FIRMWARE_SHA256SUM_am65xx = "aa121c10d3099dd61ef898717245ecee25b501170607c9a95afd741e05783a5d"
> >  DEFAULT_FIRMWARE_SHA256SUM_am64xx = "9e9efeef0b1dbb101de97e58cfda8bf052a697f2ea635fdf6ca5158fffdc212b"
> >  
> > -- 
> > 2.25.1.377.g2d2118b814c1
> > 
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [meta-ti] [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm
       [not found]   ` <166963B5CCB828E3.16425@lists.yoctoproject.org>
@ 2021-03-05  8:13     ` Denys Dmytriyenko
  0 siblings, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2021-03-05  8:13 UTC (permalink / raw)
  To: Nishanth Menon; +Cc: meta-ti, Bajjuri, Praneeth

On Fri, Mar 05, 2021 at 03:06:08AM -0500, Denys Dmytriyenko wrote:
> On Fri, Mar 05, 2021 at 12:45:53AM -0600, Nishanth Menon wrote:
> > On 00:41-20210305, Nishanth Menon wrote:
> > > "evm" prefix messes up the pattern matchup for J7200 and falls back into
> > > default, as a result, we attempt to pull [1] instead of [2].
> > > 
> > > [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > > [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > 
> > ^^ above link should have been:
> > https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_10_firmware.tar.xz
> > 
> > if you need me to send a v2 with fixups, i can.. or if that is the only
> > comment, then might be helpful to get a fixup while applying..
> 
> I'm failing to see the issue here...
> 
> Of course, using "_j7200" instead of "_j7200-evm" is more preferred to cover 

Actually, that is wishful thinking - there's NO "j7200" SOC_FAMILY set up at 
all! So this patch is completely incorrect, as there's no such override as 
_j7200, only _j7200-evm. Something else is going on...


> other variants, like potential "j7200-hs-evm", but when building for j7200-evm 
> should result in the same output. I would need to reproduce it - any another 
> pointers?
> 
> 
> > > Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> > > Signed-off-by: Nishanth Menon <nm@ti.com>
> > > ---
> > >  recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > diff --git a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > > index ed62b876e4db..dffd51abda66 100644
> > > --- a/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > > +++ b/recipes-ti/ti-rtos-bin/ti-rtos-firmware.bb
> > > @@ -31,7 +31,7 @@ DEFAULT_RTOS_VERSION_DOT_am65xx = "07.03.00.10"
> > >  
> > >  DEFAULT_RTOS_SOC = "undefined"
> > >  DEFAULT_RTOS_SOC_j7 = "j721e"
> > > -DEFAULT_RTOS_SOC_j7200-evm = "j7200"
> > > +DEFAULT_RTOS_SOC_j7200 = "j7200"
> > >  DEFAULT_RTOS_SOC_am65xx = "am65xx"
> > >  DEFAULT_RTOS_SOC_am64xx = "am64x"
> > >  
> > > @@ -47,7 +47,7 @@ DEFAULT_FIRMWARE_URL_k3 = "${CORESDK_RTOS_WEBLINK}/${DEFAULT_FIRMWARE_FILE}"
> > >  
> > >  DEFAULT_FIRMWARE_SHA256SUM = "unknown"
> > >  DEFAULT_FIRMWARE_SHA256SUM_j7 = "69cc16c30c895fe813002bd7bdb3d30e6ca622d86b008a6bf6e2a24b86550969"
> > > -DEFAULT_FIRMWARE_SHA256SUM_j7200-evm = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> > > +DEFAULT_FIRMWARE_SHA256SUM_j7200 = "a16865d928b2b00bfca64e0c41b02dcfc0ac8ec1ce125fbfd3581a1c610847f8"
> > >  DEFAULT_FIRMWARE_SHA256SUM_am65xx = "aa121c10d3099dd61ef898717245ecee25b501170607c9a95afd741e05783a5d"
> > >  DEFAULT_FIRMWARE_SHA256SUM_am64xx = "9e9efeef0b1dbb101de97e58cfda8bf052a697f2ea635fdf6ca5158fffdc212b"
> > >  
> > > -- 
> > > 2.25.1.377.g2d2118b814c1
> > > 
> > 
> > -- 
> > Regards,
> > Nishanth Menon
> > Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
> > 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXTERNAL,dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  7:11   ` Nishanth Menon
  2021-03-05  7:44     ` Lokesh Vutla
@ 2021-03-05  8:23     ` Denys Dmytriyenko
  2021-03-05  9:08       ` Lokesh Vutla
  1 sibling, 1 reply; 10+ messages in thread
From: Denys Dmytriyenko @ 2021-03-05  8:23 UTC (permalink / raw)
  To: Nishanth Menon
  Cc: Lokesh Vutla, Nishanth Menon via lists.yoctoproject.org, meta-ti,
	Bajjuri, Praneeth

On Fri, Mar 05, 2021 at 01:11:05AM -0600, Nishanth Menon wrote:
> On 12:34-20210305, Lokesh Vutla wrote:
> > 
> > 
> > On 05/03/21 6:11 pm, Nishanth Menon via lists.yoctoproject.org wrote:
> > > "evm" prefix messes up the pattern matchup for J7200 and falls back into
> > > default, as a result, we attempt to pull [1] instead of [2].
> > > 
> > > [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > > [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> > > 
> > > Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> > > Signed-off-by: Nishanth Menon <nm@ti.com>
> > 
> > For the sake of completeness can you add default web link for j7200? I still
> > couldn't figure out how the weblink is populated when default is undefined.
> > 
> >   DEFAULT_RTOS_WEBLINK_j7200 =
> > "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
> > 
> 
> I believe _j7 does matchup j7200, hence it works and adding _j7200 will
> be redundant..

From least specific to most specific for j7200-evm machine:

MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7200-evm"

For comparison, the same for j7-evm:

MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7-evm"

Or j7-hs-evm:

MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7-hs-evm"

All of them are in the same "j7" SOC_FAMILY, as that was supposed to be a 
superset for J7 family, even though ended up being rather specific to j721e...

So, when you use _j7 override, that covers j7-evm, j7-hs-evm, j7200-evm an so 
on.


> DEFAULT_RTOS_WEBLINK_j7 = "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
> 
> I am a noobie on this, so will be interested in folk's feedback.
> 
> -- 
> Regards,
> Nishanth Menon
> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXTERNAL,dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  8:23     ` Denys Dmytriyenko
@ 2021-03-05  9:08       ` Lokesh Vutla
  2021-03-05 17:14         ` Denys Dmytriyenko
  0 siblings, 1 reply; 10+ messages in thread
From: Lokesh Vutla @ 2021-03-05  9:08 UTC (permalink / raw)
  To: Denys Dmytriyenko, Nishanth Menon
  Cc: Nishanth Menon via lists.yoctoproject.org, meta-ti, Bajjuri, Praneeth

Hi Denys,

On 05/03/21 1:53 pm, Denys Dmytriyenko wrote:
> On Fri, Mar 05, 2021 at 01:11:05AM -0600, Nishanth Menon wrote:
>> On 12:34-20210305, Lokesh Vutla wrote:
>>>
>>>
>>> On 05/03/21 6:11 pm, Nishanth Menon via lists.yoctoproject.org wrote:
>>>> "evm" prefix messes up the pattern matchup for J7200 and falls back into
>>>> default, as a result, we attempt to pull [1] instead of [2].
>>>>
>>>> [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
>>>> [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
>>>>
>>>> Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
>>>> Signed-off-by: Nishanth Menon <nm@ti.com>
>>>
>>> For the sake of completeness can you add default web link for j7200? I still
>>> couldn't figure out how the weblink is populated when default is undefined.
>>>
>>>   DEFAULT_RTOS_WEBLINK_j7200 =
>>> "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
>>>
>>
>> I believe _j7 does matchup j7200, hence it works and adding _j7200 will
>> be redundant..
> 
> From least specific to most specific for j7200-evm machine:
> 
> MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7200-evm"

Thanks for the explanation. Where does this variable (MACHINEOVERRIDES) get
populated?

Thanks and regards,
Lokesh

> 
> For comparison, the same for j7-evm:
> 
> MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7-evm"
> 
> Or j7-hs-evm:
> 
> MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7-hs-evm"
> 
> All of them are in the same "j7" SOC_FAMILY, as that was supposed to be a 
> superset for J7 family, even though ended up being rather specific to j721e...
> 
> So, when you use _j7 override, that covers j7-evm, j7-hs-evm, j7200-evm an so 
> on.
> 
> 
>> DEFAULT_RTOS_WEBLINK_j7 = "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
>>
>> I am a noobie on this, so will be interested in folk's feedback.
>>
>> -- 
>> Regards,
>> Nishanth Menon
>> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
>>
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [EXTERNAL,dunfell] ti-rtos: Fix J7200 builds by dropping evm
  2021-03-05  9:08       ` Lokesh Vutla
@ 2021-03-05 17:14         ` Denys Dmytriyenko
  0 siblings, 0 replies; 10+ messages in thread
From: Denys Dmytriyenko @ 2021-03-05 17:14 UTC (permalink / raw)
  To: Lokesh Vutla; +Cc: Nishanth Menon, meta-ti, Bajjuri, Praneeth

On Fri, Mar 05, 2021 at 02:38:00PM +0530, Lokesh Vutla wrote:
> Hi Denys,
> 
> On 05/03/21 1:53 pm, Denys Dmytriyenko wrote:
> > On Fri, Mar 05, 2021 at 01:11:05AM -0600, Nishanth Menon wrote:
> >> On 12:34-20210305, Lokesh Vutla wrote:
> >>>
> >>>
> >>> On 05/03/21 6:11 pm, Nishanth Menon via lists.yoctoproject.org wrote:
> >>>> "evm" prefix messes up the pattern matchup for J7200 and falls back into
> >>>> default, as a result, we attempt to pull [1] instead of [2].
> >>>>
> >>>> [1] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_12/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> >>>> [2] https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/07_03_00_10/coresdk_rtos_j7200_07_03_00_12_firmware.tar.xz
> >>>>
> >>>> Fixes: 77cdfa9f6560 ("ti-rtos: Update metadata and versions for RTOS firmware")
> >>>> Signed-off-by: Nishanth Menon <nm@ti.com>
> >>>
> >>> For the sake of completeness can you add default web link for j7200? I still
> >>> couldn't figure out how the weblink is populated when default is undefined.
> >>>
> >>>   DEFAULT_RTOS_WEBLINK_j7200 =
> >>> "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
> >>>
> >>
> >> I believe _j7 does matchup j7200, hence it works and adding _j7200 will
> >> be redundant..
> > 
> > From least specific to most specific for j7200-evm machine:
> > 
> > MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7200-evm"
> 
> Thanks for the explanation. Where does this variable (MACHINEOVERRIDES) get
> populated?

It is being composed from different places. It starts with MACHINE on the 
right. Then SOC_FAMILY list gets built from different .inc files in meta-ti. 
And finally tune features for arch-arm64 prepend it with "aarch64" on the 
left. And it would be "armv5", "armv7a" or "armv7ve" for legacy platforms.

So, roughly MACHINEOVERRIDES=${ARCH}:${SOC_FAMILY}:${MACHINE}


> Thanks and regards,
> Lokesh
> 
> > 
> > For comparison, the same for j7-evm:
> > 
> > MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7-evm"
> > 
> > Or j7-hs-evm:
> > 
> > MACHINEOVERRIDES="aarch64:ti-soc:k3:j7:j7-hs-evm"
> > 
> > All of them are in the same "j7" SOC_FAMILY, as that was supposed to be a 
> > superset for J7 family, even though ended up being rather specific to j721e...
> > 
> > So, when you use _j7 override, that covers j7-evm, j7-hs-evm, j7200-evm an so 
> > on.
> > 
> > 
> >> DEFAULT_RTOS_WEBLINK_j7 = "https://software-dl.ti.com/jacinto7/esd/processor-sdk-rtos-jacinto7/firmware/${CORESDK_RTOS_VERSION}"
> >>
> >> I am a noobie on this, so will be interested in folk's feedback.
> >>
> >> -- 
> >> Regards,
> >> Nishanth Menon
> >> Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
> >>
> > 
> 

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2021-03-05 17:14 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05  6:41 [PATCH dunfell] ti-rtos: Fix J7200 builds by dropping evm Nishanth Menon
2021-03-05  6:45 ` Nishanth Menon
2021-03-05  8:06   ` Denys Dmytriyenko
     [not found]   ` <166963B5CCB828E3.16425@lists.yoctoproject.org>
2021-03-05  8:13     ` [meta-ti] " Denys Dmytriyenko
2021-03-05  7:04 ` [EXTERNAL,dunfell] " Lokesh Vutla
2021-03-05  7:11   ` Nishanth Menon
2021-03-05  7:44     ` Lokesh Vutla
2021-03-05  8:23     ` Denys Dmytriyenko
2021-03-05  9:08       ` Lokesh Vutla
2021-03-05 17:14         ` Denys Dmytriyenko

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.