* [Buildroot] [PATCH 0/2] package/asterisk: fix gcc bug 93847
@ 2021-03-05 9:11 Giulio Benetti
2021-03-05 9:11 ` [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag Giulio Benetti
2021-03-05 9:11 ` [Buildroot] [PATCH 2/2] package/asterisk: fix build failure due to gcc bug 93847 Giulio Benetti
0 siblings, 2 replies; 7+ messages in thread
From: Giulio Benetti @ 2021-03-05 9:11 UTC (permalink / raw)
To: buildroot
First patch needs to allow Buildroot to build with its CFLAGS instead of
Asterisk hardcoded one, while the second applies the gcc bug work-around.
Giulio Benetti (2):
package/asterisk: remove default -O3 optimization flag
package/asterisk: fix build failure due to gcc bug 93847
package/asterisk/asterisk.mk | 11 +++++++++++
1 file changed, 11 insertions(+)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag
2021-03-05 9:11 [Buildroot] [PATCH 0/2] package/asterisk: fix gcc bug 93847 Giulio Benetti
@ 2021-03-05 9:11 ` Giulio Benetti
2021-03-06 15:43 ` Peter Korsgaard
2021-03-16 22:14 ` Peter Korsgaard
2021-03-05 9:11 ` [Buildroot] [PATCH 2/2] package/asterisk: fix build failure due to gcc bug 93847 Giulio Benetti
1 sibling, 2 replies; 7+ messages in thread
From: Giulio Benetti @ 2021-03-05 9:11 UTC (permalink / raw)
To: buildroot
Actually asterisk package gets built with -O3 cflag since it's defaulted
into its sources, but it's not what we want, so let's empty its OPTIMIZE
Makefile variable letting Buildroot CFLAGS to take place instead.
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/asterisk/asterisk.mk | 3 +++
1 file changed, 3 insertions(+)
diff --git a/package/asterisk/asterisk.mk b/package/asterisk/asterisk.mk
index b220b54189..f6a4f8f787 100644
--- a/package/asterisk/asterisk.mk
+++ b/package/asterisk/asterisk.mk
@@ -280,6 +280,9 @@ ifeq ($(BR2_TOOLCHAIN_HAS_LIBATOMIC),y)
ASTERISK_MAKE_OPTS += ASTLDFLAGS="-latomic"
endif
+# Remove default -O3 optimization flag
+ASTERISK_MAKE_OPTS += OPTIMIZE=""
+
# We want to install sample configuration files, too.
ASTERISK_INSTALL_TARGET_OPTS = \
$(ASTERISK_DIRS) \
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag
2021-03-05 9:11 ` [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag Giulio Benetti
@ 2021-03-06 15:43 ` Peter Korsgaard
2021-03-16 22:14 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2021-03-06 15:43 UTC (permalink / raw)
To: buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> Actually asterisk package gets built with -O3 cflag since it's defaulted
> into its sources, but it's not what we want, so let's empty its OPTIMIZE
> Makefile variable letting Buildroot CFLAGS to take place instead.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag
2021-03-05 9:11 ` [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag Giulio Benetti
2021-03-06 15:43 ` Peter Korsgaard
@ 2021-03-16 22:14 ` Peter Korsgaard
1 sibling, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2021-03-16 22:14 UTC (permalink / raw)
To: buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> Actually asterisk package gets built with -O3 cflag since it's defaulted
> into its sources, but it's not what we want, so let's empty its OPTIMIZE
> Makefile variable letting Buildroot CFLAGS to take place instead.
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed to 2020.02.x and 2020.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/asterisk: fix build failure due to gcc bug 93847
2021-03-05 9:11 [Buildroot] [PATCH 0/2] package/asterisk: fix gcc bug 93847 Giulio Benetti
2021-03-05 9:11 ` [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag Giulio Benetti
@ 2021-03-05 9:11 ` Giulio Benetti
2021-03-06 15:43 ` Peter Korsgaard
2021-03-16 22:14 ` Peter Korsgaard
1 sibling, 2 replies; 7+ messages in thread
From: Giulio Benetti @ 2021-03-05 9:11 UTC (permalink / raw)
To: buildroot
The asterisk package exhibits gcc bug 93847 when built for the Nios2
architecture with optimization enabled, which causes a build failure.
As done for other packages in Buildroot work around this gcc bug by
setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_93847=y.
Fixes:
http://autobuild.buildroot.net/results/24c0a6ca3b272711a1e6ceaa033925182d0d49c4
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/asterisk/asterisk.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/asterisk/asterisk.mk b/package/asterisk/asterisk.mk
index f6a4f8f787..67b6da56db 100644
--- a/package/asterisk/asterisk.mk
+++ b/package/asterisk/asterisk.mk
@@ -283,6 +283,14 @@ endif
# Remove default -O3 optimization flag
ASTERISK_MAKE_OPTS += OPTIMIZE=""
+ASTERISK_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_93847),y)
+ASTERISK_CFLAGS += -O0
+endif
+
+ASTERISK_CONF_OPTS += CFLAGS="$(ASTERISK_CFLAGS)"
+
# We want to install sample configuration files, too.
ASTERISK_INSTALL_TARGET_OPTS = \
$(ASTERISK_DIRS) \
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-16 22:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:11 [Buildroot] [PATCH 0/2] package/asterisk: fix gcc bug 93847 Giulio Benetti
2021-03-05 9:11 ` [Buildroot] [PATCH 1/2] package/asterisk: remove default -O3 optimization flag Giulio Benetti
2021-03-06 15:43 ` Peter Korsgaard
2021-03-16 22:14 ` Peter Korsgaard
2021-03-05 9:11 ` [Buildroot] [PATCH 2/2] package/asterisk: fix build failure due to gcc bug 93847 Giulio Benetti
2021-03-06 15:43 ` Peter Korsgaard
2021-03-16 22:14 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.