* [PATCH] scsi: ufs: fix error return code of ufshcd_set_clk_freq()
@ 2021-03-05 10:03 Jia-Ju Bai
0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2021-03-05 10:03 UTC (permalink / raw)
To: alim.akhtar, avri.altman, jejb, martin.petersen, stanley.chu,
cang, beanhuo, jaegeuk, asutoshd
Cc: linux-scsi, linux-kernel, Jia-Ju Bai
When the list of head is empty, no error return code of
ufshcd_set_clk_freq() is assigned.
To fix this bug, ret is assigned with -ENOENT as error return code.
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/scsi/ufs/ufshcd.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 77161750c9fb..79899acb3ef6 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -970,8 +970,10 @@ static int ufshcd_set_clk_freq(struct ufs_hba *hba, bool scale_up)
struct ufs_clk_info *clki;
struct list_head *head = &hba->clk_list_head;
- if (list_empty(head))
+ if (list_empty(head)) {
+ ret = -ENOENT;
goto out;
+ }
list_for_each_entry(clki, head, list) {
if (!IS_ERR_OR_NULL(clki->clk)) {
--
2.17.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-03-05 10:04 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 10:03 [PATCH] scsi: ufs: fix error return code of ufshcd_set_clk_freq() Jia-Ju Bai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.