All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] perf tests: Remove duplicate bitmap test
@ 2021-03-05 15:41 Denis Efremov
  2021-03-05 15:41 ` [PATCH 2/2] perf tests: Remove duplicate cpumap test Denis Efremov
  2021-03-05 20:20 ` [PATCH 1/2] perf tests: Remove duplicate bitmap test Jiri Olsa
  0 siblings, 2 replies; 3+ messages in thread
From: Denis Efremov @ 2021-03-05 15:41 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Denis Efremov, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel

test_bitmap("1,3-6,8-10,24,35-37") called twice in a row.
Remove the second test.

Signed-off-by: Denis Efremov <efremov@linux.com>
---
 tools/perf/tests/bitmap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/tests/bitmap.c b/tools/perf/tests/bitmap.c
index 96c137360918..3320613400eb 100644
--- a/tools/perf/tests/bitmap.c
+++ b/tools/perf/tests/bitmap.c
@@ -47,7 +47,6 @@ int test__bitmap_print(struct test *test __maybe_unused, int subtest __maybe_unu
 	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1,3,5,7,9,11,13,15,17,19,21-40"));
 	TEST_ASSERT_VAL("failed to convert map", test_bitmap("2-5"));
 	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1,3-6,8-10,24,35-37"));
-	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1,3-6,8-10,24,35-37"));
 	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1-10,12-20,22-30,32-40"));
 	return 0;
 }
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] perf tests: Remove duplicate cpumap test
  2021-03-05 15:41 [PATCH 1/2] perf tests: Remove duplicate bitmap test Denis Efremov
@ 2021-03-05 15:41 ` Denis Efremov
  2021-03-05 20:20 ` [PATCH 1/2] perf tests: Remove duplicate bitmap test Jiri Olsa
  1 sibling, 0 replies; 3+ messages in thread
From: Denis Efremov @ 2021-03-05 15:41 UTC (permalink / raw)
  To: Mark Rutland
  Cc: Denis Efremov, Alexander Shishkin, Jiri Olsa, Namhyung Kim, linux-kernel

cpu_map_print("1,3-6,8-10,24,35-37") called twice in a row.
Remove the second test.

Signed-off-by: Denis Efremov <efremov@linux.com>
---
 tools/perf/tests/cpumap.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/tests/cpumap.c b/tools/perf/tests/cpumap.c
index 29c793ac7d10..f906633eae46 100644
--- a/tools/perf/tests/cpumap.c
+++ b/tools/perf/tests/cpumap.c
@@ -116,7 +116,6 @@ int test__cpu_map_print(struct test *test __maybe_unused, int subtest __maybe_un
 	TEST_ASSERT_VAL("failed to convert map", cpu_map_print("1,3,5,7,9,11,13,15,17,19,21-40"));
 	TEST_ASSERT_VAL("failed to convert map", cpu_map_print("2-5"));
 	TEST_ASSERT_VAL("failed to convert map", cpu_map_print("1,3-6,8-10,24,35-37"));
-	TEST_ASSERT_VAL("failed to convert map", cpu_map_print("1,3-6,8-10,24,35-37"));
 	TEST_ASSERT_VAL("failed to convert map", cpu_map_print("1-10,12-20,22-30,32-40"));
 	return 0;
 }
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] perf tests: Remove duplicate bitmap test
  2021-03-05 15:41 [PATCH 1/2] perf tests: Remove duplicate bitmap test Denis Efremov
  2021-03-05 15:41 ` [PATCH 2/2] perf tests: Remove duplicate cpumap test Denis Efremov
@ 2021-03-05 20:20 ` Jiri Olsa
  1 sibling, 0 replies; 3+ messages in thread
From: Jiri Olsa @ 2021-03-05 20:20 UTC (permalink / raw)
  To: Denis Efremov
  Cc: Mark Rutland, Alexander Shishkin, Namhyung Kim, linux-kernel

On Fri, Mar 05, 2021 at 06:41:57PM +0300, Denis Efremov wrote:
> test_bitmap("1,3-6,8-10,24,35-37") called twice in a row.
> Remove the second test.
> 
> Signed-off-by: Denis Efremov <efremov@linux.com>

for both patches

Acked-by: Jiri Olsa <jolsa@redhat.com>

thanks,
jirka


> ---
>  tools/perf/tests/bitmap.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/tests/bitmap.c b/tools/perf/tests/bitmap.c
> index 96c137360918..3320613400eb 100644
> --- a/tools/perf/tests/bitmap.c
> +++ b/tools/perf/tests/bitmap.c
> @@ -47,7 +47,6 @@ int test__bitmap_print(struct test *test __maybe_unused, int subtest __maybe_unu
>  	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1,3,5,7,9,11,13,15,17,19,21-40"));
>  	TEST_ASSERT_VAL("failed to convert map", test_bitmap("2-5"));
>  	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1,3-6,8-10,24,35-37"));
> -	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1,3-6,8-10,24,35-37"));
>  	TEST_ASSERT_VAL("failed to convert map", test_bitmap("1-10,12-20,22-30,32-40"));
>  	return 0;
>  }
> -- 
> 2.26.2
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-05 20:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 15:41 [PATCH 1/2] perf tests: Remove duplicate bitmap test Denis Efremov
2021-03-05 15:41 ` [PATCH 2/2] perf tests: Remove duplicate cpumap test Denis Efremov
2021-03-05 20:20 ` [PATCH 1/2] perf tests: Remove duplicate bitmap test Jiri Olsa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.