* [PATCH] scripts: coccicheck: Fix chain mode in coccicheck
@ 2021-03-05 17:15 ` Davidson Francis
0 siblings, 0 replies; 2+ messages in thread
From: Davidson Francis @ 2021-03-05 17:15 UTC (permalink / raw)
To: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek
Cc: Davidson Francis, cocci, linux-kernel
As described in the Coccinelle documentation (Documentation/dev-tools/
coccinelle.rst), chain mode should try patch, report, context, and org
modes until one of them succeed.
It turns out that currently, the 'run_cmd_parmap' function, by failing
to run $SPATCH, rather than returning an error code, kills the execution
of the script by executing the exit command, rather than returning the
error code.
This way, when running coccicheck in chain mode, as in:
$ make coccicheck MODE=chain
the first .cocci file that does not support one of the virtual rules
stops the execution of the makefile, rather than trying the remaining
rules as specified in the documentation.
Therefore, modify the coccicheck script to return the error code,
rather than terminating the script.
Signed-off-by: Davidson Francis <davidsondfgl@gmail.com>
---
scripts/coccicheck | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 65fee63aeadb..15711bd43395 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -153,7 +153,7 @@ run_cmd_parmap() {
err=$?
if [[ $err -ne 0 ]]; then
echo "coccicheck failed"
- exit $err
+ return $err
fi
}
--
2.29.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Cocci] [PATCH] scripts: coccicheck: Fix chain mode in coccicheck
@ 2021-03-05 17:15 ` Davidson Francis
0 siblings, 0 replies; 2+ messages in thread
From: Davidson Francis @ 2021-03-05 17:15 UTC (permalink / raw)
To: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek
Cc: Davidson Francis, cocci, linux-kernel
As described in the Coccinelle documentation (Documentation/dev-tools/
coccinelle.rst), chain mode should try patch, report, context, and org
modes until one of them succeed.
It turns out that currently, the 'run_cmd_parmap' function, by failing
to run $SPATCH, rather than returning an error code, kills the execution
of the script by executing the exit command, rather than returning the
error code.
This way, when running coccicheck in chain mode, as in:
$ make coccicheck MODE=chain
the first .cocci file that does not support one of the virtual rules
stops the execution of the makefile, rather than trying the remaining
rules as specified in the documentation.
Therefore, modify the coccicheck script to return the error code,
rather than terminating the script.
Signed-off-by: Davidson Francis <davidsondfgl@gmail.com>
---
scripts/coccicheck | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/coccicheck b/scripts/coccicheck
index 65fee63aeadb..15711bd43395 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -153,7 +153,7 @@ run_cmd_parmap() {
err=$?
if [[ $err -ne 0 ]]; then
echo "coccicheck failed"
- exit $err
+ return $err
fi
}
--
2.29.1
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-05 17:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 17:15 [PATCH] scripts: coccicheck: Fix chain mode in coccicheck Davidson Francis
2021-03-05 17:15 ` [Cocci] " Davidson Francis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.