* [PATCH 2/2] iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs
2021-02-25 21:36 [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs Konrad Dybcio
@ 2021-02-25 21:36 ` Konrad Dybcio
2021-03-06 21:21 ` Rob Herring
2021-03-06 21:21 ` [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs Rob Herring
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Konrad Dybcio @ 2021-02-25 21:36 UTC (permalink / raw)
To: phone-devel
Cc: ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, Konrad Dybcio,
Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Some SoCs do have a USB DP/DM ADC at 0x43, 0x44.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
---
include/dt-bindings/iio/qcom,spmi-vadc.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/dt-bindings/iio/qcom,spmi-vadc.h b/include/dt-bindings/iio/qcom,spmi-vadc.h
index 08adfe25964c..c7bb9ef1f9ed 100644
--- a/include/dt-bindings/iio/qcom,spmi-vadc.h
+++ b/include/dt-bindings/iio/qcom,spmi-vadc.h
@@ -72,6 +72,9 @@
#define VADC_AMUX_PU2 0x3b
#define VADC_LR_MUX3_BUF_XO_THERM 0x3c
+#define VADC_USB_DP 0x43
+#define VADC_USB_DM 0x44
+
#define VADC_LR_MUX1_PU1_BAT_THERM 0x70
#define VADC_LR_MUX2_PU1_BAT_ID 0x71
#define VADC_LR_MUX3_PU1_XO_THERM 0x72
--
2.30.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs
2021-02-25 21:36 ` [PATCH 2/2] iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs Konrad Dybcio
@ 2021-03-06 21:21 ` Rob Herring
0 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-03-06 21:21 UTC (permalink / raw)
To: Konrad Dybcio
Cc: devicetree, angelogioacchino.delregno, martin.botka,
linux-kernel, Andy Gross, marijn.suijten,
~postmarketos/upstreaming, linux-arm-msm, phone-devel,
Rob Herring, Bjorn Andersson
On Thu, 25 Feb 2021 22:36:05 +0100, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>
> Some SoCs do have a USB DP/DM ADC at 0x43, 0x44.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> include/dt-bindings/iio/qcom,spmi-vadc.h | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs
2021-02-25 21:36 [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs Konrad Dybcio
2021-02-25 21:36 ` [PATCH 2/2] iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs Konrad Dybcio
@ 2021-03-06 21:21 ` Rob Herring
2021-03-11 0:03 ` Bjorn Andersson
2021-08-03 23:30 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-03-06 21:21 UTC (permalink / raw)
To: Konrad Dybcio
Cc: marijn.suijten, Rob Herring, linux-kernel,
~postmarketos/upstreaming, Bjorn Andersson, linux-arm-msm,
angelogioacchino.delregno, phone-devel, Andy Gross, martin.botka,
devicetree
On Thu, 25 Feb 2021 22:36:04 +0100, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>
> The pinctrl-spmi-mpp driver supports setting more mpp functions
> than the ones defined in the dt-bindings header, specifically,
> digital, analog and sink.
>
> To follow the current way of specifying the function config
> in Device-Tree, add the missing three definitions in the
> appropriate dt-bindings header as:
> GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs
2021-02-25 21:36 [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs Konrad Dybcio
2021-02-25 21:36 ` [PATCH 2/2] iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs Konrad Dybcio
2021-03-06 21:21 ` [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs Rob Herring
@ 2021-03-11 0:03 ` Bjorn Andersson
2021-08-03 23:30 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-03-11 0:03 UTC (permalink / raw)
To: Konrad Dybcio
Cc: phone-devel, ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, Andy Gross,
Rob Herring, linux-arm-msm, devicetree, linux-kernel
On Thu 25 Feb 15:36 CST 2021, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>
> The pinctrl-spmi-mpp driver supports setting more mpp functions
> than the ones defined in the dt-bindings header, specifically,
> digital, analog and sink.
>
> To follow the current way of specifying the function config
> in Device-Tree, add the missing three definitions in the
> appropriate dt-bindings header as:
> GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.
>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
> include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> index 32e66ee7e830..3cdca7ee1b3f 100644
> --- a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> +++ b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> @@ -98,6 +98,9 @@
> /* To be used with "function" */
> #define PMIC_MPP_FUNC_NORMAL "normal"
> #define PMIC_MPP_FUNC_PAIRED "paired"
> +#define PMIC_MPP_FUNC_DIGITAL "digital"
> +#define PMIC_MPP_FUNC_ANALOG "analog"
> +#define PMIC_MPP_FUNC_SINK "sink"
> #define PMIC_MPP_FUNC_DTEST1 "dtest1"
> #define PMIC_MPP_FUNC_DTEST2 "dtest2"
> #define PMIC_MPP_FUNC_DTEST3 "dtest3"
> --
> 2.30.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs
2021-02-25 21:36 [PATCH 1/2] pinctrl: pmic-mpp: Add missing dt-bindings mpp function defs Konrad Dybcio
` (2 preceding siblings ...)
2021-03-11 0:03 ` Bjorn Andersson
@ 2021-08-03 23:30 ` Bjorn Andersson
3 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2021-08-03 23:30 UTC (permalink / raw)
To: Konrad Dybcio
Cc: phone-devel, ~postmarketos/upstreaming, martin.botka,
angelogioacchino.delregno, marijn.suijten, Andy Gross,
Rob Herring, linux-arm-msm, devicetree, linux-kernel
On Thu 25 Feb 15:36 CST 2021, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>
> The pinctrl-spmi-mpp driver supports setting more mpp functions
> than the ones defined in the dt-bindings header, specifically,
> digital, analog and sink.
>
> To follow the current way of specifying the function config
> in Device-Tree, add the missing three definitions in the
> appropriate dt-bindings header as:
> GPIO_MPP_FUNC_{DIGITAL,ANALOG,SINK}.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
I noticed that this has not been picked up yet.
As changes to these files typically goes through the respective
maintainer's tree I think it would be good if you pick up the acks and
resend them.
Also patch 1 and 2 has no real relationship, and per above request would
be picked by two different maintainers, so please post them separately
instead.
PS. I merged the Tone dts using the strings instead of the defines
(which I still prefer over using these defines).
Regards,
Bjorn
> ---
> include/dt-bindings/pinctrl/qcom,pmic-mpp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> index 32e66ee7e830..3cdca7ee1b3f 100644
> --- a/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> +++ b/include/dt-bindings/pinctrl/qcom,pmic-mpp.h
> @@ -98,6 +98,9 @@
> /* To be used with "function" */
> #define PMIC_MPP_FUNC_NORMAL "normal"
> #define PMIC_MPP_FUNC_PAIRED "paired"
> +#define PMIC_MPP_FUNC_DIGITAL "digital"
> +#define PMIC_MPP_FUNC_ANALOG "analog"
> +#define PMIC_MPP_FUNC_SINK "sink"
> #define PMIC_MPP_FUNC_DTEST1 "dtest1"
> #define PMIC_MPP_FUNC_DTEST2 "dtest2"
> #define PMIC_MPP_FUNC_DTEST3 "dtest3"
> --
> 2.30.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread