* [PATCH] security/loadpin: Update the changing interface in the source code.
@ 2021-03-08 2:03 Jiele zhao
2021-03-15 6:22 ` Jiele Zhao
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jiele zhao @ 2021-03-08 2:03 UTC (permalink / raw)
To: keescook, corbet; +Cc: linux-doc, zhaojiele, Jiele zhao
Loadpin cmdline interface "enabled" has been renamed to "enforce"
for a long time, but the User Description Document was not updated.
(Meaning unchanged)
And kernel_read_file* were moved from linux/fs.h to its own
linux/kernel_read_file.h include file. So update that change here.
Signed-off-by: Jiele zhao <unclexiaole@gmail.com>
---
Documentation/admin-guide/LSM/LoadPin.rst | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Documentation/admin-guide/LSM/LoadPin.rst b/Documentation/admin-guide/LSM/LoadPin.rst
index 716ad9b23c9a..dd3ca68b5df1 100644
--- a/Documentation/admin-guide/LSM/LoadPin.rst
+++ b/Documentation/admin-guide/LSM/LoadPin.rst
@@ -11,8 +11,8 @@ restrictions without needing to sign the files individually.
The LSM is selectable at build-time with ``CONFIG_SECURITY_LOADPIN``, and
can be controlled at boot-time with the kernel command line option
-"``loadpin.enabled``". By default, it is enabled, but can be disabled at
-boot ("``loadpin.enabled=0``").
+"``loadpin.enforce``". By default, it is enabled, but can be disabled at
+boot ("``loadpin.enforce=0``").
LoadPin starts pinning when it sees the first file loaded. If the
block device backing the filesystem is not read-only, a sysctl is
@@ -28,4 +28,4 @@ different mechanisms such as ``CONFIG_MODULE_SIG`` and
``CONFIG_KEXEC_VERIFY_SIG`` to verify kernel module and kernel image while
still use LoadPin to protect the integrity of other files kernel loads. The
full list of valid file types can be found in ``kernel_read_file_str``
-defined in ``include/linux/fs.h``.
+defined in ``include/linux/kernel_read_file.h``.
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] security/loadpin: Update the changing interface in the source code.
2021-03-08 2:03 [PATCH] security/loadpin: Update the changing interface in the source code Jiele zhao
@ 2021-03-15 6:22 ` Jiele Zhao
2021-03-15 19:32 ` Jonathan Corbet
2021-03-15 20:44 ` Kees Cook
2 siblings, 0 replies; 4+ messages in thread
From: Jiele Zhao @ 2021-03-15 6:22 UTC (permalink / raw)
To: keescook, corbet; +Cc: linux-doc, linux-kernel
On 2021/3/8 10:03, Jiele zhao wrote:
> Loadpin cmdline interface "enabled" has been renamed to "enforce"
> for a long time, but the User Description Document was not updated.
> (Meaning unchanged)
>
> And kernel_read_file* were moved from linux/fs.h to its own
> linux/kernel_read_file.h include file. So update that change here.
>
> Signed-off-by: Jiele zhao <unclexiaole@gmail.com>
> ---
> Documentation/admin-guide/LSM/LoadPin.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/LSM/LoadPin.rst b/Documentation/admin-guide/LSM/LoadPin.rst
> index 716ad9b23c9a..dd3ca68b5df1 100644
> --- a/Documentation/admin-guide/LSM/LoadPin.rst
> +++ b/Documentation/admin-guide/LSM/LoadPin.rst
> @@ -11,8 +11,8 @@ restrictions without needing to sign the files individually.
>
> The LSM is selectable at build-time with ``CONFIG_SECURITY_LOADPIN``, and
> can be controlled at boot-time with the kernel command line option
> -"``loadpin.enabled``". By default, it is enabled, but can be disabled at
> -boot ("``loadpin.enabled=0``").
> +"``loadpin.enforce``". By default, it is enabled, but can be disabled at
> +boot ("``loadpin.enforce=0``").
>
> LoadPin starts pinning when it sees the first file loaded. If the
> block device backing the filesystem is not read-only, a sysctl is
> @@ -28,4 +28,4 @@ different mechanisms such as ``CONFIG_MODULE_SIG`` and
> ``CONFIG_KEXEC_VERIFY_SIG`` to verify kernel module and kernel image while
> still use LoadPin to protect the integrity of other files kernel loads. The
> full list of valid file types can be found in ``kernel_read_file_str``
> -defined in ``include/linux/fs.h``.
> +defined in ``include/linux/kernel_read_file.h``.
Ping. It's been almost one week now, can someone respond this patch?
Kees? Jonathan?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] security/loadpin: Update the changing interface in the source code.
2021-03-08 2:03 [PATCH] security/loadpin: Update the changing interface in the source code Jiele zhao
2021-03-15 6:22 ` Jiele Zhao
@ 2021-03-15 19:32 ` Jonathan Corbet
2021-03-15 20:44 ` Kees Cook
2 siblings, 0 replies; 4+ messages in thread
From: Jonathan Corbet @ 2021-03-15 19:32 UTC (permalink / raw)
To: Jiele zhao, keescook; +Cc: linux-doc, zhaojiele, Jiele zhao
Jiele zhao <unclexiaole@gmail.com> writes:
> Loadpin cmdline interface "enabled" has been renamed to "enforce"
> for a long time, but the User Description Document was not updated.
> (Meaning unchanged)
>
> And kernel_read_file* were moved from linux/fs.h to its own
> linux/kernel_read_file.h include file. So update that change here.
>
> Signed-off-by: Jiele zhao <unclexiaole@gmail.com>
> ---
> Documentation/admin-guide/LSM/LoadPin.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
This all looks correct as far as I can tell, so I've applied the patch.
Thanks,
jon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] security/loadpin: Update the changing interface in the source code.
2021-03-08 2:03 [PATCH] security/loadpin: Update the changing interface in the source code Jiele zhao
2021-03-15 6:22 ` Jiele Zhao
2021-03-15 19:32 ` Jonathan Corbet
@ 2021-03-15 20:44 ` Kees Cook
2 siblings, 0 replies; 4+ messages in thread
From: Kees Cook @ 2021-03-15 20:44 UTC (permalink / raw)
To: Jiele zhao; +Cc: corbet, linux-doc, zhaojiele
On Mon, Mar 08, 2021 at 02:03:58AM +0000, Jiele zhao wrote:
> Loadpin cmdline interface "enabled" has been renamed to "enforce"
> for a long time, but the User Description Document was not updated.
> (Meaning unchanged)
>
> And kernel_read_file* were moved from linux/fs.h to its own
> linux/kernel_read_file.h include file. So update that change here.
>
> Signed-off-by: Jiele zhao <unclexiaole@gmail.com>
Thanks for the catch!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> Documentation/admin-guide/LSM/LoadPin.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/admin-guide/LSM/LoadPin.rst b/Documentation/admin-guide/LSM/LoadPin.rst
> index 716ad9b23c9a..dd3ca68b5df1 100644
> --- a/Documentation/admin-guide/LSM/LoadPin.rst
> +++ b/Documentation/admin-guide/LSM/LoadPin.rst
> @@ -11,8 +11,8 @@ restrictions without needing to sign the files individually.
>
> The LSM is selectable at build-time with ``CONFIG_SECURITY_LOADPIN``, and
> can be controlled at boot-time with the kernel command line option
> -"``loadpin.enabled``". By default, it is enabled, but can be disabled at
> -boot ("``loadpin.enabled=0``").
> +"``loadpin.enforce``". By default, it is enabled, but can be disabled at
> +boot ("``loadpin.enforce=0``").
>
> LoadPin starts pinning when it sees the first file loaded. If the
> block device backing the filesystem is not read-only, a sysctl is
> @@ -28,4 +28,4 @@ different mechanisms such as ``CONFIG_MODULE_SIG`` and
> ``CONFIG_KEXEC_VERIFY_SIG`` to verify kernel module and kernel image while
> still use LoadPin to protect the integrity of other files kernel loads. The
> full list of valid file types can be found in ``kernel_read_file_str``
> -defined in ``include/linux/fs.h``.
> +defined in ``include/linux/kernel_read_file.h``.
> --
> 2.25.1
>
--
Kees Cook
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-15 20:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 2:03 [PATCH] security/loadpin: Update the changing interface in the source code Jiele zhao
2021-03-15 6:22 ` Jiele Zhao
2021-03-15 19:32 ` Jonathan Corbet
2021-03-15 20:44 ` Kees Cook
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.