From: Pablo Neira Ayuso <pablo@netfilter.org>
To: "Marc Aurèle La France" <tsi@tuyoix.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter REJECT: Fix destination MAC in RST packets
Date: Mon, 8 Mar 2021 11:25:10 +0100 [thread overview]
Message-ID: <20210308102510.GA23497@salvia> (raw)
In-Reply-To: <alpine.LNX.2.20.2103071736460.15162@fanir.tuyoix.net>
On Sun, Mar 07, 2021 at 06:16:34PM -0700, Marc Aurèle La France wrote:
> In the non-bridge case, the REJECT target code assumes the REJECTed
> packets were originally emitted by the local host, but that's not
> necessarily true when the local host is the default route of a subnet
> it is on, resulting in RST packets being sent out with an incorrect
> destination MAC. Address this by refactoring the handling of bridged
> packets which deals with a similar issue. Modulo patch fuzz, the
> following applies to v5 and later kernels.
The code this patch updates is related to BRIDGE_NETFILTER. Your patch
description refers to the non-bridge case. What are you trying to
achieve?
dev_queue_xmit() path should not be exercised from the prerouting
chain, packets generated from the IP later must follow the
ip_local_out() path.
next prev parent reply other threads:[~2021-03-08 10:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 1:16 [PATCH nf] netfilter REJECT: Fix destination MAC in RST packets Marc Aurèle La France
2021-03-08 10:25 ` Pablo Neira Ayuso [this message]
2021-03-08 16:21 ` Marc Aurèle La France
2021-03-09 1:36 ` Pablo Neira Ayuso
2021-03-09 4:25 ` Marc Aurèle La France
2021-03-09 10:27 ` Pablo Neira Ayuso
2021-03-10 23:51 ` Marc Aurèle La France
2021-03-11 0:02 ` Pablo Neira Ayuso
2021-03-11 3:39 ` Marc Aurèle La France
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308102510.GA23497@salvia \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=tsi@tuyoix.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.