All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable
@ 2021-02-10  7:07 Jiapeng Chong
  2021-03-08 13:27 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-02-10  7:07 UTC (permalink / raw)
  To: lee.jones; +Cc: linux-kernel, Jiapeng Chong

Fix the following coccicheck warning:

./include/linux/mfd/db8500-prcmu.h:723:8-9: WARNING: return of 0/1 in
function 'db8500_prcmu_is_ac_wake_requested' with return type bool.

Reported-by: Abaci Robot<abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 include/linux/mfd/db8500-prcmu.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/db8500-prcmu.h b/include/linux/mfd/db8500-prcmu.h
index 4b63d3e..a62de3d 100644
--- a/include/linux/mfd/db8500-prcmu.h
+++ b/include/linux/mfd/db8500-prcmu.h
@@ -720,7 +720,7 @@ static inline int db8500_prcmu_load_a9wdog(u8 id, u32 val)
 
 static inline bool db8500_prcmu_is_ac_wake_requested(void)
 {
-	return 0;
+	return false;
 }
 
 static inline int db8500_prcmu_set_arm_opp(u8 opp)
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable
  2021-02-10  7:07 [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable Jiapeng Chong
@ 2021-03-08 13:27 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2021-03-08 13:27 UTC (permalink / raw)
  To: Jiapeng Chong; +Cc: linux-kernel

On Wed, 10 Feb 2021, Jiapeng Chong wrote:

> Fix the following coccicheck warning:
> 
> ./include/linux/mfd/db8500-prcmu.h:723:8-9: WARNING: return of 0/1 in
> function 'db8500_prcmu_is_ac_wake_requested' with return type bool.
> 
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>

This needs a ' ' before the '<'.

> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  include/linux/mfd/db8500-prcmu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I fixed the above and applied the patch, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-08 13:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10  7:07 [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable Jiapeng Chong
2021-03-08 13:27 ` Lee Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.