* [PATCH -next] mfd: arizona: Make some symbols static
@ 2021-02-10 7:56 Wei Yongjun
2021-02-10 8:52 ` Hans de Goede
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2021-02-10 7:56 UTC (permalink / raw)
To: Hulk Robot, Lee Jones, Hans de Goede; +Cc: Wei Yongjun, patches, linux-kernel
The sparse tool complains as follows:
drivers/mfd/arizona-spi.c:28:31: warning:
symbol 'reset_gpios' was not declared. Should it be static?
drivers/mfd/arizona-spi.c:29:31: warning:
symbol 'ldoena_gpios' was not declared. Should it be static?
Those symbols are not used outside of arizona-spi.c, so this
commit marks them static.
Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/mfd/arizona-spi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
index 24a2c75d691a..aa1d6f94ae53 100644
--- a/drivers/mfd/arizona-spi.c
+++ b/drivers/mfd/arizona-spi.c
@@ -25,8 +25,8 @@
#include "arizona.h"
#ifdef CONFIG_ACPI
-const struct acpi_gpio_params reset_gpios = { 1, 0, false };
-const struct acpi_gpio_params ldoena_gpios = { 2, 0, false };
+static const struct acpi_gpio_params reset_gpios = { 1, 0, false };
+static const struct acpi_gpio_params ldoena_gpios = { 2, 0, false };
static const struct acpi_gpio_mapping arizona_acpi_gpios[] = {
{ "reset-gpios", &reset_gpios, 1, },
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mfd: arizona: Make some symbols static
2021-02-10 7:56 [PATCH -next] mfd: arizona: Make some symbols static Wei Yongjun
@ 2021-02-10 8:52 ` Hans de Goede
2021-02-11 10:06 ` Charles Keepax
2021-03-08 13:52 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Hans de Goede @ 2021-02-10 8:52 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot, Lee Jones; +Cc: patches, linux-kernel
Hi,
On 2/10/21 8:56 AM, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mfd/arizona-spi.c:28:31: warning:
> symbol 'reset_gpios' was not declared. Should it be static?
> drivers/mfd/arizona-spi.c:29:31: warning:
> symbol 'ldoena_gpios' was not declared. Should it be static?
>
> Those symbols are not used outside of arizona-spi.c, so this
> commit marks them static.
>
> Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Thank you for catching this.
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/mfd/arizona-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c
> index 24a2c75d691a..aa1d6f94ae53 100644
> --- a/drivers/mfd/arizona-spi.c
> +++ b/drivers/mfd/arizona-spi.c
> @@ -25,8 +25,8 @@
> #include "arizona.h"
>
> #ifdef CONFIG_ACPI
> -const struct acpi_gpio_params reset_gpios = { 1, 0, false };
> -const struct acpi_gpio_params ldoena_gpios = { 2, 0, false };
> +static const struct acpi_gpio_params reset_gpios = { 1, 0, false };
> +static const struct acpi_gpio_params ldoena_gpios = { 2, 0, false };
>
> static const struct acpi_gpio_mapping arizona_acpi_gpios[] = {
> { "reset-gpios", &reset_gpios, 1, },
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mfd: arizona: Make some symbols static
2021-02-10 7:56 [PATCH -next] mfd: arizona: Make some symbols static Wei Yongjun
2021-02-10 8:52 ` Hans de Goede
@ 2021-02-11 10:06 ` Charles Keepax
2021-03-08 13:52 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Charles Keepax @ 2021-02-11 10:06 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Hulk Robot, Lee Jones, Hans de Goede, patches, linux-kernel
On Wed, Feb 10, 2021 at 07:56:26AM +0000, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mfd/arizona-spi.c:28:31: warning:
> symbol 'reset_gpios' was not declared. Should it be static?
> drivers/mfd/arizona-spi.c:29:31: warning:
> symbol 'ldoena_gpios' was not declared. Should it be static?
>
> Those symbols are not used outside of arizona-spi.c, so this
> commit marks them static.
>
> Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] mfd: arizona: Make some symbols static
2021-02-10 7:56 [PATCH -next] mfd: arizona: Make some symbols static Wei Yongjun
2021-02-10 8:52 ` Hans de Goede
2021-02-11 10:06 ` Charles Keepax
@ 2021-03-08 13:52 ` Lee Jones
2 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2021-03-08 13:52 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Hulk Robot, Hans de Goede, patches, linux-kernel
On Wed, 10 Feb 2021, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/mfd/arizona-spi.c:28:31: warning:
> symbol 'reset_gpios' was not declared. Should it be static?
> drivers/mfd/arizona-spi.c:29:31: warning:
> symbol 'ldoena_gpios' was not declared. Should it be static?
>
> Those symbols are not used outside of arizona-spi.c, so this
> commit marks them static.
>
> Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/mfd/arizona-spi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-08 13:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-10 7:56 [PATCH -next] mfd: arizona: Make some symbols static Wei Yongjun
2021-02-10 8:52 ` Hans de Goede
2021-02-11 10:06 ` Charles Keepax
2021-03-08 13:52 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.