All of lore.kernel.org
 help / color / mirror / Atom feed
From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"linux.cj" <linux.cj@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio
Date: Mon, 8 Mar 2021 19:41:00 +0530	[thread overview]
Message-ID: <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> (raw)
In-Reply-To: <CAHp75VdpvTN2R-FTb81GnwvAr_eoprEhsOMx+akukaDNBrptsQ@mail.gmail.com>

On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
> <calvin.johnson@oss.nxp.com> wrote:
> >
> > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
> > each ACPI child node.
> 
> > +#include <linux/acpi.h>
> > +#include <linux/acpi_mdio.h>
> 
> Perhaps it's better to provide the headers that this file is direct
> user of, i.e.
>  bits.h
>  dev_printk.h

Looks like device.h needs to be used instead of dev_printk.h. Please
let me know if you've a different opinion.

>  module.h
>  types.h
> 
> The rest seems fine because they are guaranteed to be included by
> acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs).
> 

Thanks
Calvin

WARNING: multiple messages have this Message-ID (diff)
From: Calvin Johnson <calvin.johnson@oss.nxp.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Grant Likely <grant.likely@arm.com>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Jeremy Linton <jeremy.linton@arm.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Russell King - ARM Linux admin <linux@armlinux.org.uk>,
	Cristi Sovaiala <cristian.sovaiala@nxp.com>,
	Florin Laurentiu Chiculita <florinlaurentiu.chiculita@nxp.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	Madalin Bucur <madalin.bucur@oss.nxp.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Marcin Wojtas <mw@semihalf.com>,
	Pieter Jansen Van Vuuren <pieter.jansenvv@bamboosystems.io>,
	Jon <jon@solid-run.com>, Saravana Kannan <saravanak@google.com>,
	Randy Dunlap <rdunlap@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	Diana Madalina Craciun <diana.craciun@nxp.com>,
	linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
	"linux.cj" <linux.cj@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio
Date: Mon, 8 Mar 2021 19:41:00 +0530	[thread overview]
Message-ID: <20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com> (raw)
In-Reply-To: <CAHp75VdpvTN2R-FTb81GnwvAr_eoprEhsOMx+akukaDNBrptsQ@mail.gmail.com>

On Thu, Feb 18, 2021 at 05:08:05PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 18, 2021 at 7:28 AM Calvin Johnson
> <calvin.johnson@oss.nxp.com> wrote:
> >
> > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for
> > each ACPI child node.
> 
> > +#include <linux/acpi.h>
> > +#include <linux/acpi_mdio.h>
> 
> Perhaps it's better to provide the headers that this file is direct
> user of, i.e.
>  bits.h
>  dev_printk.h

Looks like device.h needs to be used instead of dev_printk.h. Please
let me know if you've a different opinion.

>  module.h
>  types.h
> 
> The rest seems fine because they are guaranteed to be included by
> acpi.h (IIUC about fwnode API and acpi_mdio includes MDIO PHY APIs).
> 

Thanks
Calvin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-08 14:12 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  5:26 [net-next PATCH v6 00/15] ACPI support for dpaa2 driver Calvin Johnson
2021-02-18  5:26 ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 01/15] Documentation: ACPI: DSD: Document MDIO PHY Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 02/15] net: phy: Introduce fwnode_mdio_find_device() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18 19:05   ` Jakub Kicinski
2021-02-18 19:05     ` Jakub Kicinski
2021-02-18  5:26 ` [net-next PATCH v6 03/15] net: phy: Introduce phy related fwnode functions Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 04/15] of: mdio: Refactor of_phy_find_device() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 05/15] net: phy: Introduce fwnode_get_phy_id() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 06/15] of: mdio: Refactor of_get_phy_id() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 07/15] net: mdiobus: Introduce fwnode_mdiobus_register_phy() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18 10:01   ` kernel test robot
2021-02-18 14:52   ` Andy Shevchenko
2021-02-18 14:52     ` Andy Shevchenko
2021-02-18  5:26 ` [net-next PATCH v6 08/15] of: mdio: Refactor of_mdiobus_register_phy() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 09/15] ACPI: utils: Introduce acpi_get_local_address() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 10/15] net: mdio: Add ACPI support code for mdio Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18 15:08   ` Andy Shevchenko
2021-02-18 15:08     ` Andy Shevchenko
2021-03-08 14:11     ` Calvin Johnson [this message]
2021-03-08 14:11       ` Calvin Johnson
2021-03-08 14:57       ` Andy Shevchenko
2021-03-08 14:57         ` Andy Shevchenko
2021-03-08 16:28         ` Calvin Johnson
2021-03-08 16:28           ` Calvin Johnson
2021-03-08 16:39           ` Andy Shevchenko
2021-03-08 16:39             ` Andy Shevchenko
2021-02-18  5:26 ` [net-next PATCH v6 11/15] net: mdiobus: Introduce fwnode_mdiobus_register() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 12/15] net/fsl: Use fwnode_mdiobus_register() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 13/15] net: phylink: introduce phylink_fwnode_phy_connect() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 14/15] net: phylink: Refactor phylink_of_phy_connect() Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18  5:26 ` [net-next PATCH v6 15/15] net: dpaa2-mac: Add ACPI support for DPAA2 MAC driver Calvin Johnson
2021-02-18  5:26   ` Calvin Johnson
2021-02-18 15:04   ` Andy Shevchenko
2021-02-18 15:04     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210308140936.GA2740@lsv03152.swis.in-blr01.nxp.com \
    --to=calvin.johnson@oss.nxp.com \
    --cc=andrew@lunn.ch \
    --cc=andy.shevchenko@gmail.com \
    --cc=cristian.sovaiala@nxp.com \
    --cc=davem@davemloft.net \
    --cc=diana.craciun@nxp.com \
    --cc=f.fainelli@gmail.com \
    --cc=florinlaurentiu.chiculita@nxp.com \
    --cc=grant.likely@arm.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=hkallweit1@gmail.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=jeremy.linton@arm.com \
    --cc=jon@solid-run.com \
    --cc=kuba@kernel.org \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.cj@gmail.com \
    --cc=linux@armlinux.org.uk \
    --cc=madalin.bucur@oss.nxp.com \
    --cc=mw@semihalf.com \
    --cc=netdev@vger.kernel.org \
    --cc=pieter.jansenvv@bamboosystems.io \
    --cc=rafael@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.