[sashal-linux-stable:queue-4.19 12/18] drivers/nvme/host/core.c:2840:30: sparse: sparse: symbol 'nvme_ns_id_attr_group' was not declared. Should it be

[sashal-linux-stable:queue-4.19 12/18] drivers/nvme/host/core.c:2840:30: sparse: sparse: symbol 'nvme_ns_id_attr_group' was not declared. Should it be

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.19
head:   2fa1d7f2ce3cf358f01aed3043d2c325aa9167e7
commit: eb5aef6d9f1c964f93295c9c28a698805f7c440b [12/18] nvme: register ns_id attributes as default sysfs groups
config: x86_64-randconfig-s021-20210307 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.3-245-gacc5c298-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git/commit/?id=eb5aef6d9f1c964f93295c9c28a698805f7c440b
        git remote add sashal-linux-stable https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git
        git fetch --no-tags sashal-linux-stable queue-4.19
        git checkout eb5aef6d9f1c964f93295c9c28a698805f7c440b
        # save the attached .config to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


"sparse warnings: (new ones prefixed by >>)"
>> drivers/nvme/host/core.c:2840:30: sparse: sparse: symbol 'nvme_ns_id_attr_group' was not declared. Should it be static?
   drivers/nvme/host/core.c:1317:23: sparse: sparse: context imbalance in 'nvme_get_ns_from_disk' - wrong count at exit
   drivers/nvme/host/core.c:1340:33: sparse: sparse: context imbalance in 'nvme_put_ns_from_disk' - unexpected unlock

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32624 bytes --]

[RFC PATCH sashal-linux-stable] nvme: nvme_ns_id_attr_group can be static

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]


Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index 513dd1e2aac76..fae8efc5126c2 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2837,7 +2837,7 @@ static umode_t nvme_ns_id_attrs_are_visible(struct kobject *kobj,
 	return a->mode;
 }
 
-const struct attribute_group nvme_ns_id_attr_group = {
+static const struct attribute_group nvme_ns_id_attr_group = {
 	.attrs		= nvme_ns_id_attrs,
 	.is_visible	= nvme_ns_id_attrs_are_visible,
 };