* [PATCH] resolvconf: add missing dependencies to RDEPENDS
@ 2021-03-08 19:30 Khem Raj
2021-03-08 22:11 ` [OE-core] " Andre McCurdy
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2021-03-08 19:30 UTC (permalink / raw)
To: openembedded-core; +Cc: Frans Meulenbroeks, Khem Raj
From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
resolvconf uses flock and readlink.
So explicitly added dependencies on util-linux (for flock) and coreutils
(for readlink).
Note that the options used with flock and readlink are not part of the
busybox implementations so full-fledged implementations are needed.
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
index 6df96b699c..6da8cd6023 100644
--- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
+++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
@@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
AUTHOR = "Thomas Hood"
HOMEPAGE = "http://packages.debian.org/resolvconf"
-RDEPENDS_${PN} = "bash"
+RDEPENDS_${PN} = "bash coreutils util-linux"
SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
file://fix-path-for-busybox.patch \
--
2.30.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] resolvconf: add missing dependencies to RDEPENDS
2021-03-08 19:30 [PATCH] resolvconf: add missing dependencies to RDEPENDS Khem Raj
@ 2021-03-08 22:11 ` Andre McCurdy
2021-03-08 22:15 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Andre McCurdy @ 2021-03-08 22:11 UTC (permalink / raw)
To: Khem Raj; +Cc: OE Core mailing list, Frans Meulenbroeks
On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
>
> resolvconf uses flock and readlink.
> So explicitly added dependencies on util-linux (for flock) and coreutils
> (for readlink).
> Note that the options used with flock and readlink are not part of the
> busybox implementations so full-fledged implementations are needed.
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> index 6df96b699c..6da8cd6023 100644
> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
> AUTHOR = "Thomas Hood"
> HOMEPAGE = "http://packages.debian.org/resolvconf"
> -RDEPENDS_${PN} = "bash"
> +RDEPENDS_${PN} = "bash coreutils util-linux"
util-linux-flock has its own package.
Patching resolvconf to use readlink -f (instead of readlink -m) should
be sufficient to allow it to work with busybox readlink.
> SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
> file://fix-path-for-busybox.patch \
> --
> 2.30.1
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] resolvconf: add missing dependencies to RDEPENDS
2021-03-08 22:11 ` [OE-core] " Andre McCurdy
@ 2021-03-08 22:15 ` Khem Raj
2021-03-08 22:25 ` Andre McCurdy
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2021-03-08 22:15 UTC (permalink / raw)
To: Andre McCurdy; +Cc: OE Core mailing list, Frans Meulenbroeks
On 3/8/21 2:11 PM, Andre McCurdy wrote:
> On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
>>
>> resolvconf uses flock and readlink.
>> So explicitly added dependencies on util-linux (for flock) and coreutils
>> (for readlink).
>> Note that the options used with flock and readlink are not part of the
>> busybox implementations so full-fledged implementations are needed.
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>> index 6df96b699c..6da8cd6023 100644
>> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
>> LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
>> AUTHOR = "Thomas Hood"
>> HOMEPAGE = "http://packages.debian.org/resolvconf"
>> -RDEPENDS_${PN} = "bash"
>> +RDEPENDS_${PN} = "bash coreutils util-linux"
>
> util-linux-flock has its own package.
yeah and busybox also provides flock too. Lets drop it
>
> Patching resolvconf to use readlink -f (instead of readlink -m) should
> be sufficient to allow it to work with busybox readlink.
>
>> SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
>> file://fix-path-for-busybox.patch \
>> --
>> 2.30.1
>>
>>
>>
>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] resolvconf: add missing dependencies to RDEPENDS
2021-03-08 22:15 ` Khem Raj
@ 2021-03-08 22:25 ` Andre McCurdy
2021-03-08 23:26 ` Khem Raj
0 siblings, 1 reply; 7+ messages in thread
From: Andre McCurdy @ 2021-03-08 22:25 UTC (permalink / raw)
To: Khem Raj; +Cc: OE Core mailing list, Frans Meulenbroeks
On Mon, Mar 8, 2021 at 2:15 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On 3/8/21 2:11 PM, Andre McCurdy wrote:
> > On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
> >>
> >> resolvconf uses flock and readlink.
> >> So explicitly added dependencies on util-linux (for flock) and coreutils
> >> (for readlink).
> >> Note that the options used with flock and readlink are not part of the
> >> busybox implementations so full-fledged implementations are needed.
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> >> index 6df96b699c..6da8cd6023 100644
> >> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> >> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> >> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
> >> LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
> >> AUTHOR = "Thomas Hood"
> >> HOMEPAGE = "http://packages.debian.org/resolvconf"
> >> -RDEPENDS_${PN} = "bash"
> >> +RDEPENDS_${PN} = "bash coreutils util-linux"
> >
> > util-linux-flock has its own package.
>
> yeah and busybox also provides flock too. Lets drop it
Busybox provides flock, but it doesn't support the -w option (wait
with timeout). Either the util-linux flock is required or resolvconf
needs to be patched to drop the -w option.
> > Patching resolvconf to use readlink -f (instead of readlink -m) should
> > be sufficient to allow it to work with busybox readlink.
> >
> >> SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
> >> file://fix-path-for-busybox.patch \
> >> --
> >> 2.30.1
> >>
> >>
> >>
> >>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] resolvconf: add missing dependencies to RDEPENDS
2021-03-08 22:25 ` Andre McCurdy
@ 2021-03-08 23:26 ` Khem Raj
2021-03-09 15:23 ` Frans Meulenbroeks
0 siblings, 1 reply; 7+ messages in thread
From: Khem Raj @ 2021-03-08 23:26 UTC (permalink / raw)
To: Andre McCurdy; +Cc: OE Core mailing list, Frans Meulenbroeks
On 3/8/21 2:25 PM, Andre McCurdy wrote:
> On Mon, Mar 8, 2021 at 2:15 PM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On 3/8/21 2:11 PM, Andre McCurdy wrote:
>>> On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.khem@gmail.com> wrote:
>>>>
>>>> From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
>>>>
>>>> resolvconf uses flock and readlink.
>>>> So explicitly added dependencies on util-linux (for flock) and coreutils
>>>> (for readlink).
>>>> Note that the options used with flock and readlink are not part of the
>>>> busybox implementations so full-fledged implementations are needed.
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>>>> index 6df96b699c..6da8cd6023 100644
>>>> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>>>> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>>>> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
>>>> LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
>>>> AUTHOR = "Thomas Hood"
>>>> HOMEPAGE = "http://packages.debian.org/resolvconf"
>>>> -RDEPENDS_${PN} = "bash"
>>>> +RDEPENDS_${PN} = "bash coreutils util-linux"
>>>
>>> util-linux-flock has its own package.
>>
>> yeah and busybox also provides flock too. Lets drop it
>
> Busybox provides flock, but it doesn't support the -w option (wait
> with timeout). Either the util-linux flock is required or resolvconf
> needs to be patched to drop the -w option.
>
right, its to explore possibilities to avoid the deps.
>>> Patching resolvconf to use readlink -f (instead of readlink -m) should
>>> be sufficient to allow it to work with busybox readlink.
>>>
>>>> SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
>>>> file://fix-path-for-busybox.patch \
>>>> --
>>>> 2.30.1
>>>>
>>>>
>>>>
>>>>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] resolvconf: add missing dependencies to RDEPENDS
2021-03-08 23:26 ` Khem Raj
@ 2021-03-09 15:23 ` Frans Meulenbroeks
2021-03-09 23:33 ` Andre McCurdy
0 siblings, 1 reply; 7+ messages in thread
From: Frans Meulenbroeks @ 2021-03-09 15:23 UTC (permalink / raw)
To: Andre McCurdy, Khem Raj; +Cc: OE Core mailing list
[-- Attachment #1: Type: text/plain, Size: 2764 bytes --]
Freaking yahoo email seems to have no option any more to quote decently.Guess it is time for a new email provider :-)Anyway my response below prefixed with FM:
Op dinsdag 9 maart 2021 00:26:05 CET schreef Khem Raj <raj.khem@gmail.com>:
On 3/8/21 2:25 PM, Andre McCurdy wrote:
> On Mon, Mar 8, 2021 at 2:15 PM Khem Raj <raj.khem@gmail.com> wrote:
>>
>> On 3/8/21 2:11 PM, Andre McCurdy wrote:
>>> On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.khem@gmail.com> wrote:
>>>>
>>>> From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
>>>>
>>>> resolvconf uses flock and readlink.
>>>> So explicitly added dependencies on util-linux (for flock) and coreutils
>>>> (for readlink).
>>>> Note that the options used with flock and readlink are not part of the
>>>> busybox implementations so full-fledged implementations are needed.
>>>>
>>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>>>> ---
>>>> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>>>> index 6df96b699c..6da8cd6023 100644
>>>> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>>>> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
>>>> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
>>>> LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
>>>> AUTHOR = "Thomas Hood"
>>>> HOMEPAGE = "http://packages.debian.org/resolvconf"
>>>> -RDEPENDS_${PN} = "bash"
>>>> +RDEPENDS_${PN} = "bash coreutils util-linux"
>>>
>>> util-linux-flock has its own package.
>>
>> yeah and busybox also provides flock too. Lets drop it
>
> Busybox provides flock, but it doesn't support the -w option (wait
> with timeout). Either the util-linux flock is required or resolvconf
> needs to be patched to drop the -w option.
>
right, its to explore possibilities to avoid the deps.
FM: While I am all in favor of avoiding these dependencies, I'm not versed enough in the resolvconf code to judge the impact of dropping -w, so my preference would be to depend on util-linux-flock.
>>> Patching resolvconf to use readlink -f (instead of readlink -m) should
>>> be sufficient to allow it to work with busybox readlink.
FM: this will most likely work. I can make a patch for that, no problem.
>>>
>>>> SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
>>>> file://fix-path-for-busybox.patch \
>>>> --
>>>> 2.30.1
On a general note: in the current form the package is broken, so some fix is desirable.
Kind regards, Frans.
[-- Attachment #2: Type: text/html, Size: 5529 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] resolvconf: add missing dependencies to RDEPENDS
2021-03-09 15:23 ` Frans Meulenbroeks
@ 2021-03-09 23:33 ` Andre McCurdy
0 siblings, 0 replies; 7+ messages in thread
From: Andre McCurdy @ 2021-03-09 23:33 UTC (permalink / raw)
To: Frans Meulenbroeks; +Cc: Khem Raj, OE Core mailing list
On Tue, Mar 9, 2021 at 7:23 AM Frans Meulenbroeks
<fransmeulenbroeks@yahoo.com> wrote:
>
> Freaking yahoo email seems to have no option any more to quote decently.
> Guess it is time for a new email provider :-)
> Anyway my response below prefixed with FM:
>
> Op dinsdag 9 maart 2021 00:26:05 CET schreef Khem Raj <raj.khem@gmail.com>:
> On 3/8/21 2:25 PM, Andre McCurdy wrote:
> > On Mon, Mar 8, 2021 at 2:15 PM Khem Raj <raj.khem@gmail.com> wrote:
> >>
> >> On 3/8/21 2:11 PM, Andre McCurdy wrote:
> >>> On Mon, Mar 8, 2021 at 11:30 AM Khem Raj <raj.khem@gmail.com> wrote:
> >>>>
> >>>> From: Frans Meulenbroeks <fransmeulenbroeks@yahoo.com>
> >>>>
> >>>> resolvconf uses flock and readlink.
> >>>> So explicitly added dependencies on util-linux (for flock) and coreutils
> >>>> (for readlink).
> >>>> Note that the options used with flock and readlink are not part of the
> >>>> busybox implementations so full-fledged implementations are needed.
> >>>>
> >>>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >>>> ---
> >>>> meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb | 2 +-
> >>>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> >>>> index 6df96b699c..6da8cd6023 100644
> >>>> --- a/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> >>>> +++ b/meta/recipes-connectivity/resolvconf/resolvconf_1.87.bb
> >>>> @@ -9,7 +9,7 @@ LICENSE = "GPLv2+"
> >>>> LIC_FILES_CHKSUM = "file://COPYING;md5=c93c0550bd3173f4504b2cbd8991e50b"
> >>>> AUTHOR = "Thomas Hood"
> >>>> HOMEPAGE = "http://packages.debian.org/resolvconf"
> >>>> -RDEPENDS_${PN} = "bash"
> >>>> +RDEPENDS_${PN} = "bash coreutils util-linux"
> >>>
> >>> util-linux-flock has its own package.
> >>
> >> yeah and busybox also provides flock too. Lets drop it
> >
> > Busybox provides flock, but it doesn't support the -w option (wait
> > with timeout). Either the util-linux flock is required or resolvconf
> > needs to be patched to drop the -w option.
>
> right, its to explore possibilities to avoid the deps.
>
> FM: While I am all in favor of avoiding these dependencies, I'm not versed enough in the resolvconf code to judge the impact of dropping -w, so my preference would be to depend on util-linux-flock.
Agreed. Adding a runtime dependency on util-linux-flock is the safest fix.
> >>> Patching resolvconf to use readlink -f (instead of readlink -m) should
> >>> be sufficient to allow it to work with busybox readlink.
>
> FM: this will most likely work. I can make a patch for that, no problem.
For reference, there's a patch which does that here:
https://github.com/lgirdk/meta-mng/blob/ofw/recipes-misc/resolvconf/resolvconf/0001-try-to-support-busybox-readlink.patch
> >>>> SRC_URI = "git://salsa.debian.org/debian/resolvconf.git;protocol=https;branch=unstable \
> >>>> file://fix-path-for-busybox.patch \
> >>>> --
> >>>> 2.30.1
>
> On a general note: in the current form the package is broken, so some fix is desirable.
Agreed.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-03-09 23:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-08 19:30 [PATCH] resolvconf: add missing dependencies to RDEPENDS Khem Raj
2021-03-08 22:11 ` [OE-core] " Andre McCurdy
2021-03-08 22:15 ` Khem Raj
2021-03-08 22:25 ` Andre McCurdy
2021-03-08 23:26 ` Khem Raj
2021-03-09 15:23 ` Frans Meulenbroeks
2021-03-09 23:33 ` Andre McCurdy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.