* [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" @ 2021-01-15 1:50 meng.li 2021-02-22 3:45 ` Li, Meng 0 siblings, 1 reply; 10+ messages in thread From: meng.li @ 2021-01-15 1:50 UTC (permalink / raw) To: linux-kernel; +Cc: maz, lee.jones, arnd, Kexin.Hao, meng.li From: Limeng <Meng.Li@windriver.com> This reverts commit 529a1101212a785c5df92c314b0e718287150c3b. The reverted patch moves the memory free to error path, but introduce a memory leak. There is another commit 94cc89eb8fa5("regmap: debugfs: Fix handling of name string for debugfs init delays") fixing this debugfs init issue from root cause. With this fixing, the name field in struct regmap_debugfs_node is removed. When initialize debugfs for syscon driver, the name field of struct regmap_config is not used anymore. So, revert this patch directly to avoid memory leak. v2: Notify the author of the reverted commit by adding Cc: Fixes: 529a1101212a("mfd: syscon: Don't free allocated name for regmap_config") Cc: Marc Zyngier <maz@kernel.org> Cc: stable@vger.kernel.org Signed-off-by: Meng Li <Meng.Li@windriver.com> --- drivers/mfd/syscon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index ca465794ea9c..df5cebb372a5 100644 --- a/drivers/mfd/syscon.c +++ b/drivers/mfd/syscon.c @@ -108,6 +108,7 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk) syscon_config.max_register = resource_size(&res) - reg_io_width; regmap = regmap_init_mmio(NULL, base, &syscon_config); + kfree(syscon_config.name); if (IS_ERR(regmap)) { pr_err("regmap init failed\n"); ret = PTR_ERR(regmap); @@ -144,7 +145,6 @@ static struct syscon *of_syscon_register(struct device_node *np, bool check_clk) regmap_exit(regmap); err_regmap: iounmap(base); - kfree(syscon_config.name); err_map: kfree(syscon); return ERR_PTR(ret); -- 2.17.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-01-15 1:50 [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" meng.li @ 2021-02-22 3:45 ` Li, Meng 2021-02-22 9:12 ` Marc Zyngier 0 siblings, 1 reply; 10+ messages in thread From: Li, Meng @ 2021-02-22 3:45 UTC (permalink / raw) To: linux-kernel; +Cc: maz, lee.jones, arnd, Hao, Kexin Hi Marc&Lee, Is there any comment on this patch? Could you please help to review this patch so that I can improve it if it still has weakness? Thanks, Limeng > -----Original Message----- > From: Li, Meng <Meng.Li@windriver.com> > Sent: Friday, January 15, 2021 9:51 AM > To: linux-kernel@vger.kernel.org > Cc: maz@kernel.org; lee.jones@linaro.org; arnd@arndb.de; Hao, Kexin > <Kexin.Hao@windriver.com>; Li, Meng <Meng.Li@windriver.com> > Subject: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > regmap_config" > > From: Limeng <Meng.Li@windriver.com> > > This reverts commit 529a1101212a785c5df92c314b0e718287150c3b. > > The reverted patch moves the memory free to error path, but introduce a > memory leak. There is another commit 94cc89eb8fa5("regmap: debugfs: > Fix handling of name string for debugfs init delays") fixing this debugfs init > issue from root cause. With this fixing, the name field in struct > regmap_debugfs_node is removed. When initialize debugfs for syscon driver, > the name field of struct regmap_config is not used anymore. So, revert this > patch directly to avoid memory leak. > > v2: > Notify the author of the reverted commit by adding Cc: > > Fixes: 529a1101212a("mfd: syscon: Don't free allocated name for > regmap_config") > Cc: Marc Zyngier <maz@kernel.org> > Cc: stable@vger.kernel.org > Signed-off-by: Meng Li <Meng.Li@windriver.com> > --- > drivers/mfd/syscon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index > ca465794ea9c..df5cebb372a5 100644 > --- a/drivers/mfd/syscon.c > +++ b/drivers/mfd/syscon.c > @@ -108,6 +108,7 @@ static struct syscon *of_syscon_register(struct > device_node *np, bool check_clk) > syscon_config.max_register = resource_size(&res) - reg_io_width; > > regmap = regmap_init_mmio(NULL, base, &syscon_config); > + kfree(syscon_config.name); > if (IS_ERR(regmap)) { > pr_err("regmap init failed\n"); > ret = PTR_ERR(regmap); > @@ -144,7 +145,6 @@ static struct syscon *of_syscon_register(struct > device_node *np, bool check_clk) > regmap_exit(regmap); > err_regmap: > iounmap(base); > - kfree(syscon_config.name); > err_map: > kfree(syscon); > return ERR_PTR(ret); > -- > 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-02-22 3:45 ` Li, Meng @ 2021-02-22 9:12 ` Marc Zyngier 2021-02-22 9:21 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Marc Zyngier @ 2021-02-22 9:12 UTC (permalink / raw) To: Li, Meng; +Cc: linux-kernel, lee.jones, arnd, Hao, Kexin Hi Limeng, On 2021-02-22 03:45, Li, Meng wrote: > Hi Marc&Lee, > > Is there any comment on this patch? > Could you please help to review this patch so that I can improve it if > it still has weakness? If you are confident that the root issue has been fixed, no objection from me, but I'm not in a position to test it at the moment (the board I found the problem on is in a bit of a state). Thanks, M. > > Thanks, > Limeng > >> -----Original Message----- >> From: Li, Meng <Meng.Li@windriver.com> >> Sent: Friday, January 15, 2021 9:51 AM >> To: linux-kernel@vger.kernel.org >> Cc: maz@kernel.org; lee.jones@linaro.org; arnd@arndb.de; Hao, Kexin >> <Kexin.Hao@windriver.com>; Li, Meng <Meng.Li@windriver.com> >> Subject: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name >> for >> regmap_config" >> >> From: Limeng <Meng.Li@windriver.com> >> >> This reverts commit 529a1101212a785c5df92c314b0e718287150c3b. >> >> The reverted patch moves the memory free to error path, but introduce >> a >> memory leak. There is another commit 94cc89eb8fa5("regmap: debugfs: >> Fix handling of name string for debugfs init delays") fixing this >> debugfs init >> issue from root cause. With this fixing, the name field in struct >> regmap_debugfs_node is removed. When initialize debugfs for syscon >> driver, >> the name field of struct regmap_config is not used anymore. So, revert >> this >> patch directly to avoid memory leak. >> >> v2: >> Notify the author of the reverted commit by adding Cc: >> >> Fixes: 529a1101212a("mfd: syscon: Don't free allocated name for >> regmap_config") >> Cc: Marc Zyngier <maz@kernel.org> >> Cc: stable@vger.kernel.org >> Signed-off-by: Meng Li <Meng.Li@windriver.com> >> --- >> drivers/mfd/syscon.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c index >> ca465794ea9c..df5cebb372a5 100644 >> --- a/drivers/mfd/syscon.c >> +++ b/drivers/mfd/syscon.c >> @@ -108,6 +108,7 @@ static struct syscon *of_syscon_register(struct >> device_node *np, bool check_clk) >> syscon_config.max_register = resource_size(&res) - reg_io_width; >> >> regmap = regmap_init_mmio(NULL, base, &syscon_config); >> + kfree(syscon_config.name); >> if (IS_ERR(regmap)) { >> pr_err("regmap init failed\n"); >> ret = PTR_ERR(regmap); >> @@ -144,7 +145,6 @@ static struct syscon *of_syscon_register(struct >> device_node *np, bool check_clk) >> regmap_exit(regmap); >> err_regmap: >> iounmap(base); >> - kfree(syscon_config.name); >> err_map: >> kfree(syscon); >> return ERR_PTR(ret); >> -- >> 2.17.1 -- Jazz is not dead. It just smells funny... ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-02-22 9:12 ` Marc Zyngier @ 2021-02-22 9:21 ` Lee Jones 2021-02-22 9:37 ` Li, Meng 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2021-02-22 9:21 UTC (permalink / raw) To: Marc Zyngier; +Cc: Li, Meng, linux-kernel, arnd, Hao, Kexin On Mon, 22 Feb 2021, Marc Zyngier wrote: > Hi Limeng, > > On 2021-02-22 03:45, Li, Meng wrote: > > Hi Marc&Lee, > > > > Is there any comment on this patch? > > Could you please help to review this patch so that I can improve it if > > it still has weakness? > > If you are confident that the root issue has been fixed, no objection > from me, but I'm not in a position to test it at the moment (the board > I found the problem on is in a bit of a state). I'm not keen on flip-flopping this patch in and out of the kernel. Someone really needs to spend some time to map out the full life-cycle and propose a (possibly cross-subsystem) solution. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-02-22 9:21 ` Lee Jones @ 2021-02-22 9:37 ` Li, Meng 2021-03-09 9:43 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Li, Meng @ 2021-02-22 9:37 UTC (permalink / raw) To: Lee Jones, Marc Zyngier; +Cc: linux-kernel, arnd, Hao, Kexin Thanks for all of your comments. Regards, Limeng > -----Original Message----- > From: Lee Jones <lee.jones@linaro.org> > Sent: Monday, February 22, 2021 5:21 PM > To: Marc Zyngier <maz@kernel.org> > Cc: Li, Meng <Meng.Li@windriver.com>; linux-kernel@vger.kernel.org; > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > regmap_config" > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Mon, 22 Feb 2021, Marc Zyngier wrote: > > > Hi Limeng, > > > > On 2021-02-22 03:45, Li, Meng wrote: > > > Hi Marc&Lee, > > > > > > Is there any comment on this patch? > > > Could you please help to review this patch so that I can improve it > > > if it still has weakness? > > > > If you are confident that the root issue has been fixed, no objection > > from me, but I'm not in a position to test it at the moment (the board > > I found the problem on is in a bit of a state). > > I'm not keen on flip-flopping this patch in and out of the kernel. > Someone really needs to spend some time to map out the full life-cycle and > propose a (possibly cross-subsystem) solution. > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services Linaro.org │ Open source > software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-02-22 9:37 ` Li, Meng @ 2021-03-09 9:43 ` Lee Jones 2021-03-09 9:51 ` Li, Meng 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2021-03-09 9:43 UTC (permalink / raw) To: Li, Meng; +Cc: Marc Zyngier, linux-kernel, arnd, Hao, Kexin On Mon, 22 Feb 2021, Li, Meng wrote: > > -----Original Message----- > > From: Lee Jones <lee.jones@linaro.org> > > Sent: Monday, February 22, 2021 5:21 PM > > To: Marc Zyngier <maz@kernel.org> > > Cc: Li, Meng <Meng.Li@windriver.com>; linux-kernel@vger.kernel.org; > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > > regmap_config" > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Mon, 22 Feb 2021, Marc Zyngier wrote: > > > > > Hi Limeng, > > > > > > On 2021-02-22 03:45, Li, Meng wrote: > > > > Hi Marc&Lee, > > > > > > > > Is there any comment on this patch? > > > > Could you please help to review this patch so that I can improve it > > > > if it still has weakness? > > > > > > If you are confident that the root issue has been fixed, no objection > > > from me, but I'm not in a position to test it at the moment (the board > > > I found the problem on is in a bit of a state). > > > > I'm not keen on flip-flopping this patch in and out of the kernel. > > Someone really needs to spend some time to map out the full life-cycle and > > propose a (possibly cross-subsystem) solution. > > > Thanks for all of your comments. Have you looked into this further at all? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-03-09 9:43 ` Lee Jones @ 2021-03-09 9:51 ` Li, Meng 2021-03-09 18:15 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Li, Meng @ 2021-03-09 9:51 UTC (permalink / raw) To: Lee Jones; +Cc: Marc Zyngier, linux-kernel, arnd, Hao, Kexin > -----Original Message----- > From: Lee Jones <lee.jones@linaro.org> > Sent: Tuesday, March 9, 2021 5:43 PM > To: Li, Meng <Meng.Li@windriver.com> > Cc: Marc Zyngier <maz@kernel.org>; linux-kernel@vger.kernel.org; > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > regmap_config" > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Mon, 22 Feb 2021, Li, Meng wrote: > > > -----Original Message----- > > > From: Lee Jones <lee.jones@linaro.org> > > > Sent: Monday, February 22, 2021 5:21 PM > > > To: Marc Zyngier <maz@kernel.org> > > > Cc: Li, Meng <Meng.Li@windriver.com>; linux-kernel@vger.kernel.org; > > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated > > > name for regmap_config" > > > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > > > On Mon, 22 Feb 2021, Marc Zyngier wrote: > > > > > > > Hi Limeng, > > > > > > > > On 2021-02-22 03:45, Li, Meng wrote: > > > > > Hi Marc&Lee, > > > > > > > > > > Is there any comment on this patch? > > > > > Could you please help to review this patch so that I can improve > > > > > it if it still has weakness? > > > > > > > > If you are confident that the root issue has been fixed, no > > > > objection from me, but I'm not in a position to test it at the > > > > moment (the board I found the problem on is in a bit of a state). > > > > > > I'm not keen on flip-flopping this patch in and out of the kernel. > > > Someone really needs to spend some time to map out the full > > > life-cycle and propose a (possibly cross-subsystem) solution. > > > > > Thanks for all of your comments. > > Have you looked into this further at all? > No. Maintainer expects better solution to solve this issue from frame level, and consider cross-subsystem. Thanks, Limeng > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services Linaro.org │ Open source > software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-03-09 9:51 ` Li, Meng @ 2021-03-09 18:15 ` Lee Jones 2021-03-10 1:41 ` Li, Meng 0 siblings, 1 reply; 10+ messages in thread From: Lee Jones @ 2021-03-09 18:15 UTC (permalink / raw) To: Li, Meng; +Cc: Marc Zyngier, linux-kernel, arnd, Hao, Kexin On Tue, 09 Mar 2021, Li, Meng wrote: > > > > -----Original Message----- > > From: Lee Jones <lee.jones@linaro.org> > > Sent: Tuesday, March 9, 2021 5:43 PM > > To: Li, Meng <Meng.Li@windriver.com> > > Cc: Marc Zyngier <maz@kernel.org>; linux-kernel@vger.kernel.org; > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > > regmap_config" > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Mon, 22 Feb 2021, Li, Meng wrote: > > > > -----Original Message----- > > > > From: Lee Jones <lee.jones@linaro.org> > > > > Sent: Monday, February 22, 2021 5:21 PM > > > > To: Marc Zyngier <maz@kernel.org> > > > > Cc: Li, Meng <Meng.Li@windriver.com>; linux-kernel@vger.kernel.org; > > > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated > > > > name for regmap_config" > > > > > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > > > > > On Mon, 22 Feb 2021, Marc Zyngier wrote: > > > > > > > > > Hi Limeng, > > > > > > > > > > On 2021-02-22 03:45, Li, Meng wrote: > > > > > > Hi Marc&Lee, > > > > > > > > > > > > Is there any comment on this patch? > > > > > > Could you please help to review this patch so that I can improve > > > > > > it if it still has weakness? > > > > > > > > > > If you are confident that the root issue has been fixed, no > > > > > objection from me, but I'm not in a position to test it at the > > > > > moment (the board I found the problem on is in a bit of a state). > > > > > > > > I'm not keen on flip-flopping this patch in and out of the kernel. > > > > Someone really needs to spend some time to map out the full > > > > life-cycle and propose a (possibly cross-subsystem) solution. > > > > > > > Thanks for all of your comments. > > > > Have you looked into this further at all? > > > > No. > Maintainer expects better solution to solve this issue from frame level, and consider cross-subsystem. Yes, I do. Does that mean you're going to drop it? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-03-09 18:15 ` Lee Jones @ 2021-03-10 1:41 ` Li, Meng 2021-03-10 8:31 ` Lee Jones 0 siblings, 1 reply; 10+ messages in thread From: Li, Meng @ 2021-03-10 1:41 UTC (permalink / raw) To: Lee Jones; +Cc: Marc Zyngier, linux-kernel, arnd, Hao, Kexin > -----Original Message----- > From: Lee Jones <lee.jones@linaro.org> > Sent: Wednesday, March 10, 2021 2:15 AM > To: Li, Meng <Meng.Li@windriver.com> > Cc: Marc Zyngier <maz@kernel.org>; linux-kernel@vger.kernel.org; > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > regmap_config" > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > On Tue, 09 Mar 2021, Li, Meng wrote: > > > > > > > > -----Original Message----- > > > From: Lee Jones <lee.jones@linaro.org> > > > Sent: Tuesday, March 9, 2021 5:43 PM > > > To: Li, Meng <Meng.Li@windriver.com> > > > Cc: Marc Zyngier <maz@kernel.org>; linux-kernel@vger.kernel.org; > > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated > > > name for regmap_config" > > > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > > > On Mon, 22 Feb 2021, Li, Meng wrote: > > > > > -----Original Message----- > > > > > From: Lee Jones <lee.jones@linaro.org> > > > > > Sent: Monday, February 22, 2021 5:21 PM > > > > > To: Marc Zyngier <maz@kernel.org> > > > > > Cc: Li, Meng <Meng.Li@windriver.com>; > > > > > linux-kernel@vger.kernel.org; arnd@arndb.de; Hao, Kexin > > > > > <Kexin.Hao@windriver.com> > > > > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free > > > > > allocated name for regmap_config" > > > > > > > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > > > > > > > On Mon, 22 Feb 2021, Marc Zyngier wrote: > > > > > > > > > > > Hi Limeng, > > > > > > > > > > > > On 2021-02-22 03:45, Li, Meng wrote: > > > > > > > Hi Marc&Lee, > > > > > > > > > > > > > > Is there any comment on this patch? > > > > > > > Could you please help to review this patch so that I can > > > > > > > improve it if it still has weakness? > > > > > > > > > > > > If you are confident that the root issue has been fixed, no > > > > > > objection from me, but I'm not in a position to test it at the > > > > > > moment (the board I found the problem on is in a bit of a state). > > > > > > > > > > I'm not keen on flip-flopping this patch in and out of the kernel. > > > > > Someone really needs to spend some time to map out the full > > > > > life-cycle and propose a (possibly cross-subsystem) solution. > > > > > > > > > Thanks for all of your comments. > > > > > > Have you looked into this further at all? > > > > > > > No. > > Maintainer expects better solution to solve this issue from frame level, and > consider cross-subsystem. > > Yes, I do. Does that mean you're going to drop it? > Thanks for fixing this issue. Please discard my patch, I will not do further effort and drop it. Thanks, Limeng > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services Linaro.org │ Open source > software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" 2021-03-10 1:41 ` Li, Meng @ 2021-03-10 8:31 ` Lee Jones 0 siblings, 0 replies; 10+ messages in thread From: Lee Jones @ 2021-03-10 8:31 UTC (permalink / raw) To: Li, Meng; +Cc: Marc Zyngier, linux-kernel, arnd, Hao, Kexin On Wed, 10 Mar 2021, Li, Meng wrote: > > > > -----Original Message----- > > From: Lee Jones <lee.jones@linaro.org> > > Sent: Wednesday, March 10, 2021 2:15 AM > > To: Li, Meng <Meng.Li@windriver.com> > > Cc: Marc Zyngier <maz@kernel.org>; linux-kernel@vger.kernel.org; > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for > > regmap_config" > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > On Tue, 09 Mar 2021, Li, Meng wrote: > > > > > > > > > > > > -----Original Message----- > > > > From: Lee Jones <lee.jones@linaro.org> > > > > Sent: Tuesday, March 9, 2021 5:43 PM > > > > To: Li, Meng <Meng.Li@windriver.com> > > > > Cc: Marc Zyngier <maz@kernel.org>; linux-kernel@vger.kernel.org; > > > > arnd@arndb.de; Hao, Kexin <Kexin.Hao@windriver.com> > > > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free allocated > > > > name for regmap_config" > > > > > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > > > > > On Mon, 22 Feb 2021, Li, Meng wrote: > > > > > > -----Original Message----- > > > > > > From: Lee Jones <lee.jones@linaro.org> > > > > > > Sent: Monday, February 22, 2021 5:21 PM > > > > > > To: Marc Zyngier <maz@kernel.org> > > > > > > Cc: Li, Meng <Meng.Li@windriver.com>; > > > > > > linux-kernel@vger.kernel.org; arnd@arndb.de; Hao, Kexin > > > > > > <Kexin.Hao@windriver.com> > > > > > > Subject: Re: [v2][PATCH] Revert "mfd: syscon: Don't free > > > > > > allocated name for regmap_config" > > > > > > > > > > > > [Please note: This e-mail is from an EXTERNAL e-mail address] > > > > > > > > > > > > On Mon, 22 Feb 2021, Marc Zyngier wrote: > > > > > > > > > > > > > Hi Limeng, > > > > > > > > > > > > > > On 2021-02-22 03:45, Li, Meng wrote: > > > > > > > > Hi Marc&Lee, > > > > > > > > > > > > > > > > Is there any comment on this patch? > > > > > > > > Could you please help to review this patch so that I can > > > > > > > > improve it if it still has weakness? > > > > > > > > > > > > > > If you are confident that the root issue has been fixed, no > > > > > > > objection from me, but I'm not in a position to test it at the > > > > > > > moment (the board I found the problem on is in a bit of a state). > > > > > > > > > > > > I'm not keen on flip-flopping this patch in and out of the kernel. > > > > > > Someone really needs to spend some time to map out the full > > > > > > life-cycle and propose a (possibly cross-subsystem) solution. > > > > > > > > > > > Thanks for all of your comments. > > > > > > > > Have you looked into this further at all? > > > > > > > > > > No. > > > Maintainer expects better solution to solve this issue from frame level, and > > consider cross-subsystem. > > > > Yes, I do. Does that mean you're going to drop it? > > > > Thanks for fixing this issue. > Please discard my patch, I will not do further effort and drop it. For the record, this has not been fixed. Someone still needs to work on a suitable fix for this issue. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-03-10 8:32 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-01-15 1:50 [v2][PATCH] Revert "mfd: syscon: Don't free allocated name for regmap_config" meng.li 2021-02-22 3:45 ` Li, Meng 2021-02-22 9:12 ` Marc Zyngier 2021-02-22 9:21 ` Lee Jones 2021-02-22 9:37 ` Li, Meng 2021-03-09 9:43 ` Lee Jones 2021-03-09 9:51 ` Li, Meng 2021-03-09 18:15 ` Lee Jones 2021-03-10 1:41 ` Li, Meng 2021-03-10 8:31 ` Lee Jones
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.