* [meta-oe][PATCH] php: update RDEPENDS
@ 2021-03-10 0:53 Changqing Li
2021-03-10 17:40 ` [oe] " Diego Santa Cruz
0 siblings, 1 reply; 3+ messages in thread
From: Changqing Li @ 2021-03-10 0:53 UTC (permalink / raw)
To: openembedded-devel
From: Changqing Li <changqing.li@windriver.com>
Since commit c4ffcaa2[php: split out phpdbg into a separate package],
package php is empty, remove it from RDEPENDS to avoid error:
nothing provides php needed by php-cli-7.4.9-r0.corei7_64
Signed-off-by: Changqing Li <changqing.li@windriver.com>
---
meta-oe/recipes-devtools/php/php_7.4.9.bb | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/meta-oe/recipes-devtools/php/php_7.4.9.bb b/meta-oe/recipes-devtools/php/php_7.4.9.bb
index f8a8755b9..d6df998f3 100644
--- a/meta-oe/recipes-devtools/php/php_7.4.9.bb
+++ b/meta-oe/recipes-devtools/php/php_7.4.9.bb
@@ -208,11 +208,8 @@ MODPHP_PACKAGE = "${@bb.utils.contains('PACKAGECONFIG', 'apache2', '${PN}-modphp
PACKAGES = "${PN}-dbg ${PN}-cli ${PN}-phpdbg ${PN}-cgi ${PN}-fpm ${PN}-fpm-apache2 ${PN}-pear ${PN}-phar ${MODPHP_PACKAGE} ${PN}-dev ${PN}-staticdev ${PN}-doc ${PN}-opcache ${PN}"
RDEPENDS_${PN} += "libgcc"
-RDEPENDS_${PN}-pear = "${PN}"
RDEPENDS_${PN}-phar = "${PN}-cli"
-RDEPENDS_${PN}-cli = "${PN}"
-RDEPENDS_${PN}-modphp = "${PN} apache2"
-RDEPENDS_${PN}-opcache = "${PN}"
+RDEPENDS_${PN}-modphp = "apache2"
INITSCRIPT_PACKAGES = "${PN}-fpm"
inherit update-rc.d
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [oe] [meta-oe][PATCH] php: update RDEPENDS
2021-03-10 0:53 [meta-oe][PATCH] php: update RDEPENDS Changqing Li
@ 2021-03-10 17:40 ` Diego Santa Cruz
2021-03-11 0:56 ` Changqing Li
0 siblings, 1 reply; 3+ messages in thread
From: Diego Santa Cruz @ 2021-03-10 17:40 UTC (permalink / raw)
To: changqing.li, openembedded-devel
> -----Original Message-----
> From: openembedded-devel@lists.openembedded.org <openembedded-
> devel@lists.openembedded.org> On Behalf Of Changqing Li via
> lists.openembedded.org
> Sent: 10 March 2021 01:54
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH] php: update RDEPENDS
>
> From: Changqing Li <changqing.li@windriver.com>
>
> Since commit c4ffcaa2[php: split out phpdbg into a separate package], package
> php is empty, remove it from RDEPENDS to avoid error:
> nothing provides php needed by php-cli-7.4.9-r0.corei7_64
>
> Signed-off-by: Changqing Li <changqing.li@windriver.com>
> ---
> meta-oe/recipes-devtools/php/php_7.4.9.bb | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/meta-oe/recipes-devtools/php/php_7.4.9.bb b/meta-oe/recipes-
> devtools/php/php_7.4.9.bb
> index f8a8755b9..d6df998f3 100644
> --- a/meta-oe/recipes-devtools/php/php_7.4.9.bb
> +++ b/meta-oe/recipes-devtools/php/php_7.4.9.bb
> @@ -208,11 +208,8 @@ MODPHP_PACKAGE =
> "${@bb.utils.contains('PACKAGECONFIG', 'apache2', '${PN}-modphp PACKAGES
> = "${PN}-dbg ${PN}-cli ${PN}-phpdbg ${PN}-cgi ${PN}-fpm ${PN}-fpm-apache2
> ${PN}-pear ${PN}-phar ${MODPHP_PACKAGE} ${PN}-dev ${PN}-staticdev ${PN}-
> doc ${PN}-opcache ${PN}"
>
> RDEPENDS_${PN} += "libgcc"
> -RDEPENDS_${PN}-pear = "${PN}"
> RDEPENDS_${PN}-phar = "${PN}-cli"
> -RDEPENDS_${PN}-cli = "${PN}"
> -RDEPENDS_${PN}-modphp = "${PN} apache2"
> -RDEPENDS_${PN}-opcache = "${PN}"
> +RDEPENDS_${PN}-modphp = "apache2"
I do not think this is the correct fix. In many situations php.ini files from a bbappend will be part of the php package (that is my case and why I did not notice the above problem when I split phpdbg), are common to various SAPIs. I do not know why the current recipe does not install a php.ini file though, I thought it did. Probably the best solution is to just allow php to be an empty package with the following (it will make life easier for bbappends that need to ship a php.ini).
ALLOW_EMPTY_${PN} = "1"
>
> INITSCRIPT_PACKAGES = "${PN}-fpm"
> inherit update-rc.d
> --
> 2.17.1
--
Diego Santa Cruz, PhD
Technology Architect
spinetix.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [oe] [meta-oe][PATCH] php: update RDEPENDS
2021-03-10 17:40 ` [oe] " Diego Santa Cruz
@ 2021-03-11 0:56 ` Changqing Li
0 siblings, 0 replies; 3+ messages in thread
From: Changqing Li @ 2021-03-11 0:56 UTC (permalink / raw)
To: Diego Santa Cruz, openembedded-devel
On 3/11/21 1:40 AM, Diego Santa Cruz wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
>
>> -----Original Message-----
>> From: openembedded-devel@lists.openembedded.org <openembedded-
>> devel@lists.openembedded.org> On Behalf Of Changqing Li via
>> lists.openembedded.org
>> Sent: 10 March 2021 01:54
>> To: openembedded-devel@lists.openembedded.org
>> Subject: [oe] [meta-oe][PATCH] php: update RDEPENDS
>>
>> From: Changqing Li <changqing.li@windriver.com>
>>
>> Since commit c4ffcaa2[php: split out phpdbg into a separate package], package
>> php is empty, remove it from RDEPENDS to avoid error:
>> nothing provides php needed by php-cli-7.4.9-r0.corei7_64
>>
>> Signed-off-by: Changqing Li <changqing.li@windriver.com>
>> ---
>> meta-oe/recipes-devtools/php/php_7.4.9.bb | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/meta-oe/recipes-devtools/php/php_7.4.9.bb b/meta-oe/recipes-
>> devtools/php/php_7.4.9.bb
>> index f8a8755b9..d6df998f3 100644
>> --- a/meta-oe/recipes-devtools/php/php_7.4.9.bb
>> +++ b/meta-oe/recipes-devtools/php/php_7.4.9.bb
>> @@ -208,11 +208,8 @@ MODPHP_PACKAGE =
>> "${@bb.utils.contains('PACKAGECONFIG', 'apache2', '${PN}-modphp PACKAGES
>> = "${PN}-dbg ${PN}-cli ${PN}-phpdbg ${PN}-cgi ${PN}-fpm ${PN}-fpm-apache2
>> ${PN}-pear ${PN}-phar ${MODPHP_PACKAGE} ${PN}-dev ${PN}-staticdev ${PN}-
>> doc ${PN}-opcache ${PN}"
>>
>> RDEPENDS_${PN} += "libgcc"
>> -RDEPENDS_${PN}-pear = "${PN}"
>> RDEPENDS_${PN}-phar = "${PN}-cli"
>> -RDEPENDS_${PN}-cli = "${PN}"
>> -RDEPENDS_${PN}-modphp = "${PN} apache2"
>> -RDEPENDS_${PN}-opcache = "${PN}"
>> +RDEPENDS_${PN}-modphp = "apache2"
> I do not think this is the correct fix. In many situations php.ini files from a bbappend will be part of the php package (that is my case and why I did not notice the above problem when I split phpdbg), are common to various SAPIs. I do not know why the current recipe does not install a php.ini file though, I thought it did. Probably the best solution is to just allow php to be an empty package with the following (it will make life easier for bbappends that need to ship a php.ini).
>
> ALLOW_EMPTY_${PN} = "1"
Thanks. I will resend the patch.
>
>> INITSCRIPT_PACKAGES = "${PN}-fpm"
>> inherit update-rc.d
>> --
>> 2.17.1
> --
> Diego Santa Cruz, PhD
> Technology Architect
> spinetix.com
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-11 0:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 0:53 [meta-oe][PATCH] php: update RDEPENDS Changqing Li
2021-03-10 17:40 ` [oe] " Diego Santa Cruz
2021-03-11 0:56 ` Changqing Li
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.