All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] boot/uboot: fix compilation with PER_PACKAGE_DIRECTORIES enable
@ 2021-03-10 16:16 Nicolas Toromanoff
  2021-03-13  8:14 ` Yann E. MORIN
  2021-03-20 16:50 ` Peter Korsgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Toromanoff @ 2021-03-10 16:16 UTC (permalink / raw)
  To: buildroot

If PER_PACKAGE_DIRECTORIES=Y and using host-make package
(because BR2_FORCE_HOST_BUILD=Y or local make is too old)
.stamp_dotconfig target needs per-package/uboot/host/bin/host-make that doesn't exist yet.
Add host-make into UBOOT_KCONFIG_DEPENDENCIES.

Signed-off-by: Nicolas Toromanoff <nicolas.toromanoff@foss.st.com>
---
 boot/uboot/uboot.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
index bb4598002252..dbe82e65b17e 100644
--- a/boot/uboot/uboot.mk
+++ b/boot/uboot/uboot.mk
@@ -498,6 +498,7 @@ $(eval $(generic-package))
 else ifeq ($(BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG),y)
 UBOOT_MAKE_ENV = $(TARGET_MAKE_ENV)
 UBOOT_KCONFIG_DEPENDENCIES = \
+	$(BR2_MAKE_HOST_DEPENDENCY) \
 	$(BR2_BISON_HOST_DEPENDENCY) \
 	$(BR2_FLEX_HOST_DEPENDENCY)
 $(eval $(kconfig-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] boot/uboot: fix compilation with PER_PACKAGE_DIRECTORIES enable
  2021-03-10 16:16 [Buildroot] [PATCH 1/1] boot/uboot: fix compilation with PER_PACKAGE_DIRECTORIES enable Nicolas Toromanoff
@ 2021-03-13  8:14 ` Yann E. MORIN
  2021-03-20 16:50 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2021-03-13  8:14 UTC (permalink / raw)
  To: buildroot

Nicolas, All,

On 2021-03-10 17:16 +0100, Nicolas Toromanoff spake thusly:
> If PER_PACKAGE_DIRECTORIES=Y and using host-make package
> (because BR2_FORCE_HOST_BUILD=Y or local make is too old)
> .stamp_dotconfig target needs per-package/uboot/host/bin/host-make that doesn't exist yet.
> Add host-make into UBOOT_KCONFIG_DEPENDENCIES.

At first, I was a bit confused because BR2_MAKE_HOST_DEPENDENCY is
already a dependency of uboot... So I slightly rephrased the commit
title to emphasize that this is related to the kconfig dependencies.

> Signed-off-by: Nicolas Toromanoff <nicolas.toromanoff@foss.st.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  boot/uboot/uboot.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> index bb4598002252..dbe82e65b17e 100644
> --- a/boot/uboot/uboot.mk
> +++ b/boot/uboot/uboot.mk
> @@ -498,6 +498,7 @@ $(eval $(generic-package))
>  else ifeq ($(BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG),y)
>  UBOOT_MAKE_ENV = $(TARGET_MAKE_ENV)
>  UBOOT_KCONFIG_DEPENDENCIES = \
> +	$(BR2_MAKE_HOST_DEPENDENCY) \
>  	$(BR2_BISON_HOST_DEPENDENCY) \
>  	$(BR2_FLEX_HOST_DEPENDENCY)
>  $(eval $(kconfig-package))
> -- 
> 2.17.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] boot/uboot: fix compilation with PER_PACKAGE_DIRECTORIES enable
  2021-03-10 16:16 [Buildroot] [PATCH 1/1] boot/uboot: fix compilation with PER_PACKAGE_DIRECTORIES enable Nicolas Toromanoff
  2021-03-13  8:14 ` Yann E. MORIN
@ 2021-03-20 16:50 ` Peter Korsgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2021-03-20 16:50 UTC (permalink / raw)
  To: buildroot

>>>>> "Nicolas" == Nicolas Toromanoff <nicolas.toromanoff@foss.st.com> writes:

 > If PER_PACKAGE_DIRECTORIES=Y and using host-make package
 > (because BR2_FORCE_HOST_BUILD=Y or local make is too old)
 > .stamp_dotconfig target needs per-package/uboot/host/bin/host-make that doesn't exist yet.
 > Add host-make into UBOOT_KCONFIG_DEPENDENCIES.

 > Signed-off-by: Nicolas Toromanoff <nicolas.toromanoff@foss.st.com>

Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-03-20 16:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 16:16 [Buildroot] [PATCH 1/1] boot/uboot: fix compilation with PER_PACKAGE_DIRECTORIES enable Nicolas Toromanoff
2021-03-13  8:14 ` Yann E. MORIN
2021-03-20 16:50 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.