* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
@ 2021-03-10 18:43 kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-03-10 18:43 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 2857 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210310164439.24933-5-justin.iurman@uliege.be>
References: <20210310164439.24933-5-justin.iurman@uliege.be>
TO: Justin Iurman <justin.iurman@uliege.be>
TO: netdev(a)vger.kernel.org
CC: davem(a)davemloft.net
CC: kuba(a)kernel.org
CC: tom(a)herbertland.com
CC: justin.iurman(a)uliege.be
Hi Justin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: sparc64-randconfig-s032-20210310 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-262-g5e674421-dirty
# https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
git checkout f20771586508a195a44298f251d68446c10830ce
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> net/ipv6/ioam6.c:856:1: sparse: sparse: unused label 'out_unregister_genl'
vim +/out_unregister_genl +856 net/ipv6/ioam6.c
f20771586508a1 Justin Iurman 2021-03-10 851
e1a4cb7c14f537 Justin Iurman 2021-03-10 852 pr_info("In-situ OAM (IOAM) with IPv6\n");
ffece959dfe59a Justin Iurman 2021-03-10 853
ffece959dfe59a Justin Iurman 2021-03-10 854 out:
ffece959dfe59a Justin Iurman 2021-03-10 855 return err;
f20771586508a1 Justin Iurman 2021-03-10 @856 out_unregister_genl:
f20771586508a1 Justin Iurman 2021-03-10 857 genl_unregister_family(&ioam6_genl_family);
ffece959dfe59a Justin Iurman 2021-03-10 858 out_unregister_pernet_subsys:
ffece959dfe59a Justin Iurman 2021-03-10 859 unregister_pernet_subsys(&ioam6_net_ops);
ffece959dfe59a Justin Iurman 2021-03-10 860 goto out;
e1a4cb7c14f537 Justin Iurman 2021-03-10 861 }
e1a4cb7c14f537 Justin Iurman 2021-03-10 862
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42503 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
2021-03-11 0:56 ` kernel test robot
@ 2021-03-22 12:56 ` Justin Iurman
-1 siblings, 0 replies; 8+ messages in thread
From: Justin Iurman @ 2021-03-22 12:56 UTC (permalink / raw)
To: kernel test robot; +Cc: netdev, kbuild-all, davem, kuba, tom
> Hi Justin,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> d310ec03a34e92a77302edb804f7d68ee4f01ba0
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
> config: sparc64-randconfig-s032-20210310 (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 9.3.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.3-262-g5e674421-dirty
> #
> https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review
> Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
> git checkout f20771586508a195a44298f251d68446c10830ce
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
> CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> "sparse warnings: (new ones prefixed by >>)"
>>> net/ipv6/ioam6.c:856:1: sparse: sparse: unused label 'out_unregister_genl'
Apologies for this small oversight, will update it and post a v3 (forgot the "v2" tag for this patchset by the way).
> vim +/out_unregister_genl +856 net/ipv6/ioam6.c
>
> f20771586508a1 Justin Iurman 2021-03-10 851
> e1a4cb7c14f537 Justin Iurman 2021-03-10 852 pr_info("In-situ OAM (IOAM) with
> IPv6\n");
> ffece959dfe59a Justin Iurman 2021-03-10 853
> ffece959dfe59a Justin Iurman 2021-03-10 854 out:
> ffece959dfe59a Justin Iurman 2021-03-10 855 return err;
> f20771586508a1 Justin Iurman 2021-03-10 @856 out_unregister_genl:
> f20771586508a1 Justin Iurman 2021-03-10 857
> genl_unregister_family(&ioam6_genl_family);
> ffece959dfe59a Justin Iurman 2021-03-10 858 out_unregister_pernet_subsys:
> ffece959dfe59a Justin Iurman 2021-03-10 859
> unregister_pernet_subsys(&ioam6_net_ops);
> ffece959dfe59a Justin Iurman 2021-03-10 860 goto out;
> e1a4cb7c14f537 Justin Iurman 2021-03-10 861 }
> e1a4cb7c14f537 Justin Iurman 2021-03-10 862
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
@ 2021-03-22 12:56 ` Justin Iurman
0 siblings, 0 replies; 8+ messages in thread
From: Justin Iurman @ 2021-03-22 12:56 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2636 bytes --]
> Hi Justin,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on net-next/master]
>
> url:
> https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
> base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> d310ec03a34e92a77302edb804f7d68ee4f01ba0
> :::::: branch date: 2 hours ago
> :::::: commit date: 2 hours ago
> config: sparc64-randconfig-s032-20210310 (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 9.3.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
> ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # apt-get install sparse
> # sparse version: v0.6.3-262-g5e674421-dirty
> #
> https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review
> Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
> git checkout f20771586508a195a44298f251d68446c10830ce
> # save the attached .config to linux build tree
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1
> CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
>
> "sparse warnings: (new ones prefixed by >>)"
>>> net/ipv6/ioam6.c:856:1: sparse: sparse: unused label 'out_unregister_genl'
Apologies for this small oversight, will update it and post a v3 (forgot the "v2" tag for this patchset by the way).
> vim +/out_unregister_genl +856 net/ipv6/ioam6.c
>
> f20771586508a1 Justin Iurman 2021-03-10 851
> e1a4cb7c14f537 Justin Iurman 2021-03-10 852 pr_info("In-situ OAM (IOAM) with
> IPv6\n");
> ffece959dfe59a Justin Iurman 2021-03-10 853
> ffece959dfe59a Justin Iurman 2021-03-10 854 out:
> ffece959dfe59a Justin Iurman 2021-03-10 855 return err;
> f20771586508a1 Justin Iurman 2021-03-10 @856 out_unregister_genl:
> f20771586508a1 Justin Iurman 2021-03-10 857
> genl_unregister_family(&ioam6_genl_family);
> ffece959dfe59a Justin Iurman 2021-03-10 858 out_unregister_pernet_subsys:
> ffece959dfe59a Justin Iurman 2021-03-10 859
> unregister_pernet_subsys(&ioam6_net_ops);
> ffece959dfe59a Justin Iurman 2021-03-10 860 goto out;
> e1a4cb7c14f537 Justin Iurman 2021-03-10 861 }
> e1a4cb7c14f537 Justin Iurman 2021-03-10 862
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
2021-03-10 16:44 ` [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels Justin Iurman
@ 2021-03-11 0:56 ` kernel test robot
2021-03-11 0:56 ` kernel test robot
1 sibling, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-03-11 0:56 UTC (permalink / raw)
To: Justin Iurman, netdev; +Cc: kbuild-all, davem, kuba, tom, justin.iurman
[-- Attachment #1: Type: text/plain, Size: 2465 bytes --]
Hi Justin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: sparc64-randconfig-s032-20210310 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-262-g5e674421-dirty
# https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
git checkout f20771586508a195a44298f251d68446c10830ce
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> net/ipv6/ioam6.c:856:1: sparse: sparse: unused label 'out_unregister_genl'
vim +/out_unregister_genl +856 net/ipv6/ioam6.c
f20771586508a1 Justin Iurman 2021-03-10 851
e1a4cb7c14f537 Justin Iurman 2021-03-10 852 pr_info("In-situ OAM (IOAM) with IPv6\n");
ffece959dfe59a Justin Iurman 2021-03-10 853
ffece959dfe59a Justin Iurman 2021-03-10 854 out:
ffece959dfe59a Justin Iurman 2021-03-10 855 return err;
f20771586508a1 Justin Iurman 2021-03-10 @856 out_unregister_genl:
f20771586508a1 Justin Iurman 2021-03-10 857 genl_unregister_family(&ioam6_genl_family);
ffece959dfe59a Justin Iurman 2021-03-10 858 out_unregister_pernet_subsys:
ffece959dfe59a Justin Iurman 2021-03-10 859 unregister_pernet_subsys(&ioam6_net_ops);
ffece959dfe59a Justin Iurman 2021-03-10 860 goto out;
e1a4cb7c14f537 Justin Iurman 2021-03-10 861 }
e1a4cb7c14f537 Justin Iurman 2021-03-10 862
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42503 bytes --]
[-- Attachment #3: Type: text/plain, Size: 149 bytes --]
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
@ 2021-03-11 0:56 ` kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-03-11 0:56 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2674 bytes --]
Hi Justin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: sparc64-randconfig-s032-20210310 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-262-g5e674421-dirty
# https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
git checkout f20771586508a195a44298f251d68446c10830ce
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"sparse warnings: (new ones prefixed by >>)"
>> net/ipv6/ioam6.c:856:1: sparse: sparse: unused label 'out_unregister_genl'
vim +/out_unregister_genl +856 net/ipv6/ioam6.c
f20771586508a1 Justin Iurman 2021-03-10 851
e1a4cb7c14f537 Justin Iurman 2021-03-10 852 pr_info("In-situ OAM (IOAM) with IPv6\n");
ffece959dfe59a Justin Iurman 2021-03-10 853
ffece959dfe59a Justin Iurman 2021-03-10 854 out:
ffece959dfe59a Justin Iurman 2021-03-10 855 return err;
f20771586508a1 Justin Iurman 2021-03-10 @856 out_unregister_genl:
f20771586508a1 Justin Iurman 2021-03-10 857 genl_unregister_family(&ioam6_genl_family);
ffece959dfe59a Justin Iurman 2021-03-10 858 out_unregister_pernet_subsys:
ffece959dfe59a Justin Iurman 2021-03-10 859 unregister_pernet_subsys(&ioam6_net_ops);
ffece959dfe59a Justin Iurman 2021-03-10 860 goto out;
e1a4cb7c14f537 Justin Iurman 2021-03-10 861 }
e1a4cb7c14f537 Justin Iurman 2021-03-10 862
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 42503 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
2021-03-10 16:44 ` [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels Justin Iurman
@ 2021-03-10 20:15 ` kernel test robot
2021-03-11 0:56 ` kernel test robot
1 sibling, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-03-10 20:15 UTC (permalink / raw)
To: Justin Iurman, netdev
Cc: kbuild-all, clang-built-linux, davem, kuba, tom, justin.iurman
[-- Attachment #1: Type: text/plain, Size: 2078 bytes --]
Hi Justin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
config: x86_64-randconfig-a006-20210309 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project cd9a69289c7825d54450cb6829fef2c8e0f1963a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
git checkout f20771586508a195a44298f251d68446c10830ce
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv6/ioam6.c:856:1: warning: unused label 'out_unregister_genl' [-Wunused-label]
out_unregister_genl:
^~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +/out_unregister_genl +856 net/ipv6/ioam6.c
851
852 pr_info("In-situ OAM (IOAM) with IPv6\n");
853
854 out:
855 return err;
> 856 out_unregister_genl:
857 genl_unregister_family(&ioam6_genl_family);
858 out_unregister_pernet_subsys:
859 unregister_pernet_subsys(&ioam6_net_ops);
860 goto out;
861 }
862
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 32895 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
@ 2021-03-10 20:15 ` kernel test robot
0 siblings, 0 replies; 8+ messages in thread
From: kernel test robot @ 2021-03-10 20:15 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2131 bytes --]
Hi Justin,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git d310ec03a34e92a77302edb804f7d68ee4f01ba0
config: x86_64-randconfig-a006-20210309 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project cd9a69289c7825d54450cb6829fef2c8e0f1963a)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# https://github.com/0day-ci/linux/commit/f20771586508a195a44298f251d68446c10830ce
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Justin-Iurman/Support-for-the-IOAM-Pre-allocated-Trace-with-IPv6/20210311-005727
git checkout f20771586508a195a44298f251d68446c10830ce
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> net/ipv6/ioam6.c:856:1: warning: unused label 'out_unregister_genl' [-Wunused-label]
out_unregister_genl:
^~~~~~~~~~~~~~~~~~~~
1 warning generated.
vim +/out_unregister_genl +856 net/ipv6/ioam6.c
851
852 pr_info("In-situ OAM (IOAM) with IPv6\n");
853
854 out:
855 return err;
> 856 out_unregister_genl:
857 genl_unregister_family(&ioam6_genl_family);
858 out_unregister_pernet_subsys:
859 unregister_pernet_subsys(&ioam6_net_ops);
860 goto out;
861 }
862
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32895 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels
2021-03-10 16:44 [PATCH net-next 0/5] Support for the IOAM Pre-allocated Trace with IPv6 Justin Iurman
@ 2021-03-10 16:44 ` Justin Iurman
2021-03-10 20:15 ` kernel test robot
2021-03-11 0:56 ` kernel test robot
0 siblings, 2 replies; 8+ messages in thread
From: Justin Iurman @ 2021-03-10 16:44 UTC (permalink / raw)
To: netdev; +Cc: davem, kuba, tom, justin.iurman
Add support for the IOAM inline insertion (only for the host-to-host use case)
which is per-route configured with lightweight tunnels. The target is iproute2
and the patch is ready. It will be posted as soon as this patchset is merged.
Here is an overview:
$ ip -6 ro ad fc00::1/128 encap ioam6 trace type 0x800000 ns 1 size 12 dev eth0
This example configures an IOAM Pre-allocated Trace option attached to the
fc00::1/128 prefix. The IOAM namespace (ns) is 1, the size of the pre-allocated
trace data block is 12 octets (size) and only the first IOAM data (bit 0:
hop_limit + node id) is included in the trace (type) represented as a bitfield.
The reason why the in-transit (IPv6-in-IPv6 encapsulation) use case is not
implemented is explained on the patchset cover.
Signed-off-by: Justin Iurman <justin.iurman@uliege.be>
---
include/linux/ioam6_iptunnel.h | 13 ++
include/net/ioam6.h | 3 +
include/uapi/linux/ioam6.h | 1 +
include/uapi/linux/ioam6_iptunnel.h | 19 ++
include/uapi/linux/lwtunnel.h | 1 +
net/core/lwtunnel.c | 2 +
net/ipv6/Kconfig | 11 ++
net/ipv6/Makefile | 1 +
net/ipv6/ioam6.c | 15 +-
net/ipv6/ioam6_iptunnel.c | 261 ++++++++++++++++++++++++++++
10 files changed, 325 insertions(+), 2 deletions(-)
create mode 100644 include/linux/ioam6_iptunnel.h
create mode 100644 include/uapi/linux/ioam6_iptunnel.h
create mode 100644 net/ipv6/ioam6_iptunnel.c
diff --git a/include/linux/ioam6_iptunnel.h b/include/linux/ioam6_iptunnel.h
new file mode 100644
index 000000000000..07d9dfedd29d
--- /dev/null
+++ b/include/linux/ioam6_iptunnel.h
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * IPv6 IOAM Lightweight Tunnel API
+ *
+ * Author:
+ * Justin Iurman <justin.iurman@uliege.be>
+ */
+#ifndef _LINUX_IOAM6_IPTUNNEL_H
+#define _LINUX_IOAM6_IPTUNNEL_H
+
+#include <uapi/linux/ioam6_iptunnel.h>
+
+#endif /* _LINUX_IOAM6_IPTUNNEL_H */
diff --git a/include/net/ioam6.h b/include/net/ioam6.h
index 828b83c70721..9eab3817e90b 100644
--- a/include/net/ioam6.h
+++ b/include/net/ioam6.h
@@ -59,4 +59,7 @@ extern void ioam6_fill_trace_data(struct sk_buff *skb,
extern int ioam6_init(void);
extern void ioam6_exit(void);
+extern int ioam6_iptunnel_init(void);
+extern void ioam6_iptunnel_exit(void);
+
#endif /* _NET_IOAM6_H */
diff --git a/include/uapi/linux/ioam6.h b/include/uapi/linux/ioam6.h
index 2177e4e49566..0a1e09e43c28 100644
--- a/include/uapi/linux/ioam6.h
+++ b/include/uapi/linux/ioam6.h
@@ -117,6 +117,7 @@ struct ioam6_trace_hdr {
#error "Please fix <asm/byteorder.h>"
#endif
+#define IOAM6_TRACE_DATA_SIZE_MAX 244
__u8 data[0];
} __attribute__((packed));
diff --git a/include/uapi/linux/ioam6_iptunnel.h b/include/uapi/linux/ioam6_iptunnel.h
new file mode 100644
index 000000000000..ed4ba9d523d6
--- /dev/null
+++ b/include/uapi/linux/ioam6_iptunnel.h
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
+/*
+ * IPv6 IOAM Lightweight Tunnel API
+ *
+ * Author:
+ * Justin Iurman <justin.iurman@uliege.be>
+ */
+
+#ifndef _UAPI_LINUX_IOAM6_IPTUNNEL_H
+#define _UAPI_LINUX_IOAM6_IPTUNNEL_H
+
+enum {
+ IOAM6_IPTUNNEL_UNSPEC,
+ IOAM6_IPTUNNEL_TRACE, /* struct ioam6_trace_hdr */
+ __IOAM6_IPTUNNEL_MAX,
+};
+#define IOAM6_IPTUNNEL_MAX (__IOAM6_IPTUNNEL_MAX - 1)
+
+#endif /* _UAPI_LINUX_IOAM6_IPTUNNEL_H */
diff --git a/include/uapi/linux/lwtunnel.h b/include/uapi/linux/lwtunnel.h
index 568a4303ccce..2e206919125c 100644
--- a/include/uapi/linux/lwtunnel.h
+++ b/include/uapi/linux/lwtunnel.h
@@ -14,6 +14,7 @@ enum lwtunnel_encap_types {
LWTUNNEL_ENCAP_BPF,
LWTUNNEL_ENCAP_SEG6_LOCAL,
LWTUNNEL_ENCAP_RPL,
+ LWTUNNEL_ENCAP_IOAM6,
__LWTUNNEL_ENCAP_MAX,
};
diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
index 8ec7d13d2860..d0ae987d2de9 100644
--- a/net/core/lwtunnel.c
+++ b/net/core/lwtunnel.c
@@ -43,6 +43,8 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
return "SEG6LOCAL";
case LWTUNNEL_ENCAP_RPL:
return "RPL";
+ case LWTUNNEL_ENCAP_IOAM6:
+ return "IOAM6";
case LWTUNNEL_ENCAP_IP6:
case LWTUNNEL_ENCAP_IP:
case LWTUNNEL_ENCAP_NONE:
diff --git a/net/ipv6/Kconfig b/net/ipv6/Kconfig
index 747f56e0c636..e504204bca92 100644
--- a/net/ipv6/Kconfig
+++ b/net/ipv6/Kconfig
@@ -328,4 +328,15 @@ config IPV6_RPL_LWTUNNEL
If unsure, say N.
+config IPV6_IOAM6_LWTUNNEL
+ bool "IPv6: IOAM Pre-allocated Trace insertion support"
+ depends on IPV6
+ select LWTUNNEL
+ help
+ Support for the inline insertion of IOAM Pre-allocated
+ Trace Header (only on locally generated packets), using
+ the lightweight tunnels mechanism.
+
+ If unsure, say N.
+
endif # IPV6
diff --git a/net/ipv6/Makefile b/net/ipv6/Makefile
index b7ef10d417d6..1bc7e143217b 100644
--- a/net/ipv6/Makefile
+++ b/net/ipv6/Makefile
@@ -27,6 +27,7 @@ ipv6-$(CONFIG_NETLABEL) += calipso.o
ipv6-$(CONFIG_IPV6_SEG6_LWTUNNEL) += seg6_iptunnel.o seg6_local.o
ipv6-$(CONFIG_IPV6_SEG6_HMAC) += seg6_hmac.o
ipv6-$(CONFIG_IPV6_RPL_LWTUNNEL) += rpl_iptunnel.o
+ipv6-$(CONFIG_IPV6_IOAM6_LWTUNNEL) += ioam6_iptunnel.o
ipv6-objs += $(ipv6-y)
diff --git a/net/ipv6/ioam6.c b/net/ipv6/ioam6.c
index 09fb93f4cf1f..f0a1e2136132 100644
--- a/net/ipv6/ioam6.c
+++ b/net/ipv6/ioam6.c
@@ -600,7 +600,7 @@ static void __ioam6_fill_trace_data(struct sk_buff *skb,
if (skb->dev)
byte--;
- raw32 = dev_net(skb->dev)->ipv6.sysctl.ioam6_id;
+ raw32 = dev_net(skb_dst(skb)->dev)->ipv6.sysctl.ioam6_id;
if (!raw32)
raw32 = IOAM6_EMPTY_u24;
else
@@ -688,7 +688,7 @@ static void __ioam6_fill_trace_data(struct sk_buff *skb,
if (skb->dev)
byte--;
- raw64 = dev_net(skb->dev)->ipv6.sysctl.ioam6_id;
+ raw64 = dev_net(skb_dst(skb)->dev)->ipv6.sysctl.ioam6_id;
if (!raw64)
raw64 = IOAM6_EMPTY_u56;
else
@@ -843,10 +843,18 @@ int __init ioam6_init(void)
if (err)
goto out_unregister_pernet_subsys;
+#ifdef CONFIG_IPV6_IOAM6_LWTUNNEL
+ err = ioam6_iptunnel_init();
+ if (err)
+ goto out_unregister_genl;
+#endif
+
pr_info("In-situ OAM (IOAM) with IPv6\n");
out:
return err;
+out_unregister_genl:
+ genl_unregister_family(&ioam6_genl_family);
out_unregister_pernet_subsys:
unregister_pernet_subsys(&ioam6_net_ops);
goto out;
@@ -854,6 +862,9 @@ int __init ioam6_init(void)
void ioam6_exit(void)
{
+#ifdef CONFIG_IPV6_IOAM6_LWTUNNEL
+ ioam6_iptunnel_exit();
+#endif
genl_unregister_family(&ioam6_genl_family);
unregister_pernet_subsys(&ioam6_net_ops);
}
diff --git a/net/ipv6/ioam6_iptunnel.c b/net/ipv6/ioam6_iptunnel.c
new file mode 100644
index 000000000000..19390240edf7
--- /dev/null
+++ b/net/ipv6/ioam6_iptunnel.c
@@ -0,0 +1,261 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * IPv6 IOAM Lightweight Tunnel implementation
+ *
+ * Author:
+ * Justin Iurman <justin.iurman@uliege.be>
+ */
+
+#include <linux/kernel.h>
+#include <linux/skbuff.h>
+#include <linux/net.h>
+#include <linux/netlink.h>
+#include <linux/in6.h>
+#include <linux/ioam6.h>
+#include <linux/ioam6_iptunnel.h>
+#include <net/dst.h>
+#include <net/sock.h>
+#include <net/lwtunnel.h>
+#include <net/ioam6.h>
+
+struct ioam6_lwt {
+ struct ipv6_hopopt_hdr eh;
+ u8 pad[2]; /* 2-octet padding for 4n-alignment */
+ struct ioam6_hdr ioamh;
+ struct ioam6_trace_hdr traceh;
+} __attribute__((packed));
+
+static inline struct ioam6_lwt *ioam6_lwt_state(struct lwtunnel_state *lwt)
+{
+ return (struct ioam6_lwt *)lwt->data;
+}
+
+static inline struct ioam6_trace_hdr *ioam6_trace(struct lwtunnel_state *lwt)
+{
+ return &ioam6_lwt_state(lwt)->traceh;
+}
+
+static const struct nla_policy ioam6_iptunnel_policy[IOAM6_IPTUNNEL_MAX + 1] = {
+ [IOAM6_IPTUNNEL_TRACE] = { .type = NLA_BINARY },
+};
+
+static int nla_put_ioam6_trace(struct sk_buff *skb, int attrtype,
+ struct ioam6_trace_hdr *trace)
+{
+ struct ioam6_trace_hdr *data;
+ struct nlattr *nla;
+ int len;
+
+ len = sizeof(*trace);
+
+ nla = nla_reserve(skb, attrtype, len);
+ if (!nla)
+ return -EMSGSIZE;
+
+ data = nla_data(nla);
+ memcpy(data, trace, len);
+
+ return 0;
+}
+
+static bool ioam6_validate_trace_hdr(struct ioam6_trace_hdr *trace)
+{
+ if (!trace->type_be32 || !trace->remlen ||
+ trace->remlen > IOAM6_TRACE_DATA_SIZE_MAX / 4)
+ return false;
+
+ trace->nodelen = 0;
+ if (trace->type.bit0) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit1) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit2) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit3) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit4) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit5) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit6) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit7) trace->nodelen += sizeof(__be32) / 4;
+ if (trace->type.bit8) trace->nodelen += sizeof(__be64) / 4;
+ if (trace->type.bit9) trace->nodelen += sizeof(__be64) / 4;
+ if (trace->type.bit10) trace->nodelen += sizeof(__be64) / 4;
+ if (trace->type.bit11) trace->nodelen += sizeof(__be32) / 4;
+
+ return true;
+}
+
+static int ioam6_build_state(struct net *net, struct nlattr *nla,
+ unsigned int family, const void *cfg,
+ struct lwtunnel_state **ts,
+ struct netlink_ext_ack *extack)
+{
+ struct nlattr *tb[IOAM6_IPTUNNEL_MAX + 1];
+ struct ioam6_trace_hdr *trace;
+ struct lwtunnel_state *s;
+ struct ioam6_lwt *ilwt;
+ int len_aligned;
+ int len, err;
+
+ if (family != AF_INET6)
+ return -EINVAL;
+
+ err = nla_parse_nested(tb, IOAM6_IPTUNNEL_MAX, nla,
+ ioam6_iptunnel_policy, extack);
+ if (err < 0)
+ return err;
+
+ if (!tb[IOAM6_IPTUNNEL_TRACE])
+ return -EINVAL;
+
+ trace = nla_data(tb[IOAM6_IPTUNNEL_TRACE]);
+
+ if (nla_len(tb[IOAM6_IPTUNNEL_TRACE]) != sizeof(*trace))
+ return -EINVAL;
+
+ if (!ioam6_validate_trace_hdr(trace))
+ return -EINVAL;
+
+ len = sizeof(*ilwt) + trace->remlen * 4;
+ len_aligned = ALIGN(len, 8);
+
+ s = lwtunnel_state_alloc(len_aligned);
+ if (!s)
+ return -ENOMEM;
+
+ ilwt = ioam6_lwt_state(s);
+
+ ilwt->eh.hdrlen = (len_aligned >> 3) - 1;
+ ilwt->pad[0] = IPV6_TLV_PADN;
+
+ ilwt->ioamh.opt_type = IPV6_TLV_IOAM;
+ ilwt->ioamh.opt_len = sizeof(ilwt->ioamh) - 2 + sizeof(*trace) +
+ trace->remlen * 4;
+ ilwt->ioamh.type = IOAM6_TYPE_PREALLOC;
+
+ memcpy(&ilwt->traceh, trace, sizeof(*trace));
+
+ len = len_aligned - len;
+ if (len == 1) {
+ ilwt->traceh.data[trace->remlen * 4] = IPV6_TLV_PAD1;
+ } else if (len > 0) {
+ ilwt->traceh.data[trace->remlen * 4] = IPV6_TLV_PADN;
+ ilwt->traceh.data[trace->remlen * 4 + 1] = len - 2;
+ }
+
+ s->type = LWTUNNEL_ENCAP_IOAM6;
+ s->flags |= LWTUNNEL_STATE_OUTPUT_REDIRECT;
+
+ *ts = s;
+
+ return 0;
+}
+
+static int ioam6_output(struct net *net, struct sock *sk, struct sk_buff *skb)
+{
+ struct ioam6_trace_hdr *trace;
+ struct ipv6hdr *hdr, *oldhdr;
+ struct ioam6_namespace *ns;
+ struct ioam6_lwt *ilwt;
+ struct dst_entry *dst;
+ int hdrlen, err;
+
+ err = -EINVAL;
+ if (skb->protocol != htons(ETH_P_IPV6))
+ goto drop;
+
+ dst = skb_dst(skb);
+ dst->output = dst->lwtstate->orig_output;
+
+ oldhdr = ipv6_hdr(skb);
+
+ /* Only for packets we generated and
+ * that do not contain a Hop-by-Hop yet
+ */
+ if (skb->dev || oldhdr->nexthdr == NEXTHDR_HOP)
+ goto out;
+
+ ilwt = ioam6_lwt_state(dst->lwtstate);
+ hdrlen = (ilwt->eh.hdrlen + 1) << 3;
+
+ err = skb_cow_head(skb, hdrlen + skb->mac_len);
+ if (unlikely(err))
+ goto drop;
+
+ skb_pull(skb, sizeof(*oldhdr));
+ skb_postpull_rcsum(skb, skb_network_header(skb), sizeof(*oldhdr));
+
+ skb_push(skb, sizeof(*oldhdr) + hdrlen);
+ skb_reset_network_header(skb);
+ skb_mac_header_rebuild(skb);
+
+ hdr = ipv6_hdr(skb);
+ memmove(hdr, oldhdr, sizeof(*oldhdr));
+ ilwt->eh.nexthdr = hdr->nexthdr;
+
+ skb_set_transport_header(skb, sizeof(*hdr));
+ skb_postpush_rcsum(skb, hdr, sizeof(*hdr) + hdrlen);
+
+ memcpy(skb_transport_header(skb), (u8*)ilwt, hdrlen);
+
+ hdr->nexthdr = NEXTHDR_HOP;
+ hdr->payload_len = cpu_to_be16(skb->len - sizeof(*hdr));
+
+ trace = (struct ioam6_trace_hdr *)(skb_transport_header(skb)
+ + sizeof(struct ipv6_hopopt_hdr) + 2
+ + sizeof(struct ioam6_hdr));
+
+ err = skb_cow_head(skb, LL_RESERVED_SPACE(dst->dev));
+ if (unlikely(err))
+ goto drop;
+
+ ns = ioam6_namespace(dev_net(dst->dev), trace->namespace_id);
+ if (ns)
+ ioam6_fill_trace_data(skb, ns, trace);
+out:
+ return dst_output(net, sk, skb);
+drop:
+ kfree_skb(skb);
+ return err;
+}
+
+static int ioam6_fill_encap_info(struct sk_buff *skb,
+ struct lwtunnel_state *lwtstate)
+{
+ struct ioam6_trace_hdr *trace = ioam6_trace(lwtstate);
+
+ if (nla_put_ioam6_trace(skb, IOAM6_IPTUNNEL_TRACE, trace))
+ return -EMSGSIZE;
+
+ return 0;
+}
+
+static int ioam6_encap_nlsize(struct lwtunnel_state *lwtstate)
+{
+ struct ioam6_trace_hdr *trace = ioam6_trace(lwtstate);
+
+ return nla_total_size(sizeof(*trace));
+}
+
+static int ioam6_encap_cmp(struct lwtunnel_state *a, struct lwtunnel_state *b)
+{
+ struct ioam6_trace_hdr *a_hdr = ioam6_trace(a);
+ struct ioam6_trace_hdr *b_hdr = ioam6_trace(b);
+
+ return (a_hdr->namespace_id != b_hdr->namespace_id);
+}
+
+static const struct lwtunnel_encap_ops ioam6_iptun_ops = {
+ .build_state = ioam6_build_state,
+ .output = ioam6_output,
+ .fill_encap = ioam6_fill_encap_info,
+ .get_encap_size = ioam6_encap_nlsize,
+ .cmp_encap = ioam6_encap_cmp,
+ .owner = THIS_MODULE,
+};
+
+int __init ioam6_iptunnel_init(void)
+{
+ return lwtunnel_encap_add_ops(&ioam6_iptun_ops, LWTUNNEL_ENCAP_IOAM6);
+}
+
+void ioam6_iptunnel_exit(void)
+{
+ lwtunnel_encap_del_ops(&ioam6_iptun_ops, LWTUNNEL_ENCAP_IOAM6);
+}
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-22 12:59 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 18:43 [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-03-10 16:44 [PATCH net-next 0/5] Support for the IOAM Pre-allocated Trace with IPv6 Justin Iurman
2021-03-10 16:44 ` [PATCH net-next 4/5] ipv6: ioam: Support for IOAM injection with lwtunnels Justin Iurman
2021-03-10 20:15 ` kernel test robot
2021-03-10 20:15 ` kernel test robot
2021-03-11 0:56 ` kernel test robot
2021-03-11 0:56 ` kernel test robot
2021-03-22 12:56 ` Justin Iurman
2021-03-22 12:56 ` Justin Iurman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.