All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Guohan Lu <lguohan@gmail.com>,
	Joe LeVeque <jolevequ@microsoft.com>,
	akpm@linux-foundation.org
Subject: Re: [PATCH] kexec: Add kexec reboot string
Date: Thu, 11 Mar 2021 12:09:49 +0800	[thread overview]
Message-ID: <20210311040949.GG2962@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20210304124626.13927-1-pmenzel@molgen.mpg.de>

On 03/04/21 at 01:46pm, Paul Menzel wrote:
> From: Joe LeVeque <jolevequ@microsoft.com>
> 
> The purpose is to notify the kernel module for fast reboot.

Checked several modules which registered with reboot_notifier_list, the
passed string is not cared. Just curious, could you tell how you have
used or plan to use this string in your code?

No objection to this even though it's trivial if no real use case.

Acked-by: Baoquan He <bhe@redhat.com>

> 
> Upstream a patch from the SONiC network operating system [1].
> 
> [1]: https://github.com/Azure/sonic-linux-kernel/pull/46
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  kernel/kexec_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index a0b6780740c8..f04d04d1b855 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1165,7 +1165,7 @@ int kernel_kexec(void)
>  #endif
>  	{
>  		kexec_in_progress = true;
> -		kernel_restart_prepare(NULL);
> +		kernel_restart_prepare("kexec reboot");
>  		migrate_to_reboot_cpu();
>  
>  		/*
> -- 
> 2.30.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Eric Biederman <ebiederm@xmission.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
	Guohan Lu <lguohan@gmail.com>,
	Joe LeVeque <jolevequ@microsoft.com>,
	akpm@linux-foundation.org
Subject: Re: [PATCH] kexec: Add kexec reboot string
Date: Thu, 11 Mar 2021 12:09:49 +0800	[thread overview]
Message-ID: <20210311040949.GG2962@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20210304124626.13927-1-pmenzel@molgen.mpg.de>

On 03/04/21 at 01:46pm, Paul Menzel wrote:
> From: Joe LeVeque <jolevequ@microsoft.com>
> 
> The purpose is to notify the kernel module for fast reboot.

Checked several modules which registered with reboot_notifier_list, the
passed string is not cared. Just curious, could you tell how you have
used or plan to use this string in your code?

No objection to this even though it's trivial if no real use case.

Acked-by: Baoquan He <bhe@redhat.com>

> 
> Upstream a patch from the SONiC network operating system [1].
> 
> [1]: https://github.com/Azure/sonic-linux-kernel/pull/46
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
> ---
>  kernel/kexec_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
> index a0b6780740c8..f04d04d1b855 100644
> --- a/kernel/kexec_core.c
> +++ b/kernel/kexec_core.c
> @@ -1165,7 +1165,7 @@ int kernel_kexec(void)
>  #endif
>  	{
>  		kexec_in_progress = true;
> -		kernel_restart_prepare(NULL);
> +		kernel_restart_prepare("kexec reboot");
>  		migrate_to_reboot_cpu();
>  
>  		/*
> -- 
> 2.30.1
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2021-03-11  4:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 12:46 [PATCH] kexec: Add kexec reboot string Paul Menzel
2021-03-04 12:46 ` Paul Menzel
2021-03-11  4:09 ` Baoquan He [this message]
2021-03-11  4:09   ` Baoquan He
2021-03-11  5:32 ` Andrew Morton
2021-03-11  5:32   ` Andrew Morton
2021-03-11 18:14   ` [EXTERNAL] " Joe LeVeque
2021-03-11 18:14     ` Joe LeVeque
2021-03-11 20:53     ` Andrew Morton
2021-03-11 20:53       ` Andrew Morton
2021-03-11 21:07     ` Paul Menzel
2021-03-11 21:07       ` Paul Menzel
  -- strict thread matches above, loose matches on Subject: below --
2020-11-03 13:40 Paul Menzel
2020-11-03 13:40 ` Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311040949.GG2962@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=jolevequ@microsoft.com \
    --cc=kexec@lists.infradead.org \
    --cc=lguohan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.