All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Chaitanya.Kulkarni@wdc.com
Subject: Re: [PATCH 1/1] nvme-pci: add the DISABLE_WRITE_ZEROES quirk for a Samsung PM1725a
Date: Thu, 11 Mar 2021 11:47:12 +0100	[thread overview]
Message-ID: <20210311104712.GA16218@lst.de> (raw)
In-Reply-To: <20210310200030.GA3377333@dhcp-10-100-145-180.wdc.com>

On Wed, Mar 10, 2021 at 12:00:30PM -0800, Keith Busch wrote:
> On Wed, Mar 10, 2021 at 02:41:10PM +0100, Christoph Hellwig wrote:
> > On Wed, Mar 10, 2021 at 02:21:56PM +0100, Christoph Hellwig wrote:
> > > Can you try this patch instead?
> > > 
> > > http://lists.infradead.org/pipermail/linux-nvme/2021-February/023183.html
> > 
> > Actually, please try the patch below instead, it looks like our existing
> > logic messes up the units:
> 
> This seems like a good opportunity to incorporate TP4040 for non-MDTS
> command limits. I sent a proposal here
> 
>   http://lists.infradead.org/pipermail/linux-nvme/2021-March/023522.html
> 
> And it defaults to your suggestion if the controller doesn't implement
> the capability.

I think TP4040 is good and useful, but I defintively want the pure
fix get in first.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
	Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	Chaitanya.Kulkarni@wdc.com
Subject: Re: [PATCH 1/1] nvme-pci: add the DISABLE_WRITE_ZEROES quirk for a Samsung PM1725a
Date: Thu, 11 Mar 2021 11:47:12 +0100	[thread overview]
Message-ID: <20210311104712.GA16218@lst.de> (raw)
In-Reply-To: <20210310200030.GA3377333@dhcp-10-100-145-180.wdc.com>

On Wed, Mar 10, 2021 at 12:00:30PM -0800, Keith Busch wrote:
> On Wed, Mar 10, 2021 at 02:41:10PM +0100, Christoph Hellwig wrote:
> > On Wed, Mar 10, 2021 at 02:21:56PM +0100, Christoph Hellwig wrote:
> > > Can you try this patch instead?
> > > 
> > > http://lists.infradead.org/pipermail/linux-nvme/2021-February/023183.html
> > 
> > Actually, please try the patch below instead, it looks like our existing
> > logic messes up the units:
> 
> This seems like a good opportunity to incorporate TP4040 for non-MDTS
> command limits. I sent a proposal here
> 
>   http://lists.infradead.org/pipermail/linux-nvme/2021-March/023522.html
> 
> And it defaults to your suggestion if the controller doesn't implement
> the capability.

I think TP4040 is good and useful, but I defintively want the pure
fix get in first.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

  reply	other threads:[~2021-03-11 10:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1615377076-3251-1-git-send-email-dmtrmonakhov@yandex-team.ru>
2021-03-10 13:21 ` [PATCH 1/1] nvme-pci: add the DISABLE_WRITE_ZEROES quirk for a Samsung PM1725a Christoph Hellwig
2021-03-10 13:21   ` Christoph Hellwig
2021-03-10 13:41   ` Christoph Hellwig
2021-03-10 13:41     ` Christoph Hellwig
2021-03-10 20:00     ` Keith Busch
2021-03-10 20:00       ` Keith Busch
2021-03-11 10:47       ` Christoph Hellwig [this message]
2021-03-11 10:47         ` Christoph Hellwig
     [not found]         ` <CGME20210323083750eucas1p14d21230ac758194d854ca336caf7f3f2@eucas1p1.samsung.com>
2021-03-23  8:37           ` Javier González
2021-03-23  8:37             ` Javier González
2021-03-23 12:31             ` Christoph Hellwig
2021-03-23 12:31               ` Christoph Hellwig
2021-03-23 12:43               ` Javier González
2021-03-23 12:43                 ` Javier González
2021-04-08 10:30                 ` Javier González
2021-04-08 10:30                   ` Javier González
2021-04-08 12:15                   ` Christoph Hellwig
2021-04-08 12:15                     ` Christoph Hellwig
2021-04-08 18:15                     ` Javier González
2021-04-08 18:15                       ` Javier González
2021-03-11 10:28     ` Dmitry Monakhov
2021-03-11 10:28       ` Dmitry Monakhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210311104712.GA16218@lst.de \
    --to=hch@lst.de \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=dmtrmonakhov@yandex-team.ru \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.