[PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static

[PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static

['Wei Yongjun]

From: Wei Yongjun <weiyongjun1@huawei.com>

The sparse tool complains as follows:

drivers/mfd/atc260x-i2c.c:45:27: warning:
 symbol 'atc260x_i2c_of_match' was not declared. Should it be static?

This symbol is not used outside of atc260x-i2c.c, so this
commit marks it static.

Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/mfd/atc260x-i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/atc260x-i2c.c b/drivers/mfd/atc260x-i2c.c
index 362005703367..5855efd09efc 100644
--- a/drivers/mfd/atc260x-i2c.c
+++ b/drivers/mfd/atc260x-i2c.c
@@ -42,7 +42,7 @@ static int atc260x_i2c_probe(struct i2c_client *client,
 	return atc260x_device_probe(atc260x);
 }
 
-const struct of_device_id atc260x_i2c_of_match[] = {
+static const struct of_device_id atc260x_i2c_of_match[] = {
 	{ .compatible = "actions,atc2603c", .data = (void *)ATC2603C },
 	{ .compatible = "actions,atc2609a", .data = (void *)ATC2609A },
 	{ }

Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static

[Cristian Ciocaltea]

On Thu, Mar 11, 2021 at 01:15:07PM +0000, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> The sparse tool complains as follows:
> 
> drivers/mfd/atc260x-i2c.c:45:27: warning:
>  symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
> 
> This symbol is not used outside of atc260x-i2c.c, so this
> commit marks it static.
> 
> Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Reviewed-by: Cristian Ciocaltea <cristian.ciocaltea@gmail.com>

Thanks,
Cristi

> ---
>  drivers/mfd/atc260x-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/atc260x-i2c.c b/drivers/mfd/atc260x-i2c.c
> index 362005703367..5855efd09efc 100644
> --- a/drivers/mfd/atc260x-i2c.c
> +++ b/drivers/mfd/atc260x-i2c.c
> @@ -42,7 +42,7 @@ static int atc260x_i2c_probe(struct i2c_client *client,
>  	return atc260x_device_probe(atc260x);
>  }
>  
> -const struct of_device_id atc260x_i2c_of_match[] = {
> +static const struct of_device_id atc260x_i2c_of_match[] = {
>  	{ .compatible = "actions,atc2603c", .data = (void *)ATC2603C },
>  	{ .compatible = "actions,atc2609a", .data = (void *)ATC2609A },
>  	{ }
> 

Re: [PATCH -next] mfd: Make symbol 'atc260x_i2c_of_match' static

[Lee Jones]

On Thu, 11 Mar 2021, 'Wei Yongjun wrote:

> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> The sparse tool complains as follows:
> 
> drivers/mfd/atc260x-i2c.c:45:27: warning:
>  symbol 'atc260x_i2c_of_match' was not declared. Should it be static?
> 
> This symbol is not used outside of atc260x-i2c.c, so this
> commit marks it static.
> 
> Fixes: f7cb7fe34db9 ("mfd: Add MFD driver for ATC260x PMICs")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/mfd/atc260x-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog