All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org,
	"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>
Subject: [PATCH 17/23] ASoC: sigmadsp: align function prototype
Date: Fri, 12 Mar 2021 12:22:40 -0600	[thread overview]
Message-ID: <20210312182246.5153-18-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com>

cppcheck warning:

sound/soc/codecs/sigmadsp.c:736:60: style:inconclusive: Function
'sigmadsp_setup' argument 2 names different: declaration 'rate'
definition 'samplerate'. [funcArgNamesDifferent]
int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int samplerate)
                                                           ^

sound/soc/codecs/sigmadsp.h:62:60: note: Function 'sigmadsp_setup'
argument 2 names different: declaration 'rate' definition
'samplerate'.
int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int rate);
                                                           ^

sound/soc/codecs/sigmadsp.c:736:60: note: Function 'sigmadsp_setup'
argument 2 names different: declaration 'rate' definition
'samplerate'.
int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int samplerate)
                                                           ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/sigmadsp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sigmadsp.h b/sound/soc/codecs/sigmadsp.h
index e3c9656e006d..d63b8c366efb 100644
--- a/sound/soc/codecs/sigmadsp.h
+++ b/sound/soc/codecs/sigmadsp.h
@@ -59,7 +59,7 @@ struct sigmadsp *devm_sigmadsp_init_i2c(struct i2c_client *client,
 
 int sigmadsp_attach(struct sigmadsp *sigmadsp,
 	struct snd_soc_component *component);
-int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int rate);
+int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int samplerate);
 void sigmadsp_reset(struct sigmadsp *sigmadsp);
 
 #endif
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: "Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	tiwai@suse.de, "Takashi Iwai" <tiwai@suse.com>,
	linux-kernel@vger.kernel.org, "Nuno Sá" <nuno.sa@analog.com>,
	broonie@kernel.org
Subject: [PATCH 17/23] ASoC: sigmadsp: align function prototype
Date: Fri, 12 Mar 2021 12:22:40 -0600	[thread overview]
Message-ID: <20210312182246.5153-18-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210312182246.5153-1-pierre-louis.bossart@linux.intel.com>

cppcheck warning:

sound/soc/codecs/sigmadsp.c:736:60: style:inconclusive: Function
'sigmadsp_setup' argument 2 names different: declaration 'rate'
definition 'samplerate'. [funcArgNamesDifferent]
int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int samplerate)
                                                           ^

sound/soc/codecs/sigmadsp.h:62:60: note: Function 'sigmadsp_setup'
argument 2 names different: declaration 'rate' definition
'samplerate'.
int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int rate);
                                                           ^

sound/soc/codecs/sigmadsp.c:736:60: note: Function 'sigmadsp_setup'
argument 2 names different: declaration 'rate' definition
'samplerate'.
int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int samplerate)
                                                           ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/soc/codecs/sigmadsp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/sigmadsp.h b/sound/soc/codecs/sigmadsp.h
index e3c9656e006d..d63b8c366efb 100644
--- a/sound/soc/codecs/sigmadsp.h
+++ b/sound/soc/codecs/sigmadsp.h
@@ -59,7 +59,7 @@ struct sigmadsp *devm_sigmadsp_init_i2c(struct i2c_client *client,
 
 int sigmadsp_attach(struct sigmadsp *sigmadsp,
 	struct snd_soc_component *component);
-int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int rate);
+int sigmadsp_setup(struct sigmadsp *sigmadsp, unsigned int samplerate);
 void sigmadsp_reset(struct sigmadsp *sigmadsp);
 
 #endif
-- 
2.25.1


  parent reply	other threads:[~2021-03-12 18:24 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12 18:22 [PATCH 00/23] ASoC: codecs: remove cppcheck warnings Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 01/23] ASoC: ab8500-codec: remove useless structure Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 02/23] ASoC: ad1836: remove useless return Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:50   ` Lars-Peter Clausen
2021-03-12 18:50     ` Lars-Peter Clausen
2021-03-12 18:22 ` [PATCH 03/23] ASoC: adau1977: " Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 04/23] ASoC: cros_ec_codec: remove null pointer dereference warning Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-15 10:39   ` Enric Balletbo i Serra
2021-03-15 10:39     ` Enric Balletbo i Serra
2021-03-12 18:22 ` [PATCH 05/23] ASoC: cx2070x: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-14  8:30   ` Takashi Iwai
2021-03-14  8:30     ` Takashi Iwai
2021-03-14  8:30   ` Takashi Iwai
2021-03-14  8:30     ` Takashi Iwai
2021-03-12 18:22 ` [PATCH 06/23] ASoC: cx2070x: remove duplicate else branch Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-14  8:32   ` Takashi Iwai
2021-03-14  8:32     ` Takashi Iwai
2021-03-12 18:22 ` [PATCH 07/23] ASoC: da7219-aad: remove useless initialization Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-15 14:50   ` Adam Thomson
2021-03-15 14:50     ` Adam Thomson
2021-03-12 18:22 ` [PATCH 08/23] ASoC: hdac_hdmi: remove useless initializations Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 09/23] ASoC: hdac_hdmi: align function arguments Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 10/23] ASoC: hdmi-codec: remove useless initialization Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 11/23] ASoC: hdmi-codec: remove unused spk_mask member Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 12/23] ASoC: max98090: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 13/23] ASoC: mt6358: remove useless initializations Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 14/23] ASoC: mt6359: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 15/23] ASoC: nau8825: " Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 16/23] ASoC: pcm1681: " Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` Pierre-Louis Bossart [this message]
2021-03-12 18:22   ` [PATCH 17/23] ASoC: sigmadsp: align function prototype Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 18/23] ASoC: sti-sas: remove unused struct members Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 19/23] ASoC: tas2562: remove useless assignment Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 20/23] ASoC: tas2562: remove warning on return value Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 21/23] ASoC: tas2770: remove useless initialization Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 22/23] ASoC: tlv320dac33: clarify expression Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-12 18:22 ` [PATCH 23/23] ASoC: tscs454: remove useless test on PLL disable Pierre-Louis Bossart
2021-03-12 18:22   ` Pierre-Louis Bossart
2021-03-18 18:33 ` [PATCH 00/23] ASoC: codecs: remove cppcheck warnings Mark Brown
2021-03-18 18:36   ` Mark Brown
2021-03-18 18:36   ` Mark Brown
2021-03-18 18:33   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210312182246.5153-18-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lars@metafoo.de \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.