* [PATCH] staging: andriod: ashmem: Declared file operation with const keyword
@ 2021-03-13 17:26 ` namratajanawade
0 siblings, 0 replies; 6+ messages in thread
From: namratajanawade @ 2021-03-13 17:26 UTC (permalink / raw)
Cc: namrata.janawade, anupamakpatil123, bkkarthik,
Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Hridya Valsaraju, Suren Baghdasaryan, devel, linux-kernel
Warning found by checkpatch.pl script.
Signed-off-by: namratajanawade <namrata.janawade@gmail.com>
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..7854fd410efa 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: andriod: ashmem: Declared file operation with const keyword
@ 2021-03-13 17:26 ` namratajanawade
0 siblings, 0 replies; 6+ messages in thread
From: namratajanawade @ 2021-03-13 17:26 UTC (permalink / raw)
Cc: namrata.janawade, devel, Todd Kjos, anupamakpatil123, bkkarthik,
linux-kernel, Suren Baghdasaryan, Hridya Valsaraju,
Arve Hjønnevåg, Greg Kroah-Hartman, Joel Fernandes,
Martijn Coenen, Christian Brauner
Warning found by checkpatch.pl script.
Signed-off-by: namratajanawade <namrata.janawade@gmail.com>
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index d66a64e42273..7854fd410efa 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -376,7 +376,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.25.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword
2021-03-13 17:26 ` namratajanawade
@ 2021-03-13 17:29 ` B K Karthik
-1 siblings, 0 replies; 6+ messages in thread
From: B K Karthik @ 2021-03-13 17:29 UTC (permalink / raw)
To: namratajanawade
Cc: anupamakpatil123, Greg Kroah-Hartman, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
Hridya Valsaraju, Suren Baghdasaryan, devel, LKML
On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
<namrata.janawade@gmail.com> wrote:
>
> Warning found by checkpatch.pl script.
That doesn't tell what you did or why you did it. Please write an
appropriate commit description and resend the patch.
karthik
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword
@ 2021-03-13 17:29 ` B K Karthik
0 siblings, 0 replies; 6+ messages in thread
From: B K Karthik @ 2021-03-13 17:29 UTC (permalink / raw)
To: namratajanawade
Cc: devel, Todd Kjos, anupamakpatil123, LKML, Suren Baghdasaryan,
Hridya Valsaraju, Arve Hjønnevåg, Greg Kroah-Hartman,
Joel Fernandes, Martijn Coenen, Christian Brauner
On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
<namrata.janawade@gmail.com> wrote:
>
> Warning found by checkpatch.pl script.
That doesn't tell what you did or why you did it. Please write an
appropriate commit description and resend the patch.
karthik
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword
2021-03-13 17:29 ` B K Karthik
@ 2021-03-13 22:42 ` Nathan Chancellor
-1 siblings, 0 replies; 6+ messages in thread
From: Nathan Chancellor @ 2021-03-13 22:42 UTC (permalink / raw)
To: B K Karthik
Cc: namratajanawade, anupamakpatil123, Greg Kroah-Hartman,
Arve Hjønnevåg, Todd Kjos, Martijn Coenen,
Joel Fernandes, Christian Brauner, Hridya Valsaraju,
Suren Baghdasaryan, devel, LKML
On Sat, Mar 13, 2021 at 10:59:43PM +0530, B K Karthik wrote:
> On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
> <namrata.janawade@gmail.com> wrote:
> >
> > Warning found by checkpatch.pl script.
>
> That doesn't tell what you did or why you did it. Please write an
> appropriate commit description and resend the patch.
>
> karthik
This patch will not even build, it has been sent several times before...
https://lore.kernel.org/r/20201016051111.1947-1-kirank.suren@gmail.com/
https://lore.kernel.org/r/20200328151523.17516-1-sandeshkenjanaashok@gmail.com/
https://lore.kernel.org/r/20201128121627.GA27317@worker-node1/
https://lore.kernel.org/r/20201227112645.256943-1-senguptaangshuman17@gmail.com/
https://lore.kernel.org/r/20201228051301.14983-1-jovin555@gmail.com/
https://lore.kernel.org/r/20210214023136.8916-1-thaiscamachoo@gmail.com/
https://lore.kernel.org/r/20210219101338.2670-1-amritkhera98@gmail.com/
https://lore.kernel.org/r/20210306063817.674041-1-nabil.ibn.mahmud@gmail.com/
I once considered adding a comment above it saying that it should not be
marked const but it is a good benchmark for seeing if people compile
their patches before sending them out.
Cheers,
Nathan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: andriod: ashmem: Declared file operation with const keyword
@ 2021-03-13 22:42 ` Nathan Chancellor
0 siblings, 0 replies; 6+ messages in thread
From: Nathan Chancellor @ 2021-03-13 22:42 UTC (permalink / raw)
To: B K Karthik
Cc: namratajanawade, devel, Todd Kjos, anupamakpatil123, LKML,
Suren Baghdasaryan, Hridya Valsaraju, Arve Hjønnevåg,
Greg Kroah-Hartman, Joel Fernandes, Martijn Coenen,
Christian Brauner
On Sat, Mar 13, 2021 at 10:59:43PM +0530, B K Karthik wrote:
> On Sat, Mar 13, 2021 at 10:57 PM namratajanawade
> <namrata.janawade@gmail.com> wrote:
> >
> > Warning found by checkpatch.pl script.
>
> That doesn't tell what you did or why you did it. Please write an
> appropriate commit description and resend the patch.
>
> karthik
This patch will not even build, it has been sent several times before...
https://lore.kernel.org/r/20201016051111.1947-1-kirank.suren@gmail.com/
https://lore.kernel.org/r/20200328151523.17516-1-sandeshkenjanaashok@gmail.com/
https://lore.kernel.org/r/20201128121627.GA27317@worker-node1/
https://lore.kernel.org/r/20201227112645.256943-1-senguptaangshuman17@gmail.com/
https://lore.kernel.org/r/20201228051301.14983-1-jovin555@gmail.com/
https://lore.kernel.org/r/20210214023136.8916-1-thaiscamachoo@gmail.com/
https://lore.kernel.org/r/20210219101338.2670-1-amritkhera98@gmail.com/
https://lore.kernel.org/r/20210306063817.674041-1-nabil.ibn.mahmud@gmail.com/
I once considered adding a comment above it saying that it should not be
marked const but it is a good benchmark for seeing if people compile
their patches before sending them out.
Cheers,
Nathan
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-03-13 22:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-13 17:26 [PATCH] staging: andriod: ashmem: Declared file operation with const keyword namratajanawade
2021-03-13 17:26 ` namratajanawade
2021-03-13 17:29 ` B K Karthik
2021-03-13 17:29 ` B K Karthik
2021-03-13 22:42 ` Nathan Chancellor
2021-03-13 22:42 ` Nathan Chancellor
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.