From: Christoph Hellwig <hch@infradead.org>
To: Sergei Shtepa <sergei.shtepa@veeam.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Mike Snitzer <snitzer@redhat.com>,
Alasdair Kergon <agk@redhat.com>, Hannes Reinecke <hare@suse.de>,
Jens Axboe <axboe@kernel.dk>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
pavel.tide@veeam.com
Subject: Re: [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG
Date: Sun, 14 Mar 2021 09:30:38 +0000 [thread overview]
Message-ID: <20210314093038.GC3773360@infradead.org> (raw)
In-Reply-To: <1615563895-28565-4-git-send-email-sergei.shtepa@veeam.com>
On Fri, Mar 12, 2021 at 06:44:55PM +0300, Sergei Shtepa wrote:
> DM_INTERPOSED_FLAG allow to create DM targets on "the fly".
> Underlying block device opens without a flag FMODE_EXCL.
> DM target receives bio from the original device via
> bdev_interposer.
This is more of a philopical comment, but the idea of just letting the
interposed reopen the device by itself seems like a bad idea. I think
that is probably better hidden in the block layer interposer attachment
function, which could do the extra blkdev_get_by_dev for the caller.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Sergei Shtepa <sergei.shtepa@veeam.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Mike Snitzer <snitzer@redhat.com>,
linux-api@vger.kernel.org, pavel.tide@veeam.com,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
dm-devel@redhat.com, Alasdair Kergon <agk@redhat.com>
Subject: Re: [dm-devel] [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG
Date: Sun, 14 Mar 2021 09:30:38 +0000 [thread overview]
Message-ID: <20210314093038.GC3773360@infradead.org> (raw)
In-Reply-To: <1615563895-28565-4-git-send-email-sergei.shtepa@veeam.com>
On Fri, Mar 12, 2021 at 06:44:55PM +0300, Sergei Shtepa wrote:
> DM_INTERPOSED_FLAG allow to create DM targets on "the fly".
> Underlying block device opens without a flag FMODE_EXCL.
> DM target receives bio from the original device via
> bdev_interposer.
This is more of a philopical comment, but the idea of just letting the
interposed reopen the device by itself seems like a bad idea. I think
that is probably better hidden in the block layer interposer attachment
function, which could do the extra blkdev_get_by_dev for the caller.
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-14 9:31 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 15:44 [PATCH v7 0/3] block device interposer Sergei Shtepa
2021-03-12 15:44 ` [dm-devel] " Sergei Shtepa
2021-03-12 15:44 ` [PATCH v7 1/3] block: add blk_mq_is_queue_frozen() Sergei Shtepa
2021-03-12 15:44 ` [dm-devel] " Sergei Shtepa
2021-03-12 19:06 ` Mike Snitzer
2021-03-12 19:06 ` [dm-devel] " Mike Snitzer
2021-03-14 9:14 ` Christoph Hellwig
2021-03-14 9:14 ` [dm-devel] " Christoph Hellwig
2021-03-15 12:06 ` Sergei Shtepa
2021-03-15 12:06 ` [dm-devel] " Sergei Shtepa
2021-03-12 15:44 ` [PATCH v7 2/3] block: add bdev_interposer Sergei Shtepa
2021-03-12 15:44 ` [dm-devel] " Sergei Shtepa
2021-03-14 9:28 ` Christoph Hellwig
2021-03-14 9:28 ` [dm-devel] " Christoph Hellwig
2021-03-15 13:06 ` Sergei Shtepa
2021-03-15 13:06 ` [dm-devel] " Sergei Shtepa
2021-03-16 8:09 ` Ming Lei
2021-03-16 8:09 ` [dm-devel] " Ming Lei
2021-03-16 16:35 ` Sergei Shtepa
2021-03-16 16:35 ` [dm-devel] " Sergei Shtepa
2021-03-17 3:03 ` Ming Lei
2021-03-17 3:03 ` [dm-devel] " Ming Lei
2021-03-17 12:22 ` Sergei Shtepa
2021-03-17 12:22 ` [dm-devel] " Sergei Shtepa
2021-03-17 15:04 ` Mike Snitzer
2021-03-17 15:04 ` [dm-devel] " Mike Snitzer
2021-03-17 18:14 ` Sergei Shtepa
2021-03-17 18:14 ` [dm-devel] " Sergei Shtepa
2021-03-17 19:13 ` Mike Snitzer
2021-03-17 19:13 ` [dm-devel] " Mike Snitzer
2021-03-18 14:56 ` Sergei Shtepa
2021-03-18 14:56 ` [dm-devel] " Sergei Shtepa
2021-03-17 14:58 ` Mike Snitzer
2021-03-17 14:58 ` [dm-devel] " Mike Snitzer
2021-03-12 15:44 ` [PATCH v7 3/3] dm: add DM_INTERPOSED_FLAG Sergei Shtepa
2021-03-12 15:44 ` [dm-devel] " Sergei Shtepa
2021-03-12 19:00 ` Mike Snitzer
2021-03-12 19:00 ` [dm-devel] " Mike Snitzer
2021-03-15 12:29 ` Sergei Shtepa
2021-03-15 12:29 ` [dm-devel] " Sergei Shtepa
2021-03-14 9:30 ` Christoph Hellwig [this message]
2021-03-14 9:30 ` Christoph Hellwig
2021-03-15 13:25 ` Sergei Shtepa
2021-03-15 13:25 ` [dm-devel] " Sergei Shtepa
2021-03-16 15:23 ` Christoph Hellwig
2021-03-16 15:23 ` [dm-devel] " Christoph Hellwig
2021-03-16 15:25 ` Christoph Hellwig
2021-03-16 15:25 ` [dm-devel] " Christoph Hellwig
2021-03-16 16:20 ` Sergei Shtepa
2021-03-16 16:20 ` [dm-devel] " Sergei Shtepa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210314093038.GC3773360@infradead.org \
--to=hch@infradead.org \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hare@suse.de \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel.tide@veeam.com \
--cc=sergei.shtepa@veeam.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.