All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Alistair Popple <apopple@nvidia.com>
Cc: linux-mm@kvack.org, nouveau@lists.freedesktop.org,
	bskeggs@redhat.com, akpm@linux-foundation.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	kvm-ppc@vger.kernel.org, dri-devel@lists.freedesktop.org,
	jhubbard@nvidia.com, rcampbell@nvidia.com, jglisse@redhat.com,
	jgg@nvidia.com, hch@infradead.org, daniel@ffwll.ch,
	willy@infradead.org
Subject: Re: [PATCH v6 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Mon, 15 Mar 2021 07:28:56 +0000	[thread overview]
Message-ID: <20210315072856.GB4136862@infradead.org> (raw)
In-Reply-To: <20210312083851.15981-4-apopple@nvidia.com>

On Fri, Mar 12, 2021 at 07:38:46PM +1100, Alistair Popple wrote:
> The behaviour of try_to_unmap_one() is difficult to follow because it
> performs different operations based on a fairly large set of flags used
> in different combinations.
> 
> TTU_MUNLOCK is one such flag. However it is exclusively used by
> try_to_munlock() which specifies no other flags. Therefore rather than
> overload try_to_unmap_one() with unrelated behaviour split this out into
> it's own function and remove the flag.
> 
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> 
> ---
> 
> Christoph - I didn't add your Reviewed-by from v3 because removal of the
> extra VM_LOCKED check in v4 changed things slightly. Let me know if
> you're still ok for me to add it. Thanks.

Still looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Alistair Popple <apopple@nvidia.com>
Cc: rcampbell@nvidia.com, willy@infradead.org, daniel@ffwll.ch,
	linux-doc@vger.kernel.org, nouveau@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	kvm-ppc@vger.kernel.org, hch@infradead.org, linux-mm@kvack.org,
	bskeggs@redhat.com, jgg@nvidia.com, akpm@linux-foundation.org
Subject: Re: [Nouveau] [PATCH v6 3/8] mm/rmap: Split try_to_munlock from try_to_unmap
Date: Mon, 15 Mar 2021 07:28:56 +0000	[thread overview]
Message-ID: <20210315072856.GB4136862@infradead.org> (raw)
In-Reply-To: <20210312083851.15981-4-apopple@nvidia.com>

On Fri, Mar 12, 2021 at 07:38:46PM +1100, Alistair Popple wrote:
> The behaviour of try_to_unmap_one() is difficult to follow because it
> performs different operations based on a fairly large set of flags used
> in different combinations.
> 
> TTU_MUNLOCK is one such flag. However it is exclusively used by
> try_to_munlock() which specifies no other flags. Therefore rather than
> overload try_to_unmap_one() with unrelated behaviour split this out into
> it's own function and remove the flag.
> 
> Signed-off-by: Alistair Popple <apopple@nvidia.com>
> Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
> 
> ---
> 
> Christoph - I didn't add your Reviewed-by from v3 because removal of the
> extra VM_LOCKED check in v4 changed things slightly. Let me know if
> you're still ok for me to add it. Thanks.

Still looks good to me:

Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau

  reply	other threads:[~2021-03-15  7:30 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-12  8:38 [PATCH v6 0/8] Add support for SVM atomics in Nouveau Alistair Popple
2021-03-12  8:38 ` Alistair Popple
2021-03-12  8:38 ` Alistair Popple
2021-03-12  8:38 ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 1/8] mm: Remove special swap entry functions Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-15  7:27   ` Christoph Hellwig
2021-03-15  7:27     ` [Nouveau] " Christoph Hellwig
2021-03-22  9:20     ` Alistair Popple
2021-03-22  9:20       ` Alistair Popple
2021-03-22  9:20       ` Alistair Popple
2021-03-22  9:20       ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 2/8] mm/swapops: Rework swap entry manipulation code Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 3/8] mm/rmap: Split try_to_munlock from try_to_unmap Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-15  7:28   ` Christoph Hellwig [this message]
2021-03-15  7:28     ` Christoph Hellwig
2021-03-12  8:38 ` [PATCH v6 4/8] mm/rmap: Split migration into its own function Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 5/8] mm: Device exclusive memory access Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-15  7:42   ` Christoph Hellwig
2021-03-15  7:42     ` [Nouveau] " Christoph Hellwig
2021-03-22 10:27     ` Alistair Popple
2021-03-22 10:27       ` Alistair Popple
2021-03-22 10:27       ` Alistair Popple
2021-03-22 10:27       ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 6/8] mm: Selftests for exclusive device memory Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 7/8] nouveau/svm: Refactor nouveau_range_fault Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-12  8:38 ` [PATCH v6 8/8] nouveau/svm: Implement atomic SVM access Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` Alistair Popple
2021-03-12  8:38   ` [Nouveau] " Alistair Popple
2021-03-15  7:51   ` Christoph Hellwig
2021-03-15  7:51     ` Christoph Hellwig
2021-03-15  7:51     ` [Nouveau] " Christoph Hellwig
2021-03-22  9:27     ` Alistair Popple
2021-03-22  9:27       ` Alistair Popple
2021-03-22  9:27       ` Alistair Popple
2021-03-22  9:27       ` [Nouveau] " Alistair Popple

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315072856.GB4136862@infradead.org \
    --to=hch@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=apopple@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jgg@nvidia.com \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=rcampbell@nvidia.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.