All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Lee Jones" <lee.jones@linaro.org>,
	"Michael Walle" <michael@walle.cc>,
	"Álvaro Fernández Rojas" <noltari@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Necip Fazil Yildiran" <fazilyildiran@gmail.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v7 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP
Date: Mon, 15 Mar 2021 12:41:53 +0100	[thread overview]
Message-ID: <20210315114214.3096-2-noltari@gmail.com> (raw)
In-Reply-To: <20210315114214.3096-1-noltari@gmail.com>

The current code doesn't check if GPIOLIB_IRQCHIP is enabled, which results in
a compilation error when trying to build gpio-regmap if CONFIG_GPIOLIB_IRQCHIP
isn't enabled.

Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()")
Suggested-by: Michael Walle <michael@walle.cc>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Michael Walle <michael@walle.cc>
---
 v7: no changes
 v5: add missing Suggested-by tag
 v4: add patch (fix include instead of gpio-regmap.c)

 include/linux/gpio/driver.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 286de0520574..ecf0032a0995 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -624,8 +624,17 @@ void gpiochip_irq_domain_deactivate(struct irq_domain *domain,
 bool gpiochip_irqchip_irq_valid(const struct gpio_chip *gc,
 				unsigned int offset);
 
+#ifdef CONFIG_GPIOLIB_IRQCHIP
 int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
 				struct irq_domain *domain);
+#else
+static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
+					      struct irq_domain *domain)
+{
+	WARN_ON(1);
+	return -EINVAL;
+}
+#endif
 
 int gpiochip_generic_request(struct gpio_chip *gc, unsigned int offset);
 void gpiochip_generic_free(struct gpio_chip *gc, unsigned int offset);
-- 
2.20.1


WARNING: multiple messages have this Message-ID (diff)
From: "Álvaro Fernández Rojas" <noltari@gmail.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	"Lee Jones" <lee.jones@linaro.org>,
	"Michael Walle" <michael@walle.cc>,
	"Álvaro Fernández Rojas" <noltari@gmail.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Necip Fazil Yildiran" <fazilyildiran@gmail.com>,
	"Andy Shevchenko" <andy.shevchenko@gmail.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v7 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP
Date: Mon, 15 Mar 2021 12:41:53 +0100	[thread overview]
Message-ID: <20210315114214.3096-2-noltari@gmail.com> (raw)
In-Reply-To: <20210315114214.3096-1-noltari@gmail.com>

The current code doesn't check if GPIOLIB_IRQCHIP is enabled, which results in
a compilation error when trying to build gpio-regmap if CONFIG_GPIOLIB_IRQCHIP
isn't enabled.

Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()")
Suggested-by: Michael Walle <michael@walle.cc>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Michael Walle <michael@walle.cc>
---
 v7: no changes
 v5: add missing Suggested-by tag
 v4: add patch (fix include instead of gpio-regmap.c)

 include/linux/gpio/driver.h | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/include/linux/gpio/driver.h b/include/linux/gpio/driver.h
index 286de0520574..ecf0032a0995 100644
--- a/include/linux/gpio/driver.h
+++ b/include/linux/gpio/driver.h
@@ -624,8 +624,17 @@ void gpiochip_irq_domain_deactivate(struct irq_domain *domain,
 bool gpiochip_irqchip_irq_valid(const struct gpio_chip *gc,
 				unsigned int offset);
 
+#ifdef CONFIG_GPIOLIB_IRQCHIP
 int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
 				struct irq_domain *domain);
+#else
+static inline int gpiochip_irqchip_add_domain(struct gpio_chip *gc,
+					      struct irq_domain *domain)
+{
+	WARN_ON(1);
+	return -EINVAL;
+}
+#endif
 
 int gpiochip_generic_request(struct gpio_chip *gc, unsigned int offset);
 void gpiochip_generic_free(struct gpio_chip *gc, unsigned int offset);
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-03-15 11:43 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-15 11:41 [PATCH v7 00/22] pinctrl: add BCM63XX pincontrol support Álvaro Fernández Rojas
2021-03-15 11:41 ` Álvaro Fernández Rojas
2021-03-15 11:41 ` Álvaro Fernández Rojas [this message]
2021-03-15 11:41   ` [PATCH v7 01/22] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP Álvaro Fernández Rojas
2021-03-15 11:41 ` [PATCH v7 02/22] gpio: regmap: set gpio_chip of_node Álvaro Fernández Rojas
2021-03-15 11:41   ` Álvaro Fernández Rojas
2021-03-15 11:41 ` [PATCH v7 03/22] dt-bindings: add BCM63XX GPIO binding documentation Álvaro Fernández Rojas
2021-03-15 11:41   ` Álvaro Fernández Rojas
2021-03-16 20:54   ` Rob Herring
2021-03-16 20:54     ` Rob Herring
2021-03-17 10:46     ` Álvaro Fernández Rojas
2021-03-17 10:46       ` Álvaro Fernández Rojas
2021-03-15 11:41 ` [PATCH v7 04/22] pinctrl: bcm: add bcm63xx base code Álvaro Fernández Rojas
2021-03-15 11:41   ` Álvaro Fernández Rojas
2021-03-15 11:41 ` [PATCH v7 05/22] dt-bindings: add BCM6328 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-15 11:41   ` Álvaro Fernández Rojas
2021-03-16 20:59   ` Rob Herring
2021-03-16 20:59     ` Rob Herring
2021-03-17 12:54     ` Álvaro Fernández Rojas
2021-03-17 12:54       ` Álvaro Fernández Rojas
2021-03-15 11:41 ` [PATCH v7 06/22] dt-bindings: add BCM6328 GPIO sysctl " Álvaro Fernández Rojas
2021-03-15 11:41   ` Álvaro Fernández Rojas
2021-03-15 11:41 ` [PATCH v7 07/22] pinctrl: add a pincontrol driver for BCM6328 Álvaro Fernández Rojas
2021-03-15 11:41   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 08/22] dt-bindings: add BCM6358 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 09/22] dt-bindings: add BCM6358 GPIO sysctl " Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 10/22] pinctrl: add a pincontrol driver for BCM6358 Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 11/22] dt-bindings: add BCM6362 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 12/22] dt-bindings: add BCM6362 GPIO sysctl " Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 13/22] pinctrl: add a pincontrol driver for BCM6362 Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 14/22] dt-bindings: add BCM6368 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 15/22] dt-bindings: add BCM6368 GPIO sysctl " Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 16/22] pinctrl: add a pincontrol driver for BCM6368 Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 17/22] dt-bindings: add BCM63268 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 18/22] dt-bindings: add BCM63268 GPIO sysctl " Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 19/22] pinctrl: add a pincontrol driver for BCM63268 Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 20/22] dt-bindings: add BCM6318 pincontroller binding documentation Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 21/22] dt-bindings: add BCM6318 GPIO sysctl " Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-16 21:20   ` Rob Herring
2021-03-16 21:20     ` Rob Herring
2021-03-17 10:48     ` Álvaro Fernández Rojas
2021-03-17 10:48       ` Álvaro Fernández Rojas
2021-03-15 11:42 ` [PATCH v7 22/22] pinctrl: add a pincontrol driver for BCM6318 Álvaro Fernández Rojas
2021-03-15 11:42   ` Álvaro Fernández Rojas
2021-03-16 10:13 ` [PATCH v7 00/22] pinctrl: add BCM63XX pincontrol support Linus Walleij
2021-03-16 10:13   ` Linus Walleij
2021-03-17 11:20   ` Álvaro Fernández Rojas
2021-03-17 11:20     ` Álvaro Fernández Rojas
2021-03-20 11:38     ` Linus Walleij
2021-03-20 11:38       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210315114214.3096-2-noltari@gmail.com \
    --to=noltari@gmail.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=fazilyildiran@gmail.com \
    --cc=jonas.gorski@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.