From: Jakub Kicinski <kuba@kernel.org> To: Ong Boon Leong <boon.leong.ong@intel.com> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support Date: Mon, 15 Mar 2021 12:50:59 -0700 [thread overview] Message-ID: <20210315125059.32fde79a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw) In-Reply-To: <20210315064448.16391-2-boon.leong.ong@intel.com> On Mon, 15 Mar 2021 14:44:48 +0800 Ong Boon Leong wrote: > Extending the driver to support per-queue RX and TX coalesce settings in > order to support below commands: > > To show per-queue coalesce setting:- > $ ethtool --per-queue <DEVNAME> queue_mask <MASK> --show-coalesce > > To set per-queue coalesce setting:- > $ ethtool --per-queue <DEVNAME> queue_mask <MASK> --coalesce \ > [rx-usecs N] [rx-frames M] [tx-usecs P] [tx-frames Q] > > Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com> > -static int stmmac_get_coalesce(struct net_device *dev, > - struct ethtool_coalesce *ec) > +static int __stmmac_get_coalesce(struct net_device *dev, > + struct ethtool_coalesce *ec, > + int queue) > { > struct stmmac_priv *priv = netdev_priv(dev); > + u32 max_cnt; > + u32 rx_cnt; > + u32 tx_cnt; > > - ec->tx_coalesce_usecs = priv->tx_coal_timer; > - ec->tx_max_coalesced_frames = priv->tx_coal_frames; > + rx_cnt = priv->plat->rx_queues_to_use; > + tx_cnt = priv->plat->tx_queues_to_use; > + max_cnt = max(rx_cnt, tx_cnt); > > - if (priv->use_riwt) { > - ec->rx_max_coalesced_frames = priv->rx_coal_frames; > - ec->rx_coalesce_usecs = stmmac_riwt2usec(priv->rx_riwt, priv); > + if (queue < 0) > + queue = 0; > + else if (queue >= max_cnt) > + return -EINVAL; > + > + if (queue < tx_cnt) { > + ec->tx_coalesce_usecs = priv->tx_coal_timer[queue]; > + ec->tx_max_coalesced_frames = priv->tx_coal_frames[queue]; > + } else { > + ec->tx_coalesce_usecs = -1; > + ec->tx_max_coalesced_frames = -1; > + } > + > + if (priv->use_riwt && queue < rx_cnt) { > + ec->rx_max_coalesced_frames = priv->rx_coal_frames[queue]; > + ec->rx_coalesce_usecs = stmmac_riwt2usec(priv->rx_riwt[queue], > + priv); > + } else { > + ec->rx_max_coalesced_frames = -1; > + ec->rx_coalesce_usecs = -1; Why the use of negative values? why not leave them as 0? > } > > return 0; > } > > -static int stmmac_set_coalesce(struct net_device *dev, > +static int stmmac_get_coalesce(struct net_device *dev, > struct ethtool_coalesce *ec) > +{ > + return __stmmac_get_coalesce(dev, ec, -1); > +} > + > +static int stmmac_get_per_queue_coalesce(struct net_device *dev, u32 queue, > + struct ethtool_coalesce *ec) > +{ > + return __stmmac_get_coalesce(dev, ec, queue); > +} > + > +static int __stmmac_set_coalesce(struct net_device *dev, > + struct ethtool_coalesce *ec, > + int queue) > { > struct stmmac_priv *priv = netdev_priv(dev); > - u32 rx_cnt = priv->plat->rx_queues_to_use; > + bool all_queues = false; > unsigned int rx_riwt; > + u32 max_cnt; > + u32 rx_cnt; > + u32 tx_cnt; > + > + rx_cnt = priv->plat->rx_queues_to_use; > + tx_cnt = priv->plat->tx_queues_to_use; > + max_cnt = max(rx_cnt, tx_cnt); > + > + if (queue < 0) > + all_queues = true; > + else if (queue >= max_cnt) > + return -EINVAL; > + > + /* Check not supported parameters */ > + if (ec->rx_coalesce_usecs_irq || > + ec->rx_max_coalesced_frames_irq || ec->tx_coalesce_usecs_irq || > + ec->use_adaptive_rx_coalesce || ec->use_adaptive_tx_coalesce || > + ec->pkt_rate_low || ec->rx_coalesce_usecs_low || > + ec->rx_max_coalesced_frames_low || ec->tx_coalesce_usecs_high || > + ec->tx_max_coalesced_frames_low || ec->pkt_rate_high || > + ec->tx_coalesce_usecs_low || ec->rx_coalesce_usecs_high || > + ec->rx_max_coalesced_frames_high || > + ec->tx_max_coalesced_frames_irq || > + ec->stats_block_coalesce_usecs || > + ec->tx_max_coalesced_frames_high || ec->rate_sample_interval) > + return -EOPNOTSUPP; This shouldn't be needed now that supporter types are expressed in dev->ethtool_ops->supported_coalesce_params, no? > if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) { > rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv); > @@ -785,8 +846,23 @@ static int stmmac_set_coalesce(struct net_device *dev, > if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT)) > return -EINVAL; > > - priv->rx_riwt = rx_riwt; > - stmmac_rx_watchdog(priv, priv->ioaddr, priv->rx_riwt, rx_cnt); > + if (all_queues) { > + int i; > + > + for (i = 0; i < rx_cnt; i++) { > + priv->rx_riwt[i] = rx_riwt; > + stmmac_rx_watchdog(priv, priv->ioaddr, > + rx_riwt, i); > + priv->rx_coal_frames[i] = > + ec->rx_max_coalesced_frames; > + } > + } else if (queue < rx_cnt) { > + priv->rx_riwt[queue] = rx_riwt; > + stmmac_rx_watchdog(priv, priv->ioaddr, > + rx_riwt, queue); > + priv->rx_coal_frames[queue] = > + ec->rx_max_coalesced_frames; > + } > } > > if ((ec->tx_coalesce_usecs == 0) && > @@ -797,13 +873,37 @@ static int stmmac_set_coalesce(struct net_device *dev, > (ec->tx_max_coalesced_frames > STMMAC_TX_MAX_FRAMES)) > return -EINVAL; > > - /* Only copy relevant parameters, ignore all others. */ > - priv->tx_coal_frames = ec->tx_max_coalesced_frames; > - priv->tx_coal_timer = ec->tx_coalesce_usecs; > - priv->rx_coal_frames = ec->rx_max_coalesced_frames; > + if (all_queues) { > + int i; > + > + for (i = 0; i < tx_cnt; i++) { > + priv->tx_coal_frames[i] = > + ec->tx_max_coalesced_frames; > + priv->tx_coal_timer[i] = > + ec->tx_coalesce_usecs; > + } > + } else if (queue < tx_cnt) { > + priv->tx_coal_frames[queue] = > + ec->tx_max_coalesced_frames; > + priv->tx_coal_timer[queue] = > + ec->tx_coalesce_usecs; > + } > + > return 0; > }
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org> To: Ong Boon Leong <boon.leong.ong@intel.com> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@st.com>, Jose Abreu <joabreu@synopsys.com>, "David S . Miller" <davem@davemloft.net>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support Date: Mon, 15 Mar 2021 12:50:59 -0700 [thread overview] Message-ID: <20210315125059.32fde79a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw) In-Reply-To: <20210315064448.16391-2-boon.leong.ong@intel.com> On Mon, 15 Mar 2021 14:44:48 +0800 Ong Boon Leong wrote: > Extending the driver to support per-queue RX and TX coalesce settings in > order to support below commands: > > To show per-queue coalesce setting:- > $ ethtool --per-queue <DEVNAME> queue_mask <MASK> --show-coalesce > > To set per-queue coalesce setting:- > $ ethtool --per-queue <DEVNAME> queue_mask <MASK> --coalesce \ > [rx-usecs N] [rx-frames M] [tx-usecs P] [tx-frames Q] > > Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com> > -static int stmmac_get_coalesce(struct net_device *dev, > - struct ethtool_coalesce *ec) > +static int __stmmac_get_coalesce(struct net_device *dev, > + struct ethtool_coalesce *ec, > + int queue) > { > struct stmmac_priv *priv = netdev_priv(dev); > + u32 max_cnt; > + u32 rx_cnt; > + u32 tx_cnt; > > - ec->tx_coalesce_usecs = priv->tx_coal_timer; > - ec->tx_max_coalesced_frames = priv->tx_coal_frames; > + rx_cnt = priv->plat->rx_queues_to_use; > + tx_cnt = priv->plat->tx_queues_to_use; > + max_cnt = max(rx_cnt, tx_cnt); > > - if (priv->use_riwt) { > - ec->rx_max_coalesced_frames = priv->rx_coal_frames; > - ec->rx_coalesce_usecs = stmmac_riwt2usec(priv->rx_riwt, priv); > + if (queue < 0) > + queue = 0; > + else if (queue >= max_cnt) > + return -EINVAL; > + > + if (queue < tx_cnt) { > + ec->tx_coalesce_usecs = priv->tx_coal_timer[queue]; > + ec->tx_max_coalesced_frames = priv->tx_coal_frames[queue]; > + } else { > + ec->tx_coalesce_usecs = -1; > + ec->tx_max_coalesced_frames = -1; > + } > + > + if (priv->use_riwt && queue < rx_cnt) { > + ec->rx_max_coalesced_frames = priv->rx_coal_frames[queue]; > + ec->rx_coalesce_usecs = stmmac_riwt2usec(priv->rx_riwt[queue], > + priv); > + } else { > + ec->rx_max_coalesced_frames = -1; > + ec->rx_coalesce_usecs = -1; Why the use of negative values? why not leave them as 0? > } > > return 0; > } > > -static int stmmac_set_coalesce(struct net_device *dev, > +static int stmmac_get_coalesce(struct net_device *dev, > struct ethtool_coalesce *ec) > +{ > + return __stmmac_get_coalesce(dev, ec, -1); > +} > + > +static int stmmac_get_per_queue_coalesce(struct net_device *dev, u32 queue, > + struct ethtool_coalesce *ec) > +{ > + return __stmmac_get_coalesce(dev, ec, queue); > +} > + > +static int __stmmac_set_coalesce(struct net_device *dev, > + struct ethtool_coalesce *ec, > + int queue) > { > struct stmmac_priv *priv = netdev_priv(dev); > - u32 rx_cnt = priv->plat->rx_queues_to_use; > + bool all_queues = false; > unsigned int rx_riwt; > + u32 max_cnt; > + u32 rx_cnt; > + u32 tx_cnt; > + > + rx_cnt = priv->plat->rx_queues_to_use; > + tx_cnt = priv->plat->tx_queues_to_use; > + max_cnt = max(rx_cnt, tx_cnt); > + > + if (queue < 0) > + all_queues = true; > + else if (queue >= max_cnt) > + return -EINVAL; > + > + /* Check not supported parameters */ > + if (ec->rx_coalesce_usecs_irq || > + ec->rx_max_coalesced_frames_irq || ec->tx_coalesce_usecs_irq || > + ec->use_adaptive_rx_coalesce || ec->use_adaptive_tx_coalesce || > + ec->pkt_rate_low || ec->rx_coalesce_usecs_low || > + ec->rx_max_coalesced_frames_low || ec->tx_coalesce_usecs_high || > + ec->tx_max_coalesced_frames_low || ec->pkt_rate_high || > + ec->tx_coalesce_usecs_low || ec->rx_coalesce_usecs_high || > + ec->rx_max_coalesced_frames_high || > + ec->tx_max_coalesced_frames_irq || > + ec->stats_block_coalesce_usecs || > + ec->tx_max_coalesced_frames_high || ec->rate_sample_interval) > + return -EOPNOTSUPP; This shouldn't be needed now that supporter types are expressed in dev->ethtool_ops->supported_coalesce_params, no? > if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) { > rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv); > @@ -785,8 +846,23 @@ static int stmmac_set_coalesce(struct net_device *dev, > if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT)) > return -EINVAL; > > - priv->rx_riwt = rx_riwt; > - stmmac_rx_watchdog(priv, priv->ioaddr, priv->rx_riwt, rx_cnt); > + if (all_queues) { > + int i; > + > + for (i = 0; i < rx_cnt; i++) { > + priv->rx_riwt[i] = rx_riwt; > + stmmac_rx_watchdog(priv, priv->ioaddr, > + rx_riwt, i); > + priv->rx_coal_frames[i] = > + ec->rx_max_coalesced_frames; > + } > + } else if (queue < rx_cnt) { > + priv->rx_riwt[queue] = rx_riwt; > + stmmac_rx_watchdog(priv, priv->ioaddr, > + rx_riwt, queue); > + priv->rx_coal_frames[queue] = > + ec->rx_max_coalesced_frames; > + } > } > > if ((ec->tx_coalesce_usecs == 0) && > @@ -797,13 +873,37 @@ static int stmmac_set_coalesce(struct net_device *dev, > (ec->tx_max_coalesced_frames > STMMAC_TX_MAX_FRAMES)) > return -EINVAL; > > - /* Only copy relevant parameters, ignore all others. */ > - priv->tx_coal_frames = ec->tx_max_coalesced_frames; > - priv->tx_coal_timer = ec->tx_coalesce_usecs; > - priv->rx_coal_frames = ec->rx_max_coalesced_frames; > + if (all_queues) { > + int i; > + > + for (i = 0; i < tx_cnt; i++) { > + priv->tx_coal_frames[i] = > + ec->tx_max_coalesced_frames; > + priv->tx_coal_timer[i] = > + ec->tx_coalesce_usecs; > + } > + } else if (queue < tx_cnt) { > + priv->tx_coal_frames[queue] = > + ec->tx_max_coalesced_frames; > + priv->tx_coal_timer[queue] = > + ec->tx_coalesce_usecs; > + } > + > return 0; > } _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-15 19:51 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-15 6:44 [PATCH net-next 0/1] net: stmmac: add per-q coalesce support Ong Boon Leong 2021-03-15 6:44 ` Ong Boon Leong 2021-03-15 6:44 ` [PATCH net-next 1/1] net: stmmac: add per-queue TX & RX coalesce ethtool support Ong Boon Leong 2021-03-15 6:44 ` Ong Boon Leong 2021-03-15 19:50 ` Jakub Kicinski [this message] 2021-03-15 19:50 ` Jakub Kicinski 2021-03-16 4:44 ` Ong, Boon Leong 2021-03-16 4:44 ` Ong, Boon Leong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210315125059.32fde79a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \ --to=kuba@kernel.org \ --cc=alexandre.torgue@st.com \ --cc=boon.leong.ong@intel.com \ --cc=davem@davemloft.net \ --cc=joabreu@synopsys.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=peppe.cavallaro@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.