From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>, Jeffle Xu <jefflexu@linux.alibaba.com>, Mike Snitzer <snitzer@redhat.com>, dm-devel@redhat.com, Ming Lei <ming.lei@redhat.com> Subject: [RFC PATCH 07/11] block/mq: extract one helper function polling hw queue Date: Tue, 16 Mar 2021 11:15:19 +0800 [thread overview] Message-ID: <20210316031523.864506-8-ming.lei@redhat.com> (raw) In-Reply-To: <20210316031523.864506-1-ming.lei@redhat.com> From: Jeffle Xu <jefflexu@linux.alibaba.com> Extract the logic of polling one hw queue and related statistics handling out as the helper function. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index c832faa52ca0..03f59915fe2c 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3852,6 +3852,19 @@ static bool blk_mq_poll_hybrid(struct request_queue *q, return blk_mq_poll_hybrid_sleep(q, rq); } +static inline int blk_mq_poll_hctx(struct request_queue *q, + struct blk_mq_hw_ctx *hctx) +{ + int ret; + + hctx->poll_invoked++; + ret = q->mq_ops->poll(hctx); + if (ret > 0) + hctx->poll_success++; + + return ret; +} + static int blk_bio_poll(struct request_queue *q, blk_qc_t cookie, bool spin) { /* @@ -3908,11 +3921,8 @@ int blk_poll(struct request_queue *q, blk_qc_t cookie, bool spin) do { int ret; - hctx->poll_invoked++; - - ret = q->mq_ops->poll(hctx); + ret = blk_mq_poll_hctx(q, hctx); if (ret > 0) { - hctx->poll_success++; __set_current_state(TASK_RUNNING); return ret; } -- 2.29.2
WARNING: multiple messages have this Message-ID (diff)
From: Ming Lei <ming.lei@redhat.com> To: Jens Axboe <axboe@kernel.dk> Cc: Mike Snitzer <snitzer@redhat.com>, Ming Lei <ming.lei@redhat.com>, linux-block@vger.kernel.org, dm-devel@redhat.com, Jeffle Xu <jefflexu@linux.alibaba.com>, Christoph Hellwig <hch@lst.de> Subject: [dm-devel] [RFC PATCH 07/11] block/mq: extract one helper function polling hw queue Date: Tue, 16 Mar 2021 11:15:19 +0800 [thread overview] Message-ID: <20210316031523.864506-8-ming.lei@redhat.com> (raw) In-Reply-To: <20210316031523.864506-1-ming.lei@redhat.com> From: Jeffle Xu <jefflexu@linux.alibaba.com> Extract the logic of polling one hw queue and related statistics handling out as the helper function. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index c832faa52ca0..03f59915fe2c 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3852,6 +3852,19 @@ static bool blk_mq_poll_hybrid(struct request_queue *q, return blk_mq_poll_hybrid_sleep(q, rq); } +static inline int blk_mq_poll_hctx(struct request_queue *q, + struct blk_mq_hw_ctx *hctx) +{ + int ret; + + hctx->poll_invoked++; + ret = q->mq_ops->poll(hctx); + if (ret > 0) + hctx->poll_success++; + + return ret; +} + static int blk_bio_poll(struct request_queue *q, blk_qc_t cookie, bool spin) { /* @@ -3908,11 +3921,8 @@ int blk_poll(struct request_queue *q, blk_qc_t cookie, bool spin) do { int ret; - hctx->poll_invoked++; - - ret = q->mq_ops->poll(hctx); + ret = blk_mq_poll_hctx(q, hctx); if (ret > 0) { - hctx->poll_success++; __set_current_state(TASK_RUNNING); return ret; } -- 2.29.2 -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-03-16 3:19 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-16 3:15 [RFC PATCH 00/11] block: support bio based io polling Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 01/11] block: add helper of blk_queue_poll Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:26 ` Chaitanya Kulkarni 2021-03-16 3:26 ` [dm-devel] " Chaitanya Kulkarni 2021-03-16 3:15 ` [RFC PATCH 02/11] block: add one helper to free io_context Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 03/11] block: add helper of blk_create_io_context Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 04/11] block: create io poll context for submission and poll task Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 05/11] block: add req flag of REQ_TAG Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 06/11] block: add new field into 'struct bvec_iter' Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` Ming Lei [this message] 2021-03-16 3:15 ` [dm-devel] [RFC PATCH 07/11] block/mq: extract one helper function polling hw queue Ming Lei 2021-03-16 3:15 ` [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 6:46 ` JeffleXu 2021-03-16 6:46 ` [dm-devel] " JeffleXu 2021-03-16 7:17 ` Ming Lei 2021-03-16 7:17 ` [dm-devel] " Ming Lei 2021-03-16 8:52 ` JeffleXu 2021-03-16 8:52 ` [dm-devel] " JeffleXu 2021-03-17 2:54 ` Ming Lei 2021-03-17 2:54 ` [dm-devel] " Ming Lei 2021-03-17 3:53 ` JeffleXu 2021-03-17 3:53 ` [dm-devel] " JeffleXu 2021-03-17 6:54 ` Ming Lei 2021-03-17 6:54 ` [dm-devel] " Ming Lei 2021-03-16 11:00 ` JeffleXu 2021-03-16 11:00 ` [dm-devel] " JeffleXu 2021-03-17 3:38 ` Ming Lei 2021-03-17 3:38 ` [dm-devel] " Ming Lei 2021-03-17 3:49 ` JeffleXu 2021-03-17 3:49 ` [dm-devel] " JeffleXu 2021-03-17 7:19 ` Ming Lei 2021-03-17 7:19 ` [dm-devel] " Ming Lei 2021-03-18 14:51 ` Mike Snitzer 2021-03-18 14:51 ` [dm-devel] " Mike Snitzer 2021-03-16 3:15 ` [RFC PATCH 09/11] block: add queue_to_disk() to get gendisk from request_queue Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 10/11] block: add poll_capable method to support bio-based IO polling Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei 2021-03-16 3:15 ` [RFC PATCH 11/11] dm: support IO polling for bio-based dm device Ming Lei 2021-03-16 3:15 ` [dm-devel] " Ming Lei
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210316031523.864506-8-ming.lei@redhat.com \ --to=ming.lei@redhat.com \ --cc=axboe@kernel.dk \ --cc=dm-devel@redhat.com \ --cc=hch@lst.de \ --cc=jefflexu@linux.alibaba.com \ --cc=linux-block@vger.kernel.org \ --cc=snitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.