Re: [OE-core] unwanted linux kernel image added to /boot directory

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Scott Branden]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

It appears that inherit of the kernel_do_install routine is called which causes the linux
image to be installed in /boot.  I added a quick and dirty hack to inhibit this behaviour.
Could someone please comment on a proper solution:

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index ddff2ddcd2..527f6ca85d 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -428,7 +428,9 @@ kernel_do_install() {
 
        for imageType in ${KERNEL_IMAGETYPES} ; do
                if [ $imageType != "fitImage" ] || [ "${INITRAMFS_IMAGE_BUNDLE}" != "1" ] ; then
-                       install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
+                       if [ "${INHIBIT_IMAGE_IN_BOOT}" != "1" ] ; then
+                               install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
+                       fi
                fi
        done


On 2021-03-15 4:39 p.m., Scott Branden via lists.openembedded.org wrote:
> Hello,
> 
> There seems to be a problem when a kernel module is added to an initramfs image.
> 
> As soon as I add a recipe which installs an external kernel module into an initramfs image it automatically installs the linux kernel image in a /boot directory.
> 
> This is really bad as it increases the size of the initramfs image.
> 
> /boot/Image should not be installed in the image when an external kernel module is added to an image.
> 
> Can someone suggest a fix to this issue?
> 
> Thanks,
>  Scott
> 
> 
> 
> 
> 


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Max Krummenacher]

Hi

Am Montag, den 15.03.2021, 20:13 -0700 schrieb Scott Branden via lists.openembedded.org:
> It appears that inherit of the kernel_do_install routine is called which causes the linux
> image to be installed in /boot.  I added a quick and dirty hack to inhibit this behaviour.
> Could someone please comment on a proper solution:
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index ddff2ddcd2..527f6ca85d 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -428,7 +428,9 @@ kernel_do_install() {
>  
>         for imageType in ${KERNEL_IMAGETYPES} ; do
>                 if [ $imageType != "fitImage" ] || [ "${INITRAMFS_IMAGE_BUNDLE}" != "1" ] ; then
> -                       install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType
> ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> +                       if [ "${INHIBIT_IMAGE_IN_BOOT}" != "1" ] ; then
> +                               install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType
> ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> +                       fi
>                 fi
>         done
> 
> 
> On 2021-03-15 4:39 p.m., Scott Branden via lists.openembedded.org wrote:
> > Hello,
> > 
> > There seems to be a problem when a kernel module is added to an initramfs image.
> > 
> > As soon as I add a recipe which installs an external kernel module into an initramfs image it
> > automatically installs the linux kernel image in a /boot directory.
> > 
> > This is really bad as it increases the size of the initramfs image.
> > 
> > /boot/Image should not be installed in the image when an external kernel module is added to an
> > image.
> > 
> > Can someone suggest a fix to this issue?
> > 

One usually does in the machine configuration:

RDEPENDS_${KERNEL_PACKAGE_NAME}-base = ""

Max

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Khem Raj]

On Tue, Mar 16, 2021 at 3:47 AM Max Krummenacher <max.oss.09@gmail.com> wrote:
>
> Hi
>
> Am Montag, den 15.03.2021, 20:13 -0700 schrieb Scott Branden via lists.openembedded.org:
> > It appears that inherit of the kernel_do_install routine is called which causes the linux
> > image to be installed in /boot.  I added a quick and dirty hack to inhibit this behaviour.
> > Could someone please comment on a proper solution:
> >
> > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > index ddff2ddcd2..527f6ca85d 100644
> > --- a/meta/classes/kernel.bbclass
> > +++ b/meta/classes/kernel.bbclass
> > @@ -428,7 +428,9 @@ kernel_do_install() {
> >
> >         for imageType in ${KERNEL_IMAGETYPES} ; do
> >                 if [ $imageType != "fitImage" ] || [ "${INITRAMFS_IMAGE_BUNDLE}" != "1" ] ; then
> > -                       install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType
> > ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> > +                       if [ "${INHIBIT_IMAGE_IN_BOOT}" != "1" ] ; then
> > +                               install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType
> > ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> > +                       fi
> >                 fi
> >         done
> >
> >
> > On 2021-03-15 4:39 p.m., Scott Branden via lists.openembedded.org wrote:
> > > Hello,
> > >
> > > There seems to be a problem when a kernel module is added to an initramfs image.
> > >
> > > As soon as I add a recipe which installs an external kernel module into an initramfs image it
> > > automatically installs the linux kernel image in a /boot directory.
> > >
> > > This is really bad as it increases the size of the initramfs image.
> > >
> > > /boot/Image should not be installed in the image when an external kernel module is added to an
> > > image.
> > >
> > > Can someone suggest a fix to this issue?
> > >
>
> One usually does in the machine configuration:
>
> RDEPENDS_${KERNEL_PACKAGE_NAME}-base = ""

this should work too.
>
> Max
>
>
> 
>

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Denys Dmytriyenko]

On Tue, Mar 16, 2021 at 09:55:53AM -0700, Khem Raj wrote:
> On Tue, Mar 16, 2021 at 3:47 AM Max Krummenacher <max.oss.09@gmail.com> wrote:
> >
> > Hi
> >
> > Am Montag, den 15.03.2021, 20:13 -0700 schrieb Scott Branden via lists.openembedded.org:
> > > It appears that inherit of the kernel_do_install routine is called which causes the linux
> > > image to be installed in /boot.  I added a quick and dirty hack to inhibit this behaviour.
> > > Could someone please comment on a proper solution:
> > >
> > > diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> > > index ddff2ddcd2..527f6ca85d 100644
> > > --- a/meta/classes/kernel.bbclass
> > > +++ b/meta/classes/kernel.bbclass
> > > @@ -428,7 +428,9 @@ kernel_do_install() {
> > >
> > >         for imageType in ${KERNEL_IMAGETYPES} ; do
> > >                 if [ $imageType != "fitImage" ] || [ "${INITRAMFS_IMAGE_BUNDLE}" != "1" ] ; then
> > > -                       install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType
> > > ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> > > +                       if [ "${INHIBIT_IMAGE_IN_BOOT}" != "1" ] ; then
> > > +                               install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType
> > > ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> > > +                       fi
> > >                 fi
> > >         done
> > >
> > >
> > > On 2021-03-15 4:39 p.m., Scott Branden via lists.openembedded.org wrote:
> > > > Hello,
> > > >
> > > > There seems to be a problem when a kernel module is added to an initramfs image.
> > > >
> > > > As soon as I add a recipe which installs an external kernel module into an initramfs image it
> > > > automatically installs the linux kernel image in a /boot directory.
> > > >
> > > > This is really bad as it increases the size of the initramfs image.
> > > >
> > > > /boot/Image should not be installed in the image when an external kernel module is added to an
> > > > image.
> > > >
> > > > Can someone suggest a fix to this issue?
> > > >
> >
> > One usually does in the machine configuration:
> >
> > RDEPENDS_${KERNEL_PACKAGE_NAME}-base = ""
> 
> this should work too.

That will affect all the images, not just the specific initramfs:
https://lists.openembedded.org/g/openembedded-core/message/149546

-- 
Denys

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Denys Dmytriyenko]

On Mon, Mar 15, 2021 at 08:13:33PM -0700, Scott Branden via lists.openembedded.org wrote:
> It appears that inherit of the kernel_do_install routine is called which causes the linux
> image to be installed in /boot.  I added a quick and dirty hack to inhibit this behaviour.
> Could someone please comment on a proper solution:

Your change is incorrect - the code below installs the kernel image to be 
packaged into corresponding binary package (rpm/ipk/deb) and has nothing to 
do with installing it into your rootfs/initramfs. So, you are basically 
"neutering" kernel image package, making it empty for any rootfs that tries 
to use it.


> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index ddff2ddcd2..527f6ca85d 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -428,7 +428,9 @@ kernel_do_install() {
>  
>         for imageType in ${KERNEL_IMAGETYPES} ; do
>                 if [ $imageType != "fitImage" ] || [ "${INITRAMFS_IMAGE_BUNDLE}" != "1" ] ; then
> -                       install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> +                       if [ "${INHIBIT_IMAGE_IN_BOOT}" != "1" ] ; then
> +                               install -m 0644 ${KERNEL_OUTPUT_DIR}/$imageType ${D}/${KERNEL_IMAGEDEST}/$imageType-${KERNEL_VERSION}
> +                       fi
>                 fi
>         done
> 
> 
> On 2021-03-15 4:39 p.m., Scott Branden via lists.openembedded.org wrote:
> > Hello,
> > 
> > There seems to be a problem when a kernel module is added to an initramfs 
> > image.
> > 
> > As soon as I add a recipe which installs an external kernel module into an 
> > initramfs image it automatically installs the linux kernel image in a 
> > /boot directory.
> > 
> > This is really bad as it increases the size of the initramfs image.
> > 
> > /boot/Image should not be installed in the image when an external kernel 
> > module is added to an image.
> > 
> > Can someone suggest a fix to this issue?
> > 
> > Thanks,
> >  Scott

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Denys Dmytriyenko]

On Tue, Mar 16, 2021 at 02:36:28PM -0400, Denys Dmytriyenko wrote:
> This went off the list - hope you don't mind to put it back...

And, I ended up sending it to the wrong list... Sorry.


> On Tue, Mar 16, 2021 at 10:58:22AM -0700, Scott Branden wrote:
> > Hi Denys,
> > 
> > Thanks for the excellent suggestions - they work.
> > But, these seem really obscure.  I think the kernel.bbclass shouldn't automatically
> > be installing /boot/linux to begin with.  It could be done based on an image feature
> > selection?
> 
> kernel.bbclass does not populate the rootfs, it populates the corresponding 
> package. Any rootfs/initramfs is then built by installing necessary packages 
> into it. Whether to install a package or not is determined by IMAGE_INSTALL 
> and dependencies between the packages.
> 
> 
> > In addition, there seems to be an additional logic error in the present image
> > creation.  If I do not install an external kernel module in the image then /boot/linux
> > is not installed either.  Simply adding an external kernel module to an image shouldn't
> > pull in /boot/linux into the image?
> 
> It is not an error, but a well-defined behavior. In the link below there's a 
> comment about the default dependencies and how to alter them.
> 
> Basically, every kernel-module-* RDEPENDS on kernel-base, which normally 
> RDEPENDS on kernel-image. So, when you insall a module into your rootfs, it 
> follows the dependency chain properly. Hence all the suggestions you received 
> to simply disconnect kernel-image from kernel-base.
> 
> That normally works for most cases, unless you need a mixed behavior that I 
> mentioned. Hence, ROOTFS_POSTPROCESS_COMMAND trick.
> 
> 
> > On 2021-03-15 4:57 p.m., Denys Dmytriyenko wrote:
> > > On Mon, Mar 15, 2021 at 04:39:56PM -0700, Scott Branden via lists.openembedded.org wrote:
> > >> Hello,
> > >>
> > >> There seems to be a problem when a kernel module is added to an initramfs 
> > >> image.
> > >>
> > >> As soon as I add a recipe which installs an external kernel module into an 
> > >> initramfs image it automatically installs the linux kernel image in a /boot 
> > >> directory.
> > >>
> > >> This is really bad as it increases the size of the initramfs image.
> > >>
> > >> /boot/Image should not be installed in the image when an external kernel 
> > >> module is added to an image.
> > >>
> > >> Can someone suggest a fix to this issue?
> > > 
> > > There is an ages-old control knob for that, read here:
> > > https://git.openembedded.org/openembedded-core/tree/meta/classes/kernel.bbclass#n623
> > > 
> > > In your machine or distro config, you can set this as:
> > > RDEPENDS_${KERNEL_PACKAGE_NAME}-base = ""
> > > 
> > > But that will affect all your images for a given machine. If you need to only 
> > > do it selectively for your initramfs image, but keep the standard behavior for 
> > > other images, you can do something like this in corresponding recipe:
> > > 
> > > ROOTFS_POSTPROCESS_COMMAND += "empty_boot_dir; "
> > > empty_boot_dir () {
> > >         rm -rf ${IMAGE_ROOTFS}/boot/*
> > > }

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Denys Dmytriyenko]

This went off the list - hope you don't mind to put it back...


On Tue, Mar 16, 2021 at 10:58:22AM -0700, Scott Branden wrote:
> Hi Denys,
> 
> Thanks for the excellent suggestions - they work.
> But, these seem really obscure.  I think the kernel.bbclass shouldn't automatically
> be installing /boot/linux to begin with.  It could be done based on an image feature
> selection?

kernel.bbclass does not populate the rootfs, it populates the corresponding 
package. Any rootfs/initramfs is then built by installing necessary packages 
into it. Whether to install a package or not is determined by IMAGE_INSTALL 
and dependencies between the packages.


> In addition, there seems to be an additional logic error in the present image
> creation.  If I do not install an external kernel module in the image then /boot/linux
> is not installed either.  Simply adding an external kernel module to an image shouldn't
> pull in /boot/linux into the image?

It is not an error, but a well-defined behavior. In the link below there's a 
comment about the default dependencies and how to alter them.

Basically, every kernel-module-* RDEPENDS on kernel-base, which normally 
RDEPENDS on kernel-image. So, when you insall a module into your rootfs, it 
follows the dependency chain properly. Hence all the suggestions you received 
to simply disconnect kernel-image from kernel-base.

That normally works for most cases, unless you need a mixed behavior that I 
mentioned. Hence, ROOTFS_POSTPROCESS_COMMAND trick.


> On 2021-03-15 4:57 p.m., Denys Dmytriyenko wrote:
> > On Mon, Mar 15, 2021 at 04:39:56PM -0700, Scott Branden via lists.openembedded.org wrote:
> >> Hello,
> >>
> >> There seems to be a problem when a kernel module is added to an initramfs 
> >> image.
> >>
> >> As soon as I add a recipe which installs an external kernel module into an 
> >> initramfs image it automatically installs the linux kernel image in a /boot 
> >> directory.
> >>
> >> This is really bad as it increases the size of the initramfs image.
> >>
> >> /boot/Image should not be installed in the image when an external kernel 
> >> module is added to an image.
> >>
> >> Can someone suggest a fix to this issue?
> > 
> > There is an ages-old control knob for that, read here:
> > https://git.openembedded.org/openembedded-core/tree/meta/classes/kernel.bbclass#n623
> > 
> > In your machine or distro config, you can set this as:
> > RDEPENDS_${KERNEL_PACKAGE_NAME}-base = ""
> > 
> > But that will affect all your images for a given machine. If you need to only 
> > do it selectively for your initramfs image, but keep the standard behavior for 
> > other images, you can do something like this in corresponding recipe:
> > 
> > ROOTFS_POSTPROCESS_COMMAND += "empty_boot_dir; "
> > empty_boot_dir () {
> >         rm -rf ${IMAGE_ROOTFS}/boot/*
> > }

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Denys Dmytriyenko]

On Mon, Mar 15, 2021 at 04:49:34PM -0700, Khem Raj wrote:
> On Mon, Mar 15, 2021 at 4:40 PM Scott Branden via
> lists.openembedded.org
> <scott.branden=broadcom.com@lists.openembedded.org> wrote:
> >
> > Hello,
> >
> > There seems to be a problem when a kernel module is added to an initramfs 
> > image.
> >
> > As soon as I add a recipe which installs an external kernel module into an 
> > initramfs image it automatically installs the linux kernel image in a 
> > /boot directory.
> >
> > This is really bad as it increases the size of the initramfs image.
> >
> > /boot/Image should not be installed in the image when an external kernel 
> > module is added to an image.
> >
> > Can someone suggest a fix to this issue?
> >
> 
> try
> 
> IMAGE_INSTALL_remove = "kernel-image-${KERNEL_IMAGETYPE}"

Kernel image won't be in IMAGE_INSTALL list, but rather in rdeps chain.


> or set
> 
> KERNEL_IMAGE = ""

No such variable.


-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Denys Dmytriyenko]

On Mon, Mar 15, 2021 at 04:39:56PM -0700, Scott Branden via lists.openembedded.org wrote:
> Hello,
> 
> There seems to be a problem when a kernel module is added to an initramfs 
> image.
> 
> As soon as I add a recipe which installs an external kernel module into an 
> initramfs image it automatically installs the linux kernel image in a /boot 
> directory.
> 
> This is really bad as it increases the size of the initramfs image.
> 
> /boot/Image should not be installed in the image when an external kernel 
> module is added to an image.
> 
> Can someone suggest a fix to this issue?

There is an ages-old control knob for that, read here:
https://git.openembedded.org/openembedded-core/tree/meta/classes/kernel.bbclass#n623

In your machine or distro config, you can set this as:
RDEPENDS_${KERNEL_PACKAGE_NAME}-base = ""

But that will affect all your images for a given machine. If you need to only 
do it selectively for your initramfs image, but keep the standard behavior for 
other images, you can do something like this in corresponding recipe:

ROOTFS_POSTPROCESS_COMMAND += "empty_boot_dir; "
empty_boot_dir () {
        rm -rf ${IMAGE_ROOTFS}/boot/*
}

-- 
Regards,
Denys Dmytriyenko <denis@denix.org>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964

Re: [OE-core] unwanted linux kernel image added to /boot directory

[Khem Raj]

On Mon, Mar 15, 2021 at 4:40 PM Scott Branden via
lists.openembedded.org
<scott.branden=broadcom.com@lists.openembedded.org> wrote:
>
> Hello,
>
> There seems to be a problem when a kernel module is added to an initramfs image.
>
> As soon as I add a recipe which installs an external kernel module into an initramfs image it automatically installs the linux kernel image in a /boot directory.
>
> This is really bad as it increases the size of the initramfs image.
>
> /boot/Image should not be installed in the image when an external kernel module is added to an image.
>
> Can someone suggest a fix to this issue?
>

try

IMAGE_INSTALL_remove = "kernel-image-${KERNEL_IMAGETYPE}"

or set

KERNEL_IMAGE = ""

> Thanks,
>  Scott
>
> 
>