Re: Windows 10 won't run on default x86_64 machine anymore

From: Igor Mammedov <imammedo@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Reinoud Zandijk <reinoud@NetBSD.org>,
	qemu-devel@nongnu.org, Isaku Yamahata <isaku.yamahata@gmail.com>
Subject: Re: Windows 10 won't run on default x86_64 machine anymore
Date: Tue, 16 Mar 2021 17:49:14 +0100	[thread overview]
Message-ID: <20210316174914.50efc26b@redhat.com> (raw)
In-Reply-To: <20210316141044.311688bb@redhat.com>

On Tue, 16 Mar 2021 14:10:44 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> On Tue, 16 Mar 2021 13:49:57 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
> 
> > On 16/03/21 13:13, Igor Mammedov wrote:  
> > >>> Surprisingly without accelerator ie with tcg the default machine does seem to
> > >>> get to the login prompt. Is the ACPI data tailored to indicate an
> > >>> accelerator/VM or is it static? Could it be that the CPU reported by my
> > >>> machine is causing the issue? With the NVMM accelerator it passes on the hosts    
> > >>
> > >> I think tcg case can be explained by x86_machine_is_smm_enabled()
> > >>
> > >>    bool x86_machine_is_smm_enabled(const X86MachineState *x86ms)
> > >>    ...
> > >>        if (tcg_enabled() || qtest_enabled()) {
> > >>            smm_available = true;
> > >>        } else if (kvm_enabled()) {
> > >>            smm_available = kvm_has_smm();
> > >>        }
> > >>    ...
> > >>
> > >> Although I don't know about nvmm case, this function also needs to be updated
> > >> if smi isn't supported.    
> > > can you submit a patch for this please?    
> > 
> > nvmm is not part of upstream yet, so I guess it's up to Reinoud to fix 
> > it.  Still, reproducing his testing conditions with KVM and -M smm=off 
> > is probably interesting because it also affects HAX, HVF and WHPX which 
> > are supported upstream.  
> 
> I'm in process of preparing test env for it with reported Windows version,
> so I'll try this case as well.
> 

Here is test matrix booting Windows install ISO:
qemu-system-x86_64  -m 4G -smp cores=2 -cpu host -accel kvm -vnc localhost:0 -snapshot -M pc-i440fx-6.0,smm=off \
 -cdrom en_windows_10_business_editions_version_1809_updated_jan_2019_x64_dvd_72a665f1.iso

                       | smm=on     | smm=off    |
--------------------------------------------------
QEMU6.0 pc-i440fx-5.2  |    pass    | pass       |
defaut smm-compat=on   |            |            |
--------------------------------------------------
QEMU6.0 pc-i440fx-6.0  |    pass    | fail       |
defaut smm-compat=off  |            |            |
-------------------------------------------------|

so it will break booting Windows on accelerators that do not support smm
by default starting from pc-i440fx-6.0 machine type.

It asserts in: 0xa5_FAILED_ACPI_TRANSITION_ACPI!ACPIEnableEnterACPIMode

I haven't looked into what it doesn't like there.

> > Paolo
> >   
> 
> 