[Buildroot] [PATCH v1 1/3] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled

[Buildroot] [PATCH v1 1/3] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled

[Peter Seiderer]

Taking a deeper look at the configure script gen-compat-autoconf.sh reveals that
the batman feature options must be explicitly set to 'y' or 'n' to work as
expected.

Fixes:

  ERROR: modpost: "batadv_v_mesh_free" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
  ERROR: modpost: "batadv_v_mesh_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
  ERROR: modpost: "batadv_v_hardif_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
  ERROR: modpost: "batadv_v_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!

Reported-by: Christian Stewart <christian@paral.in>
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Notes:
  - the previous patch was tested against an RPi4 linux kernel already
    enabling the build-in batman-adv module inlcusive batman-v, the defconfig
    given by Christian (enhanced by BR2_LINUX_KERNEL/BR2_LINUX_KERNEL_LATEST_VERSION/
    BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFI) uses one with build-in batman-adv
    disabled
---
 package/batman-adv/batman-adv.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/batman-adv/batman-adv.mk b/package/batman-adv/batman-adv.mk
index bfa573643d..2de92d6543 100644
--- a/package/batman-adv/batman-adv.mk
+++ b/package/batman-adv/batman-adv.mk
@@ -24,9 +24,9 @@ BATMAN_ADV_MODULE_MAKE_OPTS = \
 	CONFIG_BATMAN_ADV_BLA=y \
 	CONFIG_BATMAN_ADV_DAT=y \
 	CONFIG_BATMAN_ADV_MCAST=y \
-	$(if $(BR2_PACKAGE_BATMAN_ADV_BATMAN_V), CONFIG_BATMAN_ADV_BATMAN_V=y) \
-	$(if $(BR2_PACKAGE_BATMAN_ADV_DEBUG), CONFIG_BATMAN_ADV_DEBUG=y) \
-	$(if $(BR2_PACKAGE_BATMAN_ADV_NC), CONFIG_BATMAN_ADV_NC=y)
+	CONFIG_BATMAN_ADV_BATMAN_V=$(if $(BR2_PACKAGE_BATMAN_ADV_BATMAN_V),y,n) \
+	CONFIG_BATMAN_ADV_DEBUG=$(if $(BR2_PACKAGE_BATMAN_ADV_DEBUG),y,n) \
+	CONFIG_BATMAN_ADV_NC=$(if $(BR2_PACKAGE_BATMAN_ADV_NC),y,n)
 
 BATMAN_ADV_MODULE_SUBDIRS = net/batman-adv
 
-- 
2.30.1

[Buildroot] [PATCH v1 2/3] package/batman-adv: needs linux kernel libcrc32c support

[Peter Seiderer]

Fixes:

  ERROR: modpost: "crc32c" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/batman-adv/batman-adv.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/batman-adv/batman-adv.mk b/package/batman-adv/batman-adv.mk
index 2de92d6543..194951a712 100644
--- a/package/batman-adv/batman-adv.mk
+++ b/package/batman-adv/batman-adv.mk
@@ -34,5 +34,9 @@ define BATMAN_ADV_CONFIGURE_CMDS
 	$(BATMAN_ADV_MODULE_MAKE_OPTS) $(@D)/gen-compat-autoconf.sh $(@D)/compat-autoconf.h
 endef
 
+define BATMAN_ADV_LINUX_CONFIG_FIXUPS
+	$(call KCONFIG_ENABLE_OPT,CONFIG_LIBCRC32C)
+endef
+
 $(eval $(kernel-module))
 $(eval $(generic-package))
-- 
2.30.1

[Buildroot] [PATCH v1 3/3] package/batman-adv: add note about linux mainline kernel module alternative

[Peter Seiderer]

Since version 2.6.38 batman-adv is integreated into the linux mainline
kernel ([1], [2]) so add a note about it in the Config.in help text.

[1] https://kernelnewbies.org/Linux_2_6_38
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6c8fea29769d998d94fcec9b9f14d4b52b349d3

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/batman-adv/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in
index 9d3d7967b9..eae94fd130 100644
--- a/package/batman-adv/Config.in
+++ b/package/batman-adv/Config.in
@@ -6,6 +6,8 @@ config BR2_PACKAGE_BATMAN_ADV
 	depends on BR2_LINUX_KERNEL
 	help
 	  batman-adv mesh networking kernel module
+	  Note: batman-adv is part of the linux mainline
+	  kernel since version 2.6.38
 
 	  https://www.open-mesh.org/projects/batman-adv/
 
-- 
2.30.1

[Buildroot] [PATCH v1 1/3] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled

[Yann E. MORIN]

Peter, All,

On 2021-03-16 19:14 +0100, Peter Seiderer spake thusly:
> Taking a deeper look at the configure script gen-compat-autoconf.sh reveals that
> the batman feature options must be explicitly set to 'y' or 'n' to work as
> expected.
> 
> Fixes:
> 
>   ERROR: modpost: "batadv_v_mesh_free" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
>   ERROR: modpost: "batadv_v_mesh_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
>   ERROR: modpost: "batadv_v_hardif_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
>   ERROR: modpost: "batadv_v_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
> 
> Reported-by: Christian Stewart <christian@paral.in>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Notes:
>   - the previous patch was tested against an RPi4 linux kernel already
>     enabling the build-in batman-adv module inlcusive batman-v, the defconfig

I've added this part of the note in the commit log.

>     given by Christian (enhanced by BR2_LINUX_KERNEL/BR2_LINUX_KERNEL_LATEST_VERSION/
>     BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFI) uses one with build-in batman-adv
>     disabled

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/batman-adv/batman-adv.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/batman-adv/batman-adv.mk b/package/batman-adv/batman-adv.mk
> index bfa573643d..2de92d6543 100644
> --- a/package/batman-adv/batman-adv.mk
> +++ b/package/batman-adv/batman-adv.mk
> @@ -24,9 +24,9 @@ BATMAN_ADV_MODULE_MAKE_OPTS = \
>  	CONFIG_BATMAN_ADV_BLA=y \
>  	CONFIG_BATMAN_ADV_DAT=y \
>  	CONFIG_BATMAN_ADV_MCAST=y \
> -	$(if $(BR2_PACKAGE_BATMAN_ADV_BATMAN_V), CONFIG_BATMAN_ADV_BATMAN_V=y) \
> -	$(if $(BR2_PACKAGE_BATMAN_ADV_DEBUG), CONFIG_BATMAN_ADV_DEBUG=y) \
> -	$(if $(BR2_PACKAGE_BATMAN_ADV_NC), CONFIG_BATMAN_ADV_NC=y)
> +	CONFIG_BATMAN_ADV_BATMAN_V=$(if $(BR2_PACKAGE_BATMAN_ADV_BATMAN_V),y,n) \
> +	CONFIG_BATMAN_ADV_DEBUG=$(if $(BR2_PACKAGE_BATMAN_ADV_DEBUG),y,n) \
> +	CONFIG_BATMAN_ADV_NC=$(if $(BR2_PACKAGE_BATMAN_ADV_NC),y,n)
>  
>  BATMAN_ADV_MODULE_SUBDIRS = net/batman-adv
>  
> -- 
> 2.30.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v1 2/3] package/batman-adv: needs linux kernel libcrc32c support

[Yann E. MORIN]

Peter, All,

On 2021-03-16 19:14 +0100, Peter Seiderer spake thusly:
> Fixes:
> 
>   ERROR: modpost: "crc32c" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/batman-adv/batman-adv.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/batman-adv/batman-adv.mk b/package/batman-adv/batman-adv.mk
> index 2de92d6543..194951a712 100644
> --- a/package/batman-adv/batman-adv.mk
> +++ b/package/batman-adv/batman-adv.mk
> @@ -34,5 +34,9 @@ define BATMAN_ADV_CONFIGURE_CMDS
>  	$(BATMAN_ADV_MODULE_MAKE_OPTS) $(@D)/gen-compat-autoconf.sh $(@D)/compat-autoconf.h
>  endef
>  
> +define BATMAN_ADV_LINUX_CONFIG_FIXUPS
> +	$(call KCONFIG_ENABLE_OPT,CONFIG_LIBCRC32C)
> +endef
> +
>  $(eval $(kernel-module))
>  $(eval $(generic-package))
> -- 
> 2.30.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v1 3/3] package/batman-adv: add note about linux mainline kernel module alternative

[Yann E. MORIN]

Peter, All,

On 2021-03-16 19:14 +0100, Peter Seiderer spake thusly:
> Since version 2.6.38 batman-adv is integreated into the linux mainline
> kernel ([1], [2]) so add a note about it in the Config.in help text.

We do not wupport building kernels before 3.0 (and even that is 10 years
old now, so I'm not sure how solid it would be).

As such, does it make sense to have the out-of-tree B.A.T.M.A.N Adv
kernel module at all?

Note also that the versionwe have is 2019.3, two years old, and the
in-tree version for recent kernels is probably in better shape than what
we carry.

Shouldn't we drop this package, now?

> [1] https://kernelnewbies.org/Linux_2_6_38
> [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6c8fea29769d998d94fcec9b9f14d4b52b349d3
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

In the meantime: applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/batman-adv/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in
> index 9d3d7967b9..eae94fd130 100644
> --- a/package/batman-adv/Config.in
> +++ b/package/batman-adv/Config.in
> @@ -6,6 +6,8 @@ config BR2_PACKAGE_BATMAN_ADV
>  	depends on BR2_LINUX_KERNEL
>  	help
>  	  batman-adv mesh networking kernel module
> +	  Note: batman-adv is part of the linux mainline
> +	  kernel since version 2.6.38
>  
>  	  https://www.open-mesh.org/projects/batman-adv/
>  
> -- 
> 2.30.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v1 3/3] package/batman-adv: add note about linux mainline kernel module alternative

[Peter Seiderer]

Hello Yann,

On Tue, 16 Mar 2021 21:19:23 +0100, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Peter, All,
>
> On 2021-03-16 19:14 +0100, Peter Seiderer spake thusly:
> > Since version 2.6.38 batman-adv is integreated into the linux mainline
> > kernel ([1], [2]) so add a note about it in the Config.in help text.
>
> We do not wupport building kernels before 3.0 (and even that is 10 years
> old now, so I'm not sure how solid it would be).
>
> As such, does it make sense to have the out-of-tree B.A.T.M.A.N Adv
> kernel module at all?
>
> Note also that the versionwe have is 2019.3, two years old, and the
> in-tree version for recent kernels is probably in better shape than what
> we carry.

See

	https://patchwork.ozlabs.org/project/buildroot/patch/20210311210804.9616-2-ps.report at gmx.net/

for update to 2021.0


>
> Shouldn't we drop this package, now?

Would suspect the use case/reason why batman-adv is still provided as out-of-tree module is
to enable up-to-date batman with older kernels...as the 2021.0 release announcement mentions
compatibility with 4.4 to 5.11 (see [3])...

Regards,
Peter

[3] https://www.open-mesh.org/news/100

>
> > [1] https://kernelnewbies.org/Linux_2_6_38
> > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6c8fea29769d998d94fcec9b9f14d4b52b349d3
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> In the meantime: applied to master, thanks.
>
> Regards,
> Yann E. MORIN.
>
> > ---
> >  package/batman-adv/Config.in | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/package/batman-adv/Config.in b/package/batman-adv/Config.in
> > index 9d3d7967b9..eae94fd130 100644
> > --- a/package/batman-adv/Config.in
> > +++ b/package/batman-adv/Config.in
> > @@ -6,6 +6,8 @@ config BR2_PACKAGE_BATMAN_ADV
> >  	depends on BR2_LINUX_KERNEL
> >  	help
> >  	  batman-adv mesh networking kernel module
> > +	  Note: batman-adv is part of the linux mainline
> > +	  kernel since version 2.6.38
> >
> >  	  https://www.open-mesh.org/projects/batman-adv/
> >
> > --
> > 2.30.1
> >
>

[Buildroot] [PATCH v1 3/3] package/batman-adv: add note about linux mainline kernel module alternative

[Yann E. MORIN]

Peter, All,

On 2021-03-16 21:53 +0100, Peter Seiderer spake thusly:
> On Tue, 16 Mar 2021 21:19:23 +0100, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
> > Peter, All,
> > On 2021-03-16 19:14 +0100, Peter Seiderer spake thusly:
> > > Since version 2.6.38 batman-adv is integreated into the linux mainline
> > > kernel ([1], [2]) so add a note about it in the Config.in help text.
> > Note also that the versionwe have is 2019.3, two years old, and the
> > in-tree version for recent kernels is probably in better shape than what
> > we carry.
> See
> 	https://patchwork.ozlabs.org/project/buildroot/patch/20210311210804.9616-2-ps.report at gmx.net/
> for update to 2021.0

Hehe... :-)

> > Shouldn't we drop this package, now?
> 
> Would suspect the use case/reason why batman-adv is still provided as out-of-tree module is
> to enable up-to-date batman with older kernels...as the 2021.0 release announcement mentions
> compatibility with 4.4 to 5.11 (see [3])...

OK, that make sense. Thanks.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v1 1/3] package/batman-adv: fix compile with BR2_PACKAGE_BATMAN_ADV_BATMAN_V disabled

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Taking a deeper look at the configure script gen-compat-autoconf.sh reveals that
 > the batman feature options must be explicitly set to 'y' or 'n' to work as
 > expected.

 > Fixes:

 >   ERROR: modpost: "batadv_v_mesh_free" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
 >   ERROR: modpost: "batadv_v_mesh_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
 >   ERROR: modpost: "batadv_v_hardif_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!
 >   ERROR: modpost: "batadv_v_init" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!

 > Reported-by: Christian Stewart <christian@paral.in>
 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
 > ---
 > Notes:
 >   - the previous patch was tested against an RPi4 linux kernel already
 >     enabling the build-in batman-adv module inlcusive batman-v, the defconfig
 >     given by Christian (enhanced by BR2_LINUX_KERNEL/BR2_LINUX_KERNEL_LATEST_VERSION/
 >     BR2_LINUX_KERNEL_USE_ARCH_DEFAULT_CONFI) uses one with build-in batman-adv
 >     disabled

Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v1 3/3] package/batman-adv: add note about linux mainline kernel module alternative

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Since version 2.6.38 batman-adv is integreated into the linux mainline
 > kernel ([1], [2]) so add a note about it in the Config.in help text.

 > [1] https://kernelnewbies.org/Linux_2_6_38
 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6c8fea29769d998d94fcec9b9f14d4b52b349d3

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed to 2020.02.x, 2020.11.x and 2021.02.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v1 2/3] package/batman-adv: needs linux kernel libcrc32c support

[Peter Korsgaard]

>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:

 > Fixes:
 >   ERROR: modpost: "crc32c" [.../build/batman-adv-2021.0/net/batman-adv/batman-adv.ko] undefined!

 > Signed-off-by: Peter Seiderer <ps.report@gmx.net>

Committed to 2020.11.x and 2021.02.x, thanks. I did NOT apply it to
2020.02.x as we don't have the _LINUX_CONFIG_FIXUPS infrastructure
there.

-- 
Bye, Peter Korsgaard