All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/json-for-modern-cpp: enable multiple headers by default
@ 2021-03-15  8:17 Dimitrij Kotrev
  2021-03-16 20:58 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Dimitrij Kotrev @ 2021-03-15  8:17 UTC (permalink / raw)
  To: buildroot

json-for-modern-cpp provides an option to enable multiple headers support.
Currently this option is disabled and the package creates just a
single header: "nlohmann/json.hpp", which contains everything. Enabling
this option, splits this single header into multiple ones. First of all
this provides an additional header: "nlohmann/json_fwd.hpp", which contains
only forwarding declarations of types provided by this library. This
gives you a more finer control over include dependencies and can speed up
build times significantly. The top level header: "nlohmann/json.hpp" is
still there and therefore code which used it before, would stay compatible.

Signed-off-by: Dimitrij Kotrev <dimitrij.kotrev@googlemail.com>
---
 package/json-for-modern-cpp/json-for-modern-cpp.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/json-for-modern-cpp/json-for-modern-cpp.mk b/package/json-for-modern-cpp/json-for-modern-cpp.mk
index 6e21723fd4..94cdc909f3 100644
--- a/package/json-for-modern-cpp/json-for-modern-cpp.mk
+++ b/package/json-for-modern-cpp/json-for-modern-cpp.mk
@@ -12,6 +12,6 @@ JSON_FOR_MODERN_CPP_LICENSE_FILES = LICENSE.MIT
 JSON_FOR_MODERN_CPP_INSTALL_STAGING = YES
 # header only library
 JSON_FOR_MODERN_CPP_INSTALL_TARGET = NO
-JSON_FOR_MODERN_CPP_CONF_OPTS = -DJSON_BuildTests=OFF
+JSON_FOR_MODERN_CPP_CONF_OPTS = -DJSON_BuildTests=OFF -DJSON_MultipleHeaders=ON
 
 $(eval $(cmake-package))
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/json-for-modern-cpp: enable multiple headers by default
  2021-03-15  8:17 [Buildroot] [PATCH 1/1] package/json-for-modern-cpp: enable multiple headers by default Dimitrij Kotrev
@ 2021-03-16 20:58 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2021-03-16 20:58 UTC (permalink / raw)
  To: buildroot

On Mon, 15 Mar 2021 09:17:02 +0100
Dimitrij Kotrev <dimitrij.kotrev@googlemail.com> wrote:

> json-for-modern-cpp provides an option to enable multiple headers support.
> Currently this option is disabled and the package creates just a
> single header: "nlohmann/json.hpp", which contains everything. Enabling
> this option, splits this single header into multiple ones. First of all
> this provides an additional header: "nlohmann/json_fwd.hpp", which contains
> only forwarding declarations of types provided by this library. This
> gives you a more finer control over include dependencies and can speed up
> build times significantly. The top level header: "nlohmann/json.hpp" is
> still there and therefore code which used it before, would stay compatible.
> 
> Signed-off-by: Dimitrij Kotrev <dimitrij.kotrev@googlemail.com>
> ---
>  package/json-for-modern-cpp/json-for-modern-cpp.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-03-16 20:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-15  8:17 [Buildroot] [PATCH 1/1] package/json-for-modern-cpp: enable multiple headers by default Dimitrij Kotrev
2021-03-16 20:58 ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.