[LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code

[LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code

[Zhao Gongyi]

Change 'Description' to 'DESCRIPTION' and change 'Algorithm' to
'ALGORITHM' and remove Redundant tst_reap_children since tst_reap_children
has been called in the test skeleton.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
---
 testcases/kernel/containers/pidns/pidns13.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/testcases/kernel/containers/pidns/pidns13.c b/testcases/kernel/containers/pidns/pidns13.c
index 12aee917b..72aefa82b 100644
--- a/testcases/kernel/containers/pidns/pidns13.c
+++ b/testcases/kernel/containers/pidns/pidns13.c
@@ -9,12 +9,12 @@
  */

 /*\
- * [Description]
+ * [DESCRIPTION]
  *
  * The pidns13.c testcase checks container init, for async I/O
  * triggered by peer namespace process.
  *
- * [Algorithm]
+ * [ALGORITHM]
  * * create a pipe in parent namespace
  * * create two PID namespace containers(cinit1 and cinit2)
  * * in cinit1, set pipe read end to send SIGUSR1 for asynchronous I/O
@@ -116,8 +116,6 @@ static void run(void)

 	SAFE_CLOSE(pipe_fd[0]);
 	SAFE_CLOSE(pipe_fd[1]);
-
-	tst_reap_children();
 }

 static struct tst_test test = {
--
2.17.1

[LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code

[Petr Vorel]

HI Gongyi,

> Change 'Description' to 'DESCRIPTION' and change 'Algorithm' to
> 'ALGORITHM' and remove Redundant tst_reap_children since tst_reap_children
> has been called in the test skeleton.

Actually the preferred form is Description (only first letter capitalized),
see f5a269142 ("docparse: Unify Description and Algorithm titles").
(Better would be to also update it in tests, which I haven't done).

Thus I'd be for merging only removing tst_reap_children() (good catch).

Kind regards,
Petr

[LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code

[Petr Vorel]

Hi Gongyi,

> > Change 'Description' to 'DESCRIPTION' and change 'Algorithm' to
> > 'ALGORITHM' and remove Redundant tst_reap_children since tst_reap_children
> > has been called in the test skeleton.

> Actually the preferred form is Description (only first letter capitalized),
> see f5a269142 ("docparse: Unify Description and Algorithm titles").
> (Better would be to also update it in tests, which I haven't done).

> Thus I'd be for merging only removing tst_reap_children() (good catch).

Merged just part removing tst_reap_children().
Thanks!

Kind regards,
Petr

[LTP] [PATCH] cleanup: Unify the annotation style and remove Redundant code

[zhaogongyi]

Hi Petr,

I have resubmit the patch as your review.

Thanks!

Best Regards,
Gongyi

> 
> HI Gongyi,
> 
> > Change 'Description' to 'DESCRIPTION' and change 'Algorithm' to
> > 'ALGORITHM' and remove Redundant tst_reap_children since
> > tst_reap_children has been called in the test skeleton.
> 
> Actually the preferred form is Description (only first letter capitalized), see
> f5a269142 ("docparse: Unify Description and Algorithm titles").
> (Better would be to also update it in tests, which I haven't done).
> 
> Thus I'd be for merging only removing tst_reap_children() (good catch).
> 
> Kind regards,
> Petr