All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Remove unused calls
@ 2021-03-17 17:14 Qingqing Zhuo
  2021-03-17 17:40 ` Rodrigo Siqueira
  0 siblings, 1 reply; 2+ messages in thread
From: Qingqing Zhuo @ 2021-03-17 17:14 UTC (permalink / raw)
  To: amd-gfx
  Cc: Eryk.Brol, Sunpeng.Li, Harry.Wentland, qingqing.zhuo,
	Rodrigo.Siqueira, roman.li, Anson.Jacob, Aurabindo.Pillai,
	Bhawanpreet.Lakha, bindu.r

dmub_trace_int_entry() was introduced unintentionally, causing
compiling issues.

Fixes: 53e9c0f651421136 ("drm/amd/display: Support vertical interrupt 0 for all dcn ASIC")
Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
---
 .../gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c  | 8 --------
 .../gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c  | 8 --------
 2 files changed, 16 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c
index 48a3c360174e..3908ad929176 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c
@@ -278,13 +278,6 @@ static const struct irq_source_info_funcs vline0_irq_info_funcs = {
 		.funcs = &vblank_irq_info_funcs\
 	}
 
-#define dmub_trace_int_entry()\
-	[DC_IRQ_SOURCE_DMCUB_OUTBOX0] = {\
-		IRQ_REG_ENTRY_DMUB(DMCUB_INTERRUPT_ENABLE, DMCUB_OUTBOX0_READY_INT_EN,\
-			DMCUB_INTERRUPT_ACK, DMCUB_OUTBOX0_READY_INT_ACK),\
-		.funcs = &dmub_trace_irq_info_funcs\
-	}
-
 #define vline0_int_entry(reg_num)\
 	[DC_IRQ_SOURCE_DC1_VLINE0 + reg_num] = {\
 		IRQ_REG_ENTRY(OTG, reg_num,\
@@ -411,7 +404,6 @@ irq_source_info_dcn21[DAL_IRQ_SOURCES_NUMBER] = {
 	vline0_int_entry(3),
 	vline0_int_entry(4),
 	vline0_int_entry(5),
-	dmub_trace_int_entry(),
 };
 
 static const struct irq_service_funcs irq_service_funcs_dcn21 = {
diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c
index 68f8f554c925..4ec6f6ad8c48 100644
--- a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c
+++ b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c
@@ -276,13 +276,6 @@ static const struct irq_source_info_funcs vline0_irq_info_funcs = {
 		.funcs = &vblank_irq_info_funcs\
 	}
 
-#define dmub_trace_int_entry()\
-	[DC_IRQ_SOURCE_DMCUB_OUTBOX0] = {\
-		IRQ_REG_ENTRY_DMUB(DMCUB_INTERRUPT_ENABLE, DMCUB_OUTBOX0_READY_INT_EN,\
-			DMCUB_INTERRUPT_ACK, DMCUB_OUTBOX0_READY_INT_ACK),\
-		.funcs = &dmub_trace_irq_info_funcs\
-	}
-
 #define vline0_int_entry(reg_num)\
 	[DC_IRQ_SOURCE_DC1_VLINE0 + reg_num] = {\
 		IRQ_REG_ENTRY(OTG, reg_num,\
@@ -405,7 +398,6 @@ irq_source_info_dcn30[DAL_IRQ_SOURCES_NUMBER] = {
 	vline0_int_entry(3),
 	vline0_int_entry(4),
 	vline0_int_entry(5),
-	dmub_trace_int_entry(),
 };
 
 static const struct irq_service_funcs irq_service_funcs_dcn30 = {
-- 
2.17.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: Remove unused calls
  2021-03-17 17:14 [PATCH] drm/amd/display: Remove unused calls Qingqing Zhuo
@ 2021-03-17 17:40 ` Rodrigo Siqueira
  0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Siqueira @ 2021-03-17 17:40 UTC (permalink / raw)
  To: Qingqing Zhuo
  Cc: Eryk.Brol, Sunpeng.Li, Harry.Wentland, roman.li, amd-gfx,
	Anson.Jacob, Aurabindo.Pillai, Bhawanpreet.Lakha, bindu.r


[-- Attachment #1.1: Type: text/plain, Size: 2888 bytes --]

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>

On 03/17, Qingqing Zhuo wrote:
> dmub_trace_int_entry() was introduced unintentionally, causing
> compiling issues.
> 
> Fixes: 53e9c0f651421136 ("drm/amd/display: Support vertical interrupt 0 for all dcn ASIC")
> Signed-off-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
> Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  .../gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c  | 8 --------
>  .../gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c  | 8 --------
>  2 files changed, 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c
> index 48a3c360174e..3908ad929176 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn21/irq_service_dcn21.c
> @@ -278,13 +278,6 @@ static const struct irq_source_info_funcs vline0_irq_info_funcs = {
>  		.funcs = &vblank_irq_info_funcs\
>  	}
>  
> -#define dmub_trace_int_entry()\
> -	[DC_IRQ_SOURCE_DMCUB_OUTBOX0] = {\
> -		IRQ_REG_ENTRY_DMUB(DMCUB_INTERRUPT_ENABLE, DMCUB_OUTBOX0_READY_INT_EN,\
> -			DMCUB_INTERRUPT_ACK, DMCUB_OUTBOX0_READY_INT_ACK),\
> -		.funcs = &dmub_trace_irq_info_funcs\
> -	}
> -
>  #define vline0_int_entry(reg_num)\
>  	[DC_IRQ_SOURCE_DC1_VLINE0 + reg_num] = {\
>  		IRQ_REG_ENTRY(OTG, reg_num,\
> @@ -411,7 +404,6 @@ irq_source_info_dcn21[DAL_IRQ_SOURCES_NUMBER] = {
>  	vline0_int_entry(3),
>  	vline0_int_entry(4),
>  	vline0_int_entry(5),
> -	dmub_trace_int_entry(),
>  };
>  
>  static const struct irq_service_funcs irq_service_funcs_dcn21 = {
> diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c
> index 68f8f554c925..4ec6f6ad8c48 100644
> --- a/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c
> +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn30/irq_service_dcn30.c
> @@ -276,13 +276,6 @@ static const struct irq_source_info_funcs vline0_irq_info_funcs = {
>  		.funcs = &vblank_irq_info_funcs\
>  	}
>  
> -#define dmub_trace_int_entry()\
> -	[DC_IRQ_SOURCE_DMCUB_OUTBOX0] = {\
> -		IRQ_REG_ENTRY_DMUB(DMCUB_INTERRUPT_ENABLE, DMCUB_OUTBOX0_READY_INT_EN,\
> -			DMCUB_INTERRUPT_ACK, DMCUB_OUTBOX0_READY_INT_ACK),\
> -		.funcs = &dmub_trace_irq_info_funcs\
> -	}
> -
>  #define vline0_int_entry(reg_num)\
>  	[DC_IRQ_SOURCE_DC1_VLINE0 + reg_num] = {\
>  		IRQ_REG_ENTRY(OTG, reg_num,\
> @@ -405,7 +398,6 @@ irq_source_info_dcn30[DAL_IRQ_SOURCES_NUMBER] = {
>  	vline0_int_entry(3),
>  	vline0_int_entry(4),
>  	vline0_int_entry(5),
> -	dmub_trace_int_entry(),
>  };
>  
>  static const struct irq_service_funcs irq_service_funcs_dcn30 = {
> -- 
> 2.17.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-17 17:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-17 17:14 [PATCH] drm/amd/display: Remove unused calls Qingqing Zhuo
2021-03-17 17:40 ` Rodrigo Siqueira

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.