All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP
@ 2021-03-18  1:24 ` Tzung-Bi Shih
  0 siblings, 0 replies; 4+ messages in thread
From: Tzung-Bi Shih @ 2021-03-18  1:24 UTC (permalink / raw)
  To: ohad, bjorn.andersson
  Cc: linux-remoteproc, matthias.bgg, linux-mediatek, tzungbi, Tinghan Shen

DEVAPC (device access permission control) is a MPU (memory protection
unit) in MT8192.

To restrict SCP accesses to a specific memory range, sets SCP to DEVAPC
domain 3.  ATF (Arm trusted firmware) should setup memory range for the
domain.

Co-developed-by: Tinghan Shen <tinghan.shen@mediatek.com>
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
---
Changes from v1:
- Add "Co-developed-by" tag.

 drivers/remoteproc/mtk_common.h | 2 ++
 drivers/remoteproc/mtk_scp.c    | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h
index 61901f5efa05..2aa9fdf5e59b 100644
--- a/drivers/remoteproc/mtk_common.h
+++ b/drivers/remoteproc/mtk_common.h
@@ -51,6 +51,8 @@
 #define MT8192_CORE0_WDT_IRQ		0x10030
 #define MT8192_CORE0_WDT_CFG		0x10034
 
+#define MT8192_SCP_DEVAPC_DOMAIN	0x85080
+
 #define SCP_FW_VER_LEN			32
 #define SCP_SHARE_BUFFER_SIZE		288
 
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 9679cc26895e..50bdec5a97e3 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -374,6 +374,9 @@ static int mt8192_scp_before_load(struct mtk_scp *scp)
 	/* enable MPU for all memory regions */
 	writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF);
 
+	/* set to DEVAPC (device access permission control) domain 3 */
+	writel(3, scp->reg_base + MT8192_SCP_DEVAPC_DOMAIN);
+
 	return 0;
 }
 
-- 
2.31.0.rc2.261.g7f71774620-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP
@ 2021-03-18  1:24 ` Tzung-Bi Shih
  0 siblings, 0 replies; 4+ messages in thread
From: Tzung-Bi Shih @ 2021-03-18  1:24 UTC (permalink / raw)
  To: ohad, bjorn.andersson
  Cc: linux-remoteproc, matthias.bgg, linux-mediatek, tzungbi, Tinghan Shen

DEVAPC (device access permission control) is a MPU (memory protection
unit) in MT8192.

To restrict SCP accesses to a specific memory range, sets SCP to DEVAPC
domain 3.  ATF (Arm trusted firmware) should setup memory range for the
domain.

Co-developed-by: Tinghan Shen <tinghan.shen@mediatek.com>
Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
---
Changes from v1:
- Add "Co-developed-by" tag.

 drivers/remoteproc/mtk_common.h | 2 ++
 drivers/remoteproc/mtk_scp.c    | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/drivers/remoteproc/mtk_common.h b/drivers/remoteproc/mtk_common.h
index 61901f5efa05..2aa9fdf5e59b 100644
--- a/drivers/remoteproc/mtk_common.h
+++ b/drivers/remoteproc/mtk_common.h
@@ -51,6 +51,8 @@
 #define MT8192_CORE0_WDT_IRQ		0x10030
 #define MT8192_CORE0_WDT_CFG		0x10034
 
+#define MT8192_SCP_DEVAPC_DOMAIN	0x85080
+
 #define SCP_FW_VER_LEN			32
 #define SCP_SHARE_BUFFER_SIZE		288
 
diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index 9679cc26895e..50bdec5a97e3 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -374,6 +374,9 @@ static int mt8192_scp_before_load(struct mtk_scp *scp)
 	/* enable MPU for all memory regions */
 	writel(0xff, scp->reg_base + MT8192_CORE0_MEM_ATT_PREDEF);
 
+	/* set to DEVAPC (device access permission control) domain 3 */
+	writel(3, scp->reg_base + MT8192_SCP_DEVAPC_DOMAIN);
+
 	return 0;
 }
 
-- 
2.31.0.rc2.261.g7f71774620-goog


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP
  2021-03-18  1:24 ` Tzung-Bi Shih
@ 2021-03-18  6:07   ` Tinghan Shen
  -1 siblings, 0 replies; 4+ messages in thread
From: Tinghan Shen @ 2021-03-18  6:07 UTC (permalink / raw)
  To: tzungbi
  Cc: bjorn.andersson, linux-mediatek, linux-remoteproc, matthias.bgg,
	ohad, tinghan.shen

> DEVAPC (device access permission control) is a MPU (memory protection
> unit) in MT8192.
>
> To restrict SCP accesses to a specific memory range, sets SCP to DEVAPC
> domain 3.  ATF (Arm trusted firmware) should setup memory range for the
> domain.
>
> Co-developed-by: Tinghan Shen <tinghan.shen@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>

Hi,

we want to pull this patch back because we have another thought on how to reach our purpose.
thanks for your review.


Best regards,
TingHan

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP
@ 2021-03-18  6:07   ` Tinghan Shen
  0 siblings, 0 replies; 4+ messages in thread
From: Tinghan Shen @ 2021-03-18  6:07 UTC (permalink / raw)
  To: tzungbi
  Cc: bjorn.andersson, linux-mediatek, linux-remoteproc, matthias.bgg,
	ohad, tinghan.shen

> DEVAPC (device access permission control) is a MPU (memory protection
> unit) in MT8192.
>
> To restrict SCP accesses to a specific memory range, sets SCP to DEVAPC
> domain 3.  ATF (Arm trusted firmware) should setup memory range for the
> domain.
>
> Co-developed-by: Tinghan Shen <tinghan.shen@mediatek.com>
> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>

Hi,

we want to pull this patch back because we have another thought on how to reach our purpose.
thanks for your review.


Best regards,
TingHan
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-18  6:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18  1:24 [PATCH v2] remoteproc/mediatek: set to DEVAPC domain 3 for MT8192 SCP Tzung-Bi Shih
2021-03-18  1:24 ` Tzung-Bi Shih
2021-03-18  6:07 ` Tinghan Shen
2021-03-18  6:07   ` Tinghan Shen

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.