[PATCH] tools/virtiofsd: include --socket-group in help

[PATCH] tools/virtiofsd: include --socket-group in help

[Alex Bennée]

I confused myself wandering if this had been merged by looking at the
help output. It seems fuse_opt doesn't automagically add to help
output so lets do it now.

Updates: f6698f2b03 ("tools/virtiofsd: add support for --socket-group")
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tools/virtiofsd/fuse_lowlevel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
index 1aa26c6333..58e32fc963 100644
--- a/tools/virtiofsd/fuse_lowlevel.c
+++ b/tools/virtiofsd/fuse_lowlevel.c
@@ -2450,6 +2450,7 @@ void fuse_lowlevel_help(void)
     printf(
         "    -o allow_root              allow access by root\n"
         "    --socket-path=PATH         path for the vhost-user socket\n"
+        "    --socket-group=GRNAME      name of group for the vhost-user socket\n"
         "    --fd=FDNUM                 fd number of vhost-user socket\n"
         "    --thread-pool-size=NUM     thread pool size limit (default %d)\n",
         THREAD_POOL_SIZE);
-- 
2.20.1

Re: [PATCH] tools/virtiofsd: include --socket-group in help

[Connor Kuehl]

On 3/18/21 5:09 AM, Alex Bennée wrote:
> I confused myself wandering if this had been merged by looking at the
> help output. It seems fuse_opt doesn't automagically add to help
> output so lets do it now.
> 
> Updates: f6698f2b03 ("tools/virtiofsd: add support for --socket-group")
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tools/virtiofsd/fuse_lowlevel.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
> index 1aa26c6333..58e32fc963 100644
> --- a/tools/virtiofsd/fuse_lowlevel.c
> +++ b/tools/virtiofsd/fuse_lowlevel.c
> @@ -2450,6 +2450,7 @@ void fuse_lowlevel_help(void)
>       printf(
>           "    -o allow_root              allow access by root\n"
>           "    --socket-path=PATH         path for the vhost-user socket\n"
> +        "    --socket-group=GRNAME      name of group for the vhost-user socket\n"
>           "    --fd=FDNUM                 fd number of vhost-user socket\n"
>           "    --thread-pool-size=NUM     thread pool size limit (default %d)\n",
>           THREAD_POOL_SIZE);
> 

And it looks like this is already in the man page too, so I think this 
patches the last place it was missing from, nice!

Reviewed-by: Connor Kuehl <ckuehl@redhat.com>