All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libxcrypt: fix sporadic failures in nativesdk-libxcrypt-compat
@ 2021-03-18 10:57 Alexander Kanavin
  2021-03-18 21:22 ` [OE-core] " Christopher Larson
  0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kanavin @ 2021-03-18 10:57 UTC (permalink / raw)
  To: openembedded-core; +Cc: Alexander Kanavin

Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
---
 ...e.ac-do-not-use-compute-symver-floor.patch | 32 +++++++++++++++++++
 meta/recipes-core/libxcrypt/libxcrypt.inc     |  4 ++-
 2 files changed, 35 insertions(+), 1 deletion(-)
 create mode 100644 meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch

diff --git a/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch b/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
new file mode 100644
index 0000000000..4e6b427104
--- /dev/null
+++ b/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
@@ -0,0 +1,32 @@
+From b28bb856ccebe8fded51d11362bf5920699eed59 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Thu, 18 Mar 2021 10:52:13 +0000
+Subject: [PATCH] configure.ac: do not use compute-symver-floor
+
+This script (newly introduced in 4.4.18) sporadically fails, without
+failing configure(), which has been reported at
+https://github.com/besser82/libxcrypt/issues/123
+
+Upstream-Status: Inappropriate
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+---
+ configure.ac | 6 +-----
+ 1 file changed, 1 insertion(+), 5 deletions(-)
+
+diff --git a/configure.ac b/configure.ac
+index 45b91b4..f3ba945 100644
+--- a/configure.ac
++++ b/configure.ac
+@@ -426,11 +426,7 @@ if test x$enable_shared != xyes; then enable_obsolete_api=0; fi
+ # need to be binary backward compatible with.
+ if test $enable_obsolete_api = 1; then
+   AC_MSG_CHECKING([minimum symbol version to use for compatibility symbols])
+-  SYMVER_FLOOR=$(
+-    $PERL ${srcdir}/build-aux/compute-symver-floor \
+-      ${srcdir}/lib/libcrypt.minver $host_os $host_cpu \
+-    2>&AS_MESSAGE_LOG_FD
+-  )
++  SYMVER_FLOOR=GLIBC_2.0
+   AC_MSG_RESULT([$SYMVER_FLOOR])
+   case "$SYMVER_FLOOR" in
+     ERROR)
diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc b/meta/recipes-core/libxcrypt/libxcrypt.inc
index e9f968b556..b5ca863d54 100644
--- a/meta/recipes-core/libxcrypt/libxcrypt.inc
+++ b/meta/recipes-core/libxcrypt/libxcrypt.inc
@@ -9,7 +9,9 @@ LIC_FILES_CHKSUM = "file://LICENSING;md5=bd5d9777dfe7076c4f2928f12fed226a \
 
 inherit autotools pkgconfig
 
-SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH}"
+SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH} \
+           file://0001-configure.ac-do-not-use-compute-symver-floor.patch \
+           "
 SRCREV = "94d84f92ca123d851586016c4678eb1f21c19029"
 SRCBRANCH ?= "develop"
 
-- 
2.29.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] libxcrypt: fix sporadic failures in nativesdk-libxcrypt-compat
  2021-03-18 10:57 [PATCH] libxcrypt: fix sporadic failures in nativesdk-libxcrypt-compat Alexander Kanavin
@ 2021-03-18 21:22 ` Christopher Larson
  2021-03-18 21:22   ` Christopher Larson
  0 siblings, 1 reply; 3+ messages in thread
From: Christopher Larson @ 2021-03-18 21:22 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 3334 bytes --]

If it's been reported upstream, is Inappropriate the correct upstream
status here?

On Thu, Mar 18, 2021 at 3:57 AM Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> ---
>  ...e.ac-do-not-use-compute-symver-floor.patch | 32 +++++++++++++++++++
>  meta/recipes-core/libxcrypt/libxcrypt.inc     |  4 ++-
>  2 files changed, 35 insertions(+), 1 deletion(-)
>  create mode 100644
> meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
>
> diff --git
> a/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
> b/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
> new file mode 100644
> index 0000000000..4e6b427104
> --- /dev/null
> +++
> b/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
> @@ -0,0 +1,32 @@
> +From b28bb856ccebe8fded51d11362bf5920699eed59 Mon Sep 17 00:00:00 2001
> +From: Alexander Kanavin <alex.kanavin@gmail.com>
> +Date: Thu, 18 Mar 2021 10:52:13 +0000
> +Subject: [PATCH] configure.ac: do not use compute-symver-floor
> +
> +This script (newly introduced in 4.4.18) sporadically fails, without
> +failing configure(), which has been reported at
> +https://github.com/besser82/libxcrypt/issues/123
> +
> +Upstream-Status: Inappropriate
> +Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> +---
> + configure.ac | 6 +-----
> + 1 file changed, 1 insertion(+), 5 deletions(-)
> +
> +diff --git a/configure.ac b/configure.ac
> +index 45b91b4..f3ba945 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -426,11 +426,7 @@ if test x$enable_shared != xyes; then
> enable_obsolete_api=0; fi
> + # need to be binary backward compatible with.
> + if test $enable_obsolete_api = 1; then
> +   AC_MSG_CHECKING([minimum symbol version to use for compatibility
> symbols])
> +-  SYMVER_FLOOR=$(
> +-    $PERL ${srcdir}/build-aux/compute-symver-floor \
> +-      ${srcdir}/lib/libcrypt.minver $host_os $host_cpu \
> +-    2>&AS_MESSAGE_LOG_FD
> +-  )
> ++  SYMVER_FLOOR=GLIBC_2.0
> +   AC_MSG_RESULT([$SYMVER_FLOOR])
> +   case "$SYMVER_FLOOR" in
> +     ERROR)
> diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc
> b/meta/recipes-core/libxcrypt/libxcrypt.inc
> index e9f968b556..b5ca863d54 100644
> --- a/meta/recipes-core/libxcrypt/libxcrypt.inc
> +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc
> @@ -9,7 +9,9 @@ LIC_FILES_CHKSUM =
> "file://LICENSING;md5=bd5d9777dfe7076c4f2928f12fed226a \
>
>  inherit autotools pkgconfig
>
> -SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH}
> <http://github.com/besser82/libxcrypt.git;branch=$%7BSRCBRANCH%7D>"
> +SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH}
> <http://github.com/besser82/libxcrypt.git;branch=$%7BSRCBRANCH%7D> \
> +           file://0001-configure.ac-do-not-use-compute-symver-floor.patch
> \
> +           "
>  SRCREV = "94d84f92ca123d851586016c4678eb1f21c19029"
>  SRCBRANCH ?= "develop"
>
> --
> 2.29.2
>
>
> 
>
>

-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 4741 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [OE-core] [PATCH] libxcrypt: fix sporadic failures in nativesdk-libxcrypt-compat
  2021-03-18 21:22 ` [OE-core] " Christopher Larson
@ 2021-03-18 21:22   ` Christopher Larson
  0 siblings, 0 replies; 3+ messages in thread
From: Christopher Larson @ 2021-03-18 21:22 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 3693 bytes --]

Nevermind, of course it is. Ignore me.

On Thu, Mar 18, 2021 at 2:22 PM Christopher Larson <kergoth@gmail.com>
wrote:

> If it's been reported upstream, is Inappropriate the correct upstream
> status here?
>
> On Thu, Mar 18, 2021 at 3:57 AM Alexander Kanavin <alex.kanavin@gmail.com>
> wrote:
>
>> Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>> ---
>>  ...e.ac-do-not-use-compute-symver-floor.patch | 32 +++++++++++++++++++
>>  meta/recipes-core/libxcrypt/libxcrypt.inc     |  4 ++-
>>  2 files changed, 35 insertions(+), 1 deletion(-)
>>  create mode 100644
>> meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
>>
>> diff --git
>> a/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
>> b/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
>> new file mode 100644
>> index 0000000000..4e6b427104
>> --- /dev/null
>> +++
>> b/meta/recipes-core/libxcrypt/libxcrypt-compat/0001-configure.ac-do-not-use-compute-symver-floor.patch
>> @@ -0,0 +1,32 @@
>> +From b28bb856ccebe8fded51d11362bf5920699eed59 Mon Sep 17 00:00:00 2001
>> +From: Alexander Kanavin <alex.kanavin@gmail.com>
>> +Date: Thu, 18 Mar 2021 10:52:13 +0000
>> +Subject: [PATCH] configure.ac: do not use compute-symver-floor
>> +
>> +This script (newly introduced in 4.4.18) sporadically fails, without
>> +failing configure(), which has been reported at
>> +https://github.com/besser82/libxcrypt/issues/123
>> +
>> +Upstream-Status: Inappropriate
>> +Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
>> +---
>> + configure.ac | 6 +-----
>> + 1 file changed, 1 insertion(+), 5 deletions(-)
>> +
>> +diff --git a/configure.ac b/configure.ac
>> +index 45b91b4..f3ba945 100644
>> +--- a/configure.ac
>> ++++ b/configure.ac
>> +@@ -426,11 +426,7 @@ if test x$enable_shared != xyes; then
>> enable_obsolete_api=0; fi
>> + # need to be binary backward compatible with.
>> + if test $enable_obsolete_api = 1; then
>> +   AC_MSG_CHECKING([minimum symbol version to use for compatibility
>> symbols])
>> +-  SYMVER_FLOOR=$(
>> +-    $PERL ${srcdir}/build-aux/compute-symver-floor \
>> +-      ${srcdir}/lib/libcrypt.minver $host_os $host_cpu \
>> +-    2>&AS_MESSAGE_LOG_FD
>> +-  )
>> ++  SYMVER_FLOOR=GLIBC_2.0
>> +   AC_MSG_RESULT([$SYMVER_FLOOR])
>> +   case "$SYMVER_FLOOR" in
>> +     ERROR)
>> diff --git a/meta/recipes-core/libxcrypt/libxcrypt.inc
>> b/meta/recipes-core/libxcrypt/libxcrypt.inc
>> index e9f968b556..b5ca863d54 100644
>> --- a/meta/recipes-core/libxcrypt/libxcrypt.inc
>> +++ b/meta/recipes-core/libxcrypt/libxcrypt.inc
>> @@ -9,7 +9,9 @@ LIC_FILES_CHKSUM =
>> "file://LICENSING;md5=bd5d9777dfe7076c4f2928f12fed226a \
>>
>>  inherit autotools pkgconfig
>>
>> -SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH}
>> <http://github.com/besser82/libxcrypt.git;branch=$%7BSRCBRANCH%7D>"
>> +SRC_URI = "git://github.com/besser82/libxcrypt.git;branch=${SRCBRANCH}
>> <http://github.com/besser82/libxcrypt.git;branch=$%7BSRCBRANCH%7D> \
>> +
>>  file://0001-configure.ac-do-not-use-compute-symver-floor.patch \
>> +           "
>>  SRCREV = "94d84f92ca123d851586016c4678eb1f21c19029"
>>  SRCBRANCH ?= "develop"
>>
>> --
>> 2.29.2
>>
>>
>> 
>>
>>
>
> --
> Christopher Larson
> kergoth at gmail dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Senior Software Engineer, Mentor Graphics
>


-- 
Christopher Larson
kergoth at gmail dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 5403 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-18 21:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 10:57 [PATCH] libxcrypt: fix sporadic failures in nativesdk-libxcrypt-compat Alexander Kanavin
2021-03-18 21:22 ` [OE-core] " Christopher Larson
2021-03-18 21:22   ` Christopher Larson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.