* [PATCH V2] hwmon: (ina2xx) Convert sysfs sprintf/snprintf family to sysfs_emit
@ 2021-03-16 11:00 Jay Fang
2021-03-18 19:10 ` Guenter Roeck
0 siblings, 1 reply; 2+ messages in thread
From: Jay Fang @ 2021-03-16 11:00 UTC (permalink / raw)
To: linux, linux-hwmon; +Cc: tangzihao1, huangdaode
From: Zihao Tang <tangzihao1@hisilicon.com>
Fix the following coccicheck warning:
drivers/hwmon/ina2xx.c:313:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ina2xx.c:453:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ina2xx.c:484:8-16: WARNING: use scnprintf or sprintf
drivers/hwmon/ina2xx.c:540:8-16: WARNING: use scnprintf or sprintf
Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
---
drivers/hwmon/ina2xx.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
index ca97f9e..8acb2db 100644
--- a/drivers/hwmon/ina2xx.c
+++ b/drivers/hwmon/ina2xx.c
@@ -310,8 +310,7 @@ static ssize_t ina2xx_value_show(struct device *dev,
if (err < 0)
return err;
- return snprintf(buf, PAGE_SIZE, "%d\n",
- ina2xx_get_value(data, attr->index, regval));
+ return sysfs_emit(buf, "%d\n", ina2xx_get_value(data, attr->index, regval));
}
static int ina226_reg_to_alert(struct ina2xx_data *data, u8 bit, u16 regval)
@@ -450,7 +449,7 @@ static ssize_t ina226_alarm_show(struct device *dev,
alarm = (regval & BIT(attr->index)) &&
(regval & INA226_ALERT_FUNCTION_FLAG);
- return snprintf(buf, PAGE_SIZE, "%d\n", alarm);
+ return sysfs_emit(buf, "%d\n", alarm);
}
/*
@@ -481,7 +480,7 @@ static ssize_t ina2xx_shunt_show(struct device *dev,
{
struct ina2xx_data *data = dev_get_drvdata(dev);
- return snprintf(buf, PAGE_SIZE, "%li\n", data->rshunt);
+ return sysfs_emit(buf, "%li\n", data->rshunt);
}
static ssize_t ina2xx_shunt_store(struct device *dev,
@@ -537,7 +536,7 @@ static ssize_t ina226_interval_show(struct device *dev,
if (status)
return status;
- return snprintf(buf, PAGE_SIZE, "%d\n", ina226_reg_to_interval(regval));
+ return sysfs_emit(buf, "%d\n", ina226_reg_to_interval(regval));
}
/* shunt voltage */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] hwmon: (ina2xx) Convert sysfs sprintf/snprintf family to sysfs_emit
2021-03-16 11:00 [PATCH V2] hwmon: (ina2xx) Convert sysfs sprintf/snprintf family to sysfs_emit Jay Fang
@ 2021-03-18 19:10 ` Guenter Roeck
0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2021-03-18 19:10 UTC (permalink / raw)
To: Jay Fang; +Cc: linux-hwmon, tangzihao1, huangdaode
On Tue, Mar 16, 2021 at 07:00:57PM +0800, Jay Fang wrote:
> From: Zihao Tang <tangzihao1@hisilicon.com>
>
> Fix the following coccicheck warning:
>
> drivers/hwmon/ina2xx.c:313:8-16: WARNING: use scnprintf or sprintf
> drivers/hwmon/ina2xx.c:453:8-16: WARNING: use scnprintf or sprintf
> drivers/hwmon/ina2xx.c:484:8-16: WARNING: use scnprintf or sprintf
> drivers/hwmon/ina2xx.c:540:8-16: WARNING: use scnprintf or sprintf
>
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
> Signed-off-by: Jay Fang <f.fangjian@huawei.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/ina2xx.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> index ca97f9e..8acb2db 100644
> --- a/drivers/hwmon/ina2xx.c
> +++ b/drivers/hwmon/ina2xx.c
> @@ -310,8 +310,7 @@ static ssize_t ina2xx_value_show(struct device *dev,
> if (err < 0)
> return err;
>
> - return snprintf(buf, PAGE_SIZE, "%d\n",
> - ina2xx_get_value(data, attr->index, regval));
> + return sysfs_emit(buf, "%d\n", ina2xx_get_value(data, attr->index, regval));
> }
>
> static int ina226_reg_to_alert(struct ina2xx_data *data, u8 bit, u16 regval)
> @@ -450,7 +449,7 @@ static ssize_t ina226_alarm_show(struct device *dev,
>
> alarm = (regval & BIT(attr->index)) &&
> (regval & INA226_ALERT_FUNCTION_FLAG);
> - return snprintf(buf, PAGE_SIZE, "%d\n", alarm);
> + return sysfs_emit(buf, "%d\n", alarm);
> }
>
> /*
> @@ -481,7 +480,7 @@ static ssize_t ina2xx_shunt_show(struct device *dev,
> {
> struct ina2xx_data *data = dev_get_drvdata(dev);
>
> - return snprintf(buf, PAGE_SIZE, "%li\n", data->rshunt);
> + return sysfs_emit(buf, "%li\n", data->rshunt);
> }
>
> static ssize_t ina2xx_shunt_store(struct device *dev,
> @@ -537,7 +536,7 @@ static ssize_t ina226_interval_show(struct device *dev,
> if (status)
> return status;
>
> - return snprintf(buf, PAGE_SIZE, "%d\n", ina226_reg_to_interval(regval));
> + return sysfs_emit(buf, "%d\n", ina226_reg_to_interval(regval));
> }
>
> /* shunt voltage */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-18 19:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 11:00 [PATCH V2] hwmon: (ina2xx) Convert sysfs sprintf/snprintf family to sysfs_emit Jay Fang
2021-03-18 19:10 ` Guenter Roeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.