* [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-18 20:24 ` Bhaskar Chowdhury
0 siblings, 0 replies; 9+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-18 20:24 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, John.Clements, tao.zhou1, guchun.chen, Likun.Gao,
Bhawanpreet.Lakha, unixbhaskar, ray.huang, Jiansong.Chen,
amd-gfx, dri-devel, linux-kernel
Cc: rdunlap
s/traing/training/
...Plus the entire sentence construction for better readability.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
Changes from V1:
Alex and Randy's suggestions incorporated.
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index c325d6f53a71..bf3857867f51 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
/*
- * Long traing will encroach certain mount of bottom VRAM,
- * saving the content of this bottom VRAM to system memory
- * before training, and restoring it after training to avoid
- * VRAM corruption.
+ * Long training will encroach a certain amount on the bottom of VRAM;
+ * save the content from the bottom VRAM to system memory
+ * before training, and restore it after training to avoid
+ * VRAM corruption.
*/
sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
--
2.26.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-18 20:24 ` Bhaskar Chowdhury
0 siblings, 0 replies; 9+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-18 20:24 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, John.Clements, tao.zhou1, guchun.chen, Likun.Gao,
Bhawanpreet.Lakha, unixbhaskar, ray.huang, Jiansong.Chen,
amd-gfx, dri-devel, linux-kernel
Cc: rdunlap
s/traing/training/
...Plus the entire sentence construction for better readability.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
Changes from V1:
Alex and Randy's suggestions incorporated.
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index c325d6f53a71..bf3857867f51 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
/*
- * Long traing will encroach certain mount of bottom VRAM,
- * saving the content of this bottom VRAM to system memory
- * before training, and restoring it after training to avoid
- * VRAM corruption.
+ * Long training will encroach a certain amount on the bottom of VRAM;
+ * save the content from the bottom VRAM to system memory
+ * before training, and restore it after training to avoid
+ * VRAM corruption.
*/
sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-18 20:24 ` Bhaskar Chowdhury
0 siblings, 0 replies; 9+ messages in thread
From: Bhaskar Chowdhury @ 2021-03-18 20:24 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, John.Clements, tao.zhou1, guchun.chen, Likun.Gao,
Bhawanpreet.Lakha, unixbhaskar, ray.huang, Jiansong.Chen,
amd-gfx, dri-devel, linux-kernel
Cc: rdunlap
s/traing/training/
...Plus the entire sentence construction for better readability.
Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
---
Changes from V1:
Alex and Randy's suggestions incorporated.
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
index c325d6f53a71..bf3857867f51 100644
--- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
@@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
/*
- * Long traing will encroach certain mount of bottom VRAM,
- * saving the content of this bottom VRAM to system memory
- * before training, and restoring it after training to avoid
- * VRAM corruption.
+ * Long training will encroach a certain amount on the bottom of VRAM;
+ * save the content from the bottom VRAM to system memory
+ * before training, and restore it after training to avoid
+ * VRAM corruption.
*/
sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
--
2.26.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Fix a typo
2021-03-18 20:24 ` Bhaskar Chowdhury
(?)
@ 2021-03-20 2:27 ` Randy Dunlap
-1 siblings, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2021-03-20 2:27 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: alexander.deucher, christian.koenig, airlied, daniel,
Hawking.Zhang, John.Clements, tao.zhou1, guchun.chen, Likun.Gao,
Bhawanpreet.Lakha, ray.huang, Jiansong.Chen, amd-gfx, dri-devel,
linux-kernel
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
> s/traing/training/
>
> ...Plus the entire sentence construction for better readability.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V1:
> Alex and Randy's suggestions incorporated.
>
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index c325d6f53a71..bf3857867f51 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>
> if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> /*
> - * Long traing will encroach certain mount of bottom VRAM,
> - * saving the content of this bottom VRAM to system memory
> - * before training, and restoring it after training to avoid
> - * VRAM corruption.
> + * Long training will encroach a certain amount on the bottom of VRAM;
> + * save the content from the bottom VRAM to system memory
> + * before training, and restore it after training to avoid
> + * VRAM corruption.
These 3 new lines are indented with spaces instead of tabs. Oops. :(
(I may be too late with this comment -- sorry about that.)
> */
> sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
>
> --
> 2.26.2
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-20 2:27 ` Randy Dunlap
0 siblings, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2021-03-20 2:27 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: guchun.chen, airlied, Bhawanpreet.Lakha, tao.zhou1, linux-kernel,
amd-gfx, ray.huang, dri-devel, Jiansong.Chen, alexander.deucher,
Likun.Gao, John.Clements, christian.koenig, Hawking.Zhang
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
> s/traing/training/
>
> ...Plus the entire sentence construction for better readability.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V1:
> Alex and Randy's suggestions incorporated.
>
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index c325d6f53a71..bf3857867f51 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>
> if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> /*
> - * Long traing will encroach certain mount of bottom VRAM,
> - * saving the content of this bottom VRAM to system memory
> - * before training, and restoring it after training to avoid
> - * VRAM corruption.
> + * Long training will encroach a certain amount on the bottom of VRAM;
> + * save the content from the bottom VRAM to system memory
> + * before training, and restore it after training to avoid
> + * VRAM corruption.
These 3 new lines are indented with spaces instead of tabs. Oops. :(
(I may be too late with this comment -- sorry about that.)
> */
> sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
>
> --
> 2.26.2
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-20 2:27 ` Randy Dunlap
0 siblings, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2021-03-20 2:27 UTC (permalink / raw)
To: Bhaskar Chowdhury
Cc: guchun.chen, airlied, Bhawanpreet.Lakha, tao.zhou1, linux-kernel,
amd-gfx, ray.huang, dri-devel, daniel, Jiansong.Chen,
alexander.deucher, Likun.Gao, John.Clements, christian.koenig,
Hawking.Zhang
On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
> s/traing/training/
>
> ...Plus the entire sentence construction for better readability.
>
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V1:
> Alex and Randy's suggestions incorporated.
>
> drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> index c325d6f53a71..bf3857867f51 100644
> --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
>
> if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> /*
> - * Long traing will encroach certain mount of bottom VRAM,
> - * saving the content of this bottom VRAM to system memory
> - * before training, and restoring it after training to avoid
> - * VRAM corruption.
> + * Long training will encroach a certain amount on the bottom of VRAM;
> + * save the content from the bottom VRAM to system memory
> + * before training, and restore it after training to avoid
> + * VRAM corruption.
These 3 new lines are indented with spaces instead of tabs. Oops. :(
(I may be too late with this comment -- sorry about that.)
> */
> sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
>
> --
> 2.26.2
>
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Fix a typo
2021-03-20 2:27 ` Randy Dunlap
(?)
@ 2021-03-22 13:58 ` Alex Deucher
-1 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-03-22 13:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: Bhaskar Chowdhury, Chen, Guchun, Dave Airlie, Bhawanpreet Lakha,
Tao Zhou, LKML, amd-gfx list, Huang Rui,
Maling list - DRI developers, Jiansong Chen, Deucher, Alexander,
Likun Gao, John Clements, Christian Koenig, Hawking Zhang
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap
<rdunlap@bombadil.infradead.org> wrote:
>
>
>
> On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
> > s/traing/training/
> >
> > ...Plus the entire sentence construction for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > Changes from V1:
> > Alex and Randy's suggestions incorporated.
> >
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > index c325d6f53a71..bf3857867f51 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> >
> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> > /*
> > - * Long traing will encroach certain mount of bottom VRAM,
> > - * saving the content of this bottom VRAM to system memory
> > - * before training, and restoring it after training to avoid
> > - * VRAM corruption.
> > + * Long training will encroach a certain amount on the bottom of VRAM;
> > + * save the content from the bottom VRAM to system memory
> > + * before training, and restore it after training to avoid
> > + * VRAM corruption.
>
> These 3 new lines are indented with spaces instead of tabs. Oops. :(
>
> (I may be too late with this comment -- sorry about that.)
I fixed that up when I applied it.
Thanks,
Alex
>
> > */
> > sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
> >
> > --
> > 2.26.2
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-22 13:58 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-03-22 13:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: Bhaskar Chowdhury, Chen, Guchun, Dave Airlie, John Clements,
Tao Zhou, LKML, amd-gfx list, Huang Rui,
Maling list - DRI developers, Jiansong Chen, Deucher, Alexander,
Likun Gao, Bhawanpreet Lakha, Christian Koenig, Hawking Zhang
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap
<rdunlap@bombadil.infradead.org> wrote:
>
>
>
> On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
> > s/traing/training/
> >
> > ...Plus the entire sentence construction for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > Changes from V1:
> > Alex and Randy's suggestions incorporated.
> >
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > index c325d6f53a71..bf3857867f51 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> >
> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> > /*
> > - * Long traing will encroach certain mount of bottom VRAM,
> > - * saving the content of this bottom VRAM to system memory
> > - * before training, and restoring it after training to avoid
> > - * VRAM corruption.
> > + * Long training will encroach a certain amount on the bottom of VRAM;
> > + * save the content from the bottom VRAM to system memory
> > + * before training, and restore it after training to avoid
> > + * VRAM corruption.
>
> These 3 new lines are indented with spaces instead of tabs. Oops. :(
>
> (I may be too late with this comment -- sorry about that.)
I fixed that up when I applied it.
Thanks,
Alex
>
> > */
> > sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
> >
> > --
> > 2.26.2
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH V2] drm/amdgpu: Fix a typo
@ 2021-03-22 13:58 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-03-22 13:58 UTC (permalink / raw)
To: Randy Dunlap
Cc: Bhaskar Chowdhury, Chen, Guchun, Dave Airlie, John Clements,
Tao Zhou, LKML, amd-gfx list, Huang Rui,
Maling list - DRI developers, Jiansong Chen, Deucher, Alexander,
Likun Gao, Bhawanpreet Lakha, Christian Koenig, Hawking Zhang
On Sat, Mar 20, 2021 at 3:52 AM Randy Dunlap
<rdunlap@bombadil.infradead.org> wrote:
>
>
>
> On Fri, 19 Mar 2021, Bhaskar Chowdhury wrote:
>
> > s/traing/training/
> >
> > ...Plus the entire sentence construction for better readability.
> >
> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > ---
> > Changes from V1:
> > Alex and Randy's suggestions incorporated.
> >
> > drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > index c325d6f53a71..bf3857867f51 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/psp_v11_0.c
> > @@ -661,10 +661,10 @@ static int psp_v11_0_memory_training(struct psp_context *psp, uint32_t ops)
> >
> > if (ops & PSP_MEM_TRAIN_SEND_LONG_MSG) {
> > /*
> > - * Long traing will encroach certain mount of bottom VRAM,
> > - * saving the content of this bottom VRAM to system memory
> > - * before training, and restoring it after training to avoid
> > - * VRAM corruption.
> > + * Long training will encroach a certain amount on the bottom of VRAM;
> > + * save the content from the bottom VRAM to system memory
> > + * before training, and restore it after training to avoid
> > + * VRAM corruption.
>
> These 3 new lines are indented with spaces instead of tabs. Oops. :(
>
> (I may be too late with this comment -- sorry about that.)
I fixed that up when I applied it.
Thanks,
Alex
>
> > */
> > sz = GDDR6_MEM_TRAINING_ENCROACHED_SIZE;
> >
> > --
> > 2.26.2
> >
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-03-22 13:59 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-18 20:24 [PATCH V2] drm/amdgpu: Fix a typo Bhaskar Chowdhury
2021-03-18 20:24 ` Bhaskar Chowdhury
2021-03-18 20:24 ` Bhaskar Chowdhury
2021-03-20 2:27 ` Randy Dunlap
2021-03-20 2:27 ` Randy Dunlap
2021-03-20 2:27 ` Randy Dunlap
2021-03-22 13:58 ` Alex Deucher
2021-03-22 13:58 ` Alex Deucher
2021-03-22 13:58 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.