* [chrome-os:chromeos-5.4 11/13] drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv'
@ 2021-03-19 8:18 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-03-19 8:18 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3445 bytes --]
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: aaac331bb0ff1bdb6ca7d9f12634a7028df6addc
commit: b182d75023cbf6ff0ab079ac0377399d6096d7c2 [11/13] CHROMIUM: drm/virtio: implement context init: support init ioctl
config: i386-randconfig-m021-20210318 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv'
vim +/vfpriv +315 drivers/gpu/drm/virtio/virtgpu_kms.c
62fb7a5e10962a Gerd Hoffmann 2014-10-28 295 int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 296 {
62fb7a5e10962a Gerd Hoffmann 2014-10-28 297 struct virtio_gpu_device *vgdev = dev->dev_private;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 298 struct virtio_gpu_fpriv *vfpriv;
b182d75023cbf6 Ryan Neph 2021-02-02 299 int handle;
a86f25518e3ab7 Michał Mirosław 2017-08-31 300 char dbgname[TASK_COMM_LEN];
62fb7a5e10962a Gerd Hoffmann 2014-10-28 301
62fb7a5e10962a Gerd Hoffmann 2014-10-28 302 /* can't create contexts without 3d renderer */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 303 if (!vgdev->has_virgl_3d)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 304 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 305
62fb7a5e10962a Gerd Hoffmann 2014-10-28 306 /* allocate a virt GPU context for this opener */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 307 vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 308 if (!vfpriv)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 309 return -ENOMEM;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 310
a86f25518e3ab7 Michał Mirosław 2017-08-31 311 get_task_comm(dbgname, current);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 312
b182d75023cbf6 Ryan Neph 2021-02-02 313 handle = ida_alloc(&vgdev->ctx_id_ida, GFP_KERNEL);
b182d75023cbf6 Ryan Neph 2021-02-02 314 if (handle < 0)
b182d75023cbf6 Ryan Neph 2021-02-02 @315 return handle;
kfree(vfpriv);
b182d75023cbf6 Ryan Neph 2021-02-02 316
b182d75023cbf6 Ryan Neph 2021-02-02 317 vfpriv->ctx_id = handle + 1;
b182d75023cbf6 Ryan Neph 2021-02-02 318
b182d75023cbf6 Ryan Neph 2021-02-02 319 /* create the default context without context_init flags for
b182d75023cbf6 Ryan Neph 2021-02-02 320 * back-compatibility
b182d75023cbf6 Ryan Neph 2021-02-02 321 */
b182d75023cbf6 Ryan Neph 2021-02-02 322 virtio_gpu_cmd_context_create(vgdev, vfpriv->ctx_id, 0, strlen(dbgname),
b182d75023cbf6 Ryan Neph 2021-02-02 323 dbgname);
b182d75023cbf6 Ryan Neph 2021-02-02 324
62fb7a5e10962a Gerd Hoffmann 2014-10-28 325 file->driver_priv = vfpriv;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 326 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 327 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35549 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [kbuild] [chrome-os:chromeos-5.4 11/13] drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv'
@ 2021-03-19 8:18 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2021-03-19 8:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3445 bytes --]
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: aaac331bb0ff1bdb6ca7d9f12634a7028df6addc
commit: b182d75023cbf6ff0ab079ac0377399d6096d7c2 [11/13] CHROMIUM: drm/virtio: implement context init: support init ioctl
config: i386-randconfig-m021-20210318 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv'
vim +/vfpriv +315 drivers/gpu/drm/virtio/virtgpu_kms.c
62fb7a5e10962a Gerd Hoffmann 2014-10-28 295 int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 296 {
62fb7a5e10962a Gerd Hoffmann 2014-10-28 297 struct virtio_gpu_device *vgdev = dev->dev_private;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 298 struct virtio_gpu_fpriv *vfpriv;
b182d75023cbf6 Ryan Neph 2021-02-02 299 int handle;
a86f25518e3ab7 Michał Mirosław 2017-08-31 300 char dbgname[TASK_COMM_LEN];
62fb7a5e10962a Gerd Hoffmann 2014-10-28 301
62fb7a5e10962a Gerd Hoffmann 2014-10-28 302 /* can't create contexts without 3d renderer */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 303 if (!vgdev->has_virgl_3d)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 304 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 305
62fb7a5e10962a Gerd Hoffmann 2014-10-28 306 /* allocate a virt GPU context for this opener */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 307 vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 308 if (!vfpriv)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 309 return -ENOMEM;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 310
a86f25518e3ab7 Michał Mirosław 2017-08-31 311 get_task_comm(dbgname, current);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 312
b182d75023cbf6 Ryan Neph 2021-02-02 313 handle = ida_alloc(&vgdev->ctx_id_ida, GFP_KERNEL);
b182d75023cbf6 Ryan Neph 2021-02-02 314 if (handle < 0)
b182d75023cbf6 Ryan Neph 2021-02-02 @315 return handle;
kfree(vfpriv);
b182d75023cbf6 Ryan Neph 2021-02-02 316
b182d75023cbf6 Ryan Neph 2021-02-02 317 vfpriv->ctx_id = handle + 1;
b182d75023cbf6 Ryan Neph 2021-02-02 318
b182d75023cbf6 Ryan Neph 2021-02-02 319 /* create the default context without context_init flags for
b182d75023cbf6 Ryan Neph 2021-02-02 320 * back-compatibility
b182d75023cbf6 Ryan Neph 2021-02-02 321 */
b182d75023cbf6 Ryan Neph 2021-02-02 322 virtio_gpu_cmd_context_create(vgdev, vfpriv->ctx_id, 0, strlen(dbgname),
b182d75023cbf6 Ryan Neph 2021-02-02 323 dbgname);
b182d75023cbf6 Ryan Neph 2021-02-02 324
62fb7a5e10962a Gerd Hoffmann 2014-10-28 325 file->driver_priv = vfpriv;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 326 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 327 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35549 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [chrome-os:chromeos-5.4 11/13] drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv'
@ 2021-03-19 8:09 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2021-03-19 8:09 UTC (permalink / raw)
To: kbuild
[-- Attachment #1: Type: text/plain, Size: 3552 bytes --]
CC: kbuild-all(a)lists.01.org
TO: cros-kernel-buildreports(a)googlegroups.com
TO: Guenter Roeck <groeck@google.com>
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: aaac331bb0ff1bdb6ca7d9f12634a7028df6addc
commit: b182d75023cbf6ff0ab079ac0377399d6096d7c2 [11/13] CHROMIUM: drm/virtio: implement context init: support init ioctl
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
config: i386-randconfig-m021-20210318 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv'
vim +/vfpriv +315 drivers/gpu/drm/virtio/virtgpu_kms.c
62fb7a5e10962a Gerd Hoffmann 2014-10-28 294
62fb7a5e10962a Gerd Hoffmann 2014-10-28 295 int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 296 {
62fb7a5e10962a Gerd Hoffmann 2014-10-28 297 struct virtio_gpu_device *vgdev = dev->dev_private;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 298 struct virtio_gpu_fpriv *vfpriv;
b182d75023cbf6 Ryan Neph 2021-02-02 299 int handle;
a86f25518e3ab7 Michał Mirosław 2017-08-31 300 char dbgname[TASK_COMM_LEN];
62fb7a5e10962a Gerd Hoffmann 2014-10-28 301
62fb7a5e10962a Gerd Hoffmann 2014-10-28 302 /* can't create contexts without 3d renderer */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 303 if (!vgdev->has_virgl_3d)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 304 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 305
62fb7a5e10962a Gerd Hoffmann 2014-10-28 306 /* allocate a virt GPU context for this opener */
62fb7a5e10962a Gerd Hoffmann 2014-10-28 307 vfpriv = kzalloc(sizeof(*vfpriv), GFP_KERNEL);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 308 if (!vfpriv)
62fb7a5e10962a Gerd Hoffmann 2014-10-28 309 return -ENOMEM;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 310
a86f25518e3ab7 Michał Mirosław 2017-08-31 311 get_task_comm(dbgname, current);
62fb7a5e10962a Gerd Hoffmann 2014-10-28 312
b182d75023cbf6 Ryan Neph 2021-02-02 313 handle = ida_alloc(&vgdev->ctx_id_ida, GFP_KERNEL);
b182d75023cbf6 Ryan Neph 2021-02-02 314 if (handle < 0)
b182d75023cbf6 Ryan Neph 2021-02-02 @315 return handle;
b182d75023cbf6 Ryan Neph 2021-02-02 316
b182d75023cbf6 Ryan Neph 2021-02-02 317 vfpriv->ctx_id = handle + 1;
b182d75023cbf6 Ryan Neph 2021-02-02 318
b182d75023cbf6 Ryan Neph 2021-02-02 319 /* create the default context without context_init flags for
b182d75023cbf6 Ryan Neph 2021-02-02 320 * back-compatibility
b182d75023cbf6 Ryan Neph 2021-02-02 321 */
b182d75023cbf6 Ryan Neph 2021-02-02 322 virtio_gpu_cmd_context_create(vgdev, vfpriv->ctx_id, 0, strlen(dbgname),
b182d75023cbf6 Ryan Neph 2021-02-02 323 dbgname);
b182d75023cbf6 Ryan Neph 2021-02-02 324
62fb7a5e10962a Gerd Hoffmann 2014-10-28 325 file->driver_priv = vfpriv;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 326 return 0;
62fb7a5e10962a Gerd Hoffmann 2014-10-28 327 }
62fb7a5e10962a Gerd Hoffmann 2014-10-28 328
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 35549 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-19 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 8:18 [chrome-os:chromeos-5.4 11/13] drivers/gpu/drm/virtio/virtgpu_kms.c:315 virtio_gpu_driver_open() warn: possible memory leak of 'vfpriv' Dan Carpenter
2021-03-19 8:18 ` [kbuild] " Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2021-03-19 8:09 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.