* [PATCH] drm/amdgpu: remove irq_src->data handling
@ 2021-03-19 12:25 Christian König
2021-03-23 14:51 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Christian König @ 2021-03-19 12:25 UTC (permalink / raw)
To: amd-gfx; +Cc: Emily.Deng
That is unused for quite some time now.
Signed-off-by: Christian König <christian.koenig@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 5 -----
drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
index af026109421a..03412543427a 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
@@ -382,11 +382,6 @@ void amdgpu_irq_fini(struct amdgpu_device *adev)
kfree(src->enabled_types);
src->enabled_types = NULL;
- if (src->data) {
- kfree(src->data);
- kfree(src);
- adev->irq.client[i].sources[j] = NULL;
- }
}
kfree(adev->irq.client[i].sources);
adev->irq.client[i].sources = NULL;
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
index ac527e5deae6..cf6116648322 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
@@ -62,7 +62,6 @@ struct amdgpu_irq_src {
unsigned num_types;
atomic_t *enabled_types;
const struct amdgpu_irq_src_funcs *funcs;
- void *data;
};
struct amdgpu_irq_client {
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdgpu: remove irq_src->data handling
2021-03-19 12:25 [PATCH] drm/amdgpu: remove irq_src->data handling Christian König
@ 2021-03-23 14:51 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2021-03-23 14:51 UTC (permalink / raw)
To: Christian König; +Cc: Emily Deng, amd-gfx list
On Fri, Mar 19, 2021 at 8:25 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> That is unused for quite some time now.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 5 -----
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h | 1 -
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index af026109421a..03412543427a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -382,11 +382,6 @@ void amdgpu_irq_fini(struct amdgpu_device *adev)
>
> kfree(src->enabled_types);
> src->enabled_types = NULL;
> - if (src->data) {
> - kfree(src->data);
> - kfree(src);
> - adev->irq.client[i].sources[j] = NULL;
> - }
> }
> kfree(adev->irq.client[i].sources);
> adev->irq.client[i].sources = NULL;
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
> index ac527e5deae6..cf6116648322 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.h
> @@ -62,7 +62,6 @@ struct amdgpu_irq_src {
> unsigned num_types;
> atomic_t *enabled_types;
> const struct amdgpu_irq_src_funcs *funcs;
> - void *data;
> };
>
> struct amdgpu_irq_client {
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-23 14:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-19 12:25 [PATCH] drm/amdgpu: remove irq_src->data handling Christian König
2021-03-23 14:51 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.