All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tretter <m.tretter@pengutronix.de>
To: netdev@vger.kernel.org, devicetree@vger.kernel.org
Cc: m.tretter@pengutronix.de, kernel@pengutronix.de,
	robh+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com,
	dmurphy@ti.com
Subject: [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree
Date: Fri, 19 Mar 2021 16:57:08 +0100	[thread overview]
Message-ID: <20210319155710.2793637-1-m.tretter@pengutronix.de> (raw)

Hello,

The dp83867 has 4 LED pins, which can be multiplexed with different functions
of the phy.

This series adds a device tree binding to describe the multiplexing of the
functions to the LEDs and implements the binding for the dp83867 phy.

I found existing bindings for configuring the LED modes for other phys:

In Documentation/devicetree/bindings/net/micrel.txt, the binding is not
flexible enough for the use case in the dp83867, because there is a value for
each LED configuration, which would be a lot of values for the dp83867.

In Documentation/devicetree/bindings/net/mscc-phy-vsc8532.txt, there is a
separate property for each LED, which would work, but I found rather
unintuitive compared to how clock bindings etc. work.

The new binding defines two properties: one for the led names and another
property for the modes of the LEDs with defined values in the same order.
Currently, the binding is specific to the dp83867, but I guess that the
binding could be made more generic and used for other phys, too.

Let me know, what you think.

Michael

Michael Tretter (1):
  dt-bindings: dp83867: Add binding for LED mode configuration

Thomas Haemmerle (1):
  net: phy: dp83867: add support for changing LED modes

 .../devicetree/bindings/net/ti,dp83867.yaml   | 24 ++++++++
 drivers/net/phy/dp83867.c                     | 57 +++++++++++++++++++
 include/dt-bindings/net/ti-dp83867.h          | 16 ++++++
 3 files changed, 97 insertions(+)

-- 
2.29.2


             reply	other threads:[~2021-03-19 15:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 15:57 Michael Tretter [this message]
2021-03-19 15:57 ` [PATCH 1/2] dt-bindings: dp83867: Add binding for LED mode configuration Michael Tretter
2021-03-19 21:49   ` Rob Herring
2021-03-19 15:57 ` [PATCH 2/2] net: phy: dp83867: add support for changing LED modes Michael Tretter
2021-03-19 16:14   ` Michael Tretter
2021-03-19 18:14   ` kernel test robot
2021-03-19 18:14     ` kernel test robot
2021-03-20  0:46   ` kernel test robot
2021-03-20  0:46     ` kernel test robot
2021-03-20  3:41   ` kernel test robot
2021-03-20  3:41     ` kernel test robot
2021-03-19 21:19 ` [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree Andrew Lunn
2021-03-22  7:39   ` Michael Tretter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210319155710.2793637-1-m.tretter@pengutronix.de \
    --to=m.tretter@pengutronix.de \
    --cc=andrew@lunn.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dmurphy@ti.com \
    --cc=hkallweit1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.