From: kernel test robot <lkp@intel.com> To: Michael Tretter <m.tretter@pengutronix.de>, netdev@vger.kernel.org, devicetree@vger.kernel.org Cc: kbuild-all@lists.01.org, m.tretter@pengutronix.de, kernel@pengutronix.de, robh+dt@kernel.org, andrew@lunn.ch, hkallweit1@gmail.com, dmurphy@ti.com Subject: Re: [PATCH 2/2] net: phy: dp83867: add support for changing LED modes Date: Sat, 20 Mar 2021 02:14:36 +0800 [thread overview] Message-ID: <202103200214.pMIoAXiR-lkp@intel.com> (raw) In-Reply-To: <20210319155710.2793637-3-m.tretter@pengutronix.de> [-- Attachment #1: Type: text/plain, Size: 3260 bytes --] Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net/master ipvs/master net-next/master v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Tretter/net-phy-dp83867-Configure-LED-modes-via-device-tree/20210320-000027 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/740c2de62bc36c66a54a8c152a65ae2ebf805515 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Tretter/net-phy-dp83867-Configure-LED-modes-via-device-tree/20210320-000027 git checkout 740c2de62bc36c66a54a8c152a65ae2ebf805515 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/net/phy/dp83867.c: In function 'dp83867_of_led_mode_read': >> drivers/net/phy/dp83867.c:550:14: warning: passing argument 4 of 'of_property_read_u32_index' makes pointer from integer without a cast [-Wint-conversion] 550 | index, tmp); | ^~~ | | | u32 {aka unsigned int} In file included from drivers/net/phy/dp83867.c:11: include/linux/of.h:311:28: note: expected 'u32 *' {aka 'unsigned int *'} but argument is of type 'u32' {aka 'unsigned int'} 311 | u32 index, u32 *out_value); | ~~~~~^~~~~~~~~ >> drivers/net/phy/dp83867.c:549:8: warning: 'tmp' is used uninitialized in this function [-Wuninitialized] 549 | err = of_property_read_u32_index(of_node, "ti,dp83867-led-modes", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 550 | index, tmp); | ~~~~~~~~~~~ vim +/of_property_read_u32_index +550 drivers/net/phy/dp83867.c 538 539 #if IS_ENABLED(CONFIG_OF_MDIO) 540 static int dp83867_of_led_mode_read(struct device_node *of_node, 541 const char *led_name, u32 *mode) 542 { 543 u32 tmp; 544 int index; 545 int err; 546 547 index = of_property_match_string(of_node, "ti,dp83867-led-mode-names", 548 led_name); > 549 err = of_property_read_u32_index(of_node, "ti,dp83867-led-modes", > 550 index, tmp); 551 if (err) 552 return err; 553 if (tmp == 0xc || tmp >= 0xf) 554 return -EINVAL; 555 556 *mode = tmp; 557 558 return 0; 559 } 560 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 67276 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com> To: kbuild-all@lists.01.org Subject: Re: [PATCH 2/2] net: phy: dp83867: add support for changing LED modes Date: Sat, 20 Mar 2021 02:14:36 +0800 [thread overview] Message-ID: <202103200214.pMIoAXiR-lkp@intel.com> (raw) In-Reply-To: <20210319155710.2793637-3-m.tretter@pengutronix.de> [-- Attachment #1: Type: text/plain, Size: 3337 bytes --] Hi Michael, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on net/master ipvs/master net-next/master v5.12-rc3 next-20210319] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Michael-Tretter/net-phy-dp83867-Configure-LED-modes-via-device-tree/20210320-000027 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: xtensa-allyesconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/740c2de62bc36c66a54a8c152a65ae2ebf805515 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Michael-Tretter/net-phy-dp83867-Configure-LED-modes-via-device-tree/20210320-000027 git checkout 740c2de62bc36c66a54a8c152a65ae2ebf805515 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> All warnings (new ones prefixed by >>): drivers/net/phy/dp83867.c: In function 'dp83867_of_led_mode_read': >> drivers/net/phy/dp83867.c:550:14: warning: passing argument 4 of 'of_property_read_u32_index' makes pointer from integer without a cast [-Wint-conversion] 550 | index, tmp); | ^~~ | | | u32 {aka unsigned int} In file included from drivers/net/phy/dp83867.c:11: include/linux/of.h:311:28: note: expected 'u32 *' {aka 'unsigned int *'} but argument is of type 'u32' {aka 'unsigned int'} 311 | u32 index, u32 *out_value); | ~~~~~^~~~~~~~~ >> drivers/net/phy/dp83867.c:549:8: warning: 'tmp' is used uninitialized in this function [-Wuninitialized] 549 | err = of_property_read_u32_index(of_node, "ti,dp83867-led-modes", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 550 | index, tmp); | ~~~~~~~~~~~ vim +/of_property_read_u32_index +550 drivers/net/phy/dp83867.c 538 539 #if IS_ENABLED(CONFIG_OF_MDIO) 540 static int dp83867_of_led_mode_read(struct device_node *of_node, 541 const char *led_name, u32 *mode) 542 { 543 u32 tmp; 544 int index; 545 int err; 546 547 index = of_property_match_string(of_node, "ti,dp83867-led-mode-names", 548 led_name); > 549 err = of_property_read_u32_index(of_node, "ti,dp83867-led-modes", > 550 index, tmp); 551 if (err) 552 return err; 553 if (tmp == 0xc || tmp >= 0xf) 554 return -EINVAL; 555 556 *mode = tmp; 557 558 return 0; 559 } 560 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org [-- Attachment #2: config.gz --] [-- Type: application/gzip, Size: 67276 bytes --]
next prev parent reply other threads:[~2021-03-19 18:16 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 15:57 [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree Michael Tretter 2021-03-19 15:57 ` [PATCH 1/2] dt-bindings: dp83867: Add binding for LED mode configuration Michael Tretter 2021-03-19 21:49 ` Rob Herring 2021-03-19 15:57 ` [PATCH 2/2] net: phy: dp83867: add support for changing LED modes Michael Tretter 2021-03-19 16:14 ` Michael Tretter 2021-03-19 18:14 ` kernel test robot [this message] 2021-03-19 18:14 ` kernel test robot 2021-03-20 0:46 ` kernel test robot 2021-03-20 0:46 ` kernel test robot 2021-03-20 3:41 ` kernel test robot 2021-03-20 3:41 ` kernel test robot 2021-03-19 21:19 ` [PATCH 0/2] net: phy: dp83867: Configure LED modes via device tree Andrew Lunn 2021-03-22 7:39 ` Michael Tretter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=202103200214.pMIoAXiR-lkp@intel.com \ --to=lkp@intel.com \ --cc=andrew@lunn.ch \ --cc=devicetree@vger.kernel.org \ --cc=dmurphy@ti.com \ --cc=hkallweit1@gmail.com \ --cc=kbuild-all@lists.01.org \ --cc=kernel@pengutronix.de \ --cc=m.tretter@pengutronix.de \ --cc=netdev@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.