From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Daniele.Palmas@telit.com, bjorn.andersson@linaro.org Subject: Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory Date: Mon, 22 Mar 2021 15:10:40 +0530 [thread overview] Message-ID: <20210322094040.GB70634@thinkpad> (raw) In-Reply-To: <20210319175659.17c9e8e6@collabora.com> On Fri, Mar 19, 2021 at 05:56:59PM +0100, Boris Brezillon wrote: > On Fri, 19 Mar 2021 20:30:10 +0530 > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > > @@ -2737,6 +2783,11 @@ static int nand_read_page_swecc(struct nand_chip *chip, uint8_t *buf, > > uint8_t *ecc_code = chip->ecc.code_buf; > > unsigned int max_bitflips = 0; > > > > + /* Check if the region is secured */ > > + ret = nand_check_secure_region(chip, ((loff_t)page << chip->page_shift), 0); > > + if (ret) > > + return ret; > > + > > I'm lost. Why do you need to do that here if it's already done in > nand_do_read_{ops,oob}()? > I think that's a mistake. Will remove it. Thanks, Mani > > chip->ecc.read_page_raw(chip, buf, 1, page); > > > > for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize)
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Boris Brezillon <boris.brezillon@collabora.com> Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Daniele.Palmas@telit.com, bjorn.andersson@linaro.org Subject: Re: [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory Date: Mon, 22 Mar 2021 15:10:40 +0530 [thread overview] Message-ID: <20210322094040.GB70634@thinkpad> (raw) In-Reply-To: <20210319175659.17c9e8e6@collabora.com> On Fri, Mar 19, 2021 at 05:56:59PM +0100, Boris Brezillon wrote: > On Fri, 19 Mar 2021 20:30:10 +0530 > Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote: > > > @@ -2737,6 +2783,11 @@ static int nand_read_page_swecc(struct nand_chip *chip, uint8_t *buf, > > uint8_t *ecc_code = chip->ecc.code_buf; > > unsigned int max_bitflips = 0; > > > > + /* Check if the region is secured */ > > + ret = nand_check_secure_region(chip, ((loff_t)page << chip->page_shift), 0); > > + if (ret) > > + return ret; > > + > > I'm lost. Why do you need to do that here if it's already done in > nand_do_read_{ops,oob}()? > I think that's a mistake. Will remove it. Thanks, Mani > > chip->ecc.read_page_raw(chip, buf, 1, page); > > > > for (i = 0; eccsteps; eccsteps--, i += eccbytes, p += eccsize) ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-03-22 9:41 UTC|newest] Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-19 15:00 [PATCH v7 0/3] Add support for secure regions in NAND Manivannan Sadhasivam 2021-03-19 15:00 ` Manivannan Sadhasivam 2021-03-19 15:00 ` [PATCH v7 1/3] dt-bindings: mtd: Convert Qcom NANDc binding to YAML Manivannan Sadhasivam 2021-03-19 15:00 ` Manivannan Sadhasivam 2021-03-19 15:00 ` [PATCH v7 2/3] dt-bindings: mtd: Add a property to declare secure regions in NAND chips Manivannan Sadhasivam 2021-03-19 15:00 ` Manivannan Sadhasivam 2021-03-19 15:00 ` [PATCH v7 3/3] mtd: rawnand: Add support for secure regions in NAND memory Manivannan Sadhasivam 2021-03-19 15:00 ` Manivannan Sadhasivam 2021-03-19 16:52 ` Boris Brezillon 2021-03-19 16:52 ` Boris Brezillon 2021-03-22 9:39 ` Manivannan Sadhasivam 2021-03-22 9:39 ` Manivannan Sadhasivam 2021-03-19 16:56 ` Boris Brezillon 2021-03-19 16:56 ` Boris Brezillon 2021-03-22 9:40 ` Manivannan Sadhasivam [this message] 2021-03-22 9:40 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210322094040.GB70634@thinkpad \ --to=manivannan.sadhasivam@linaro.org \ --cc=Daniele.Palmas@telit.com \ --cc=bjorn.andersson@linaro.org \ --cc=boris.brezillon@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.