[meta-python][PATCH] python3-hexdump: Move cleanup_hexfile into install_append

[meta-python][PATCH] python3-hexdump: Move cleanup_hexfile into install_append

[Khem Raj]

This fixes error seen during staging phase
run.sysroot_stage_all.902827: line 182: cd: TOPDIR/build/tmpfs/work/core2-32-yoe-linux-musl/python3-hexdump/3.3-r0/image/usr/share: No such file or directory

this happens because D is being altered outside pseudo's context, and
alterning D is done after do_install ends so its likely going to race as
well with subsequent functions and change pseudo context too

Fixes occasionally seen build failures on autobuilders

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Andrew Jeffery <andrew@aj.id.au>
---
 meta-python/recipes-devtools/python/python3-hexdump_3.3.bb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/meta-python/recipes-devtools/python/python3-hexdump_3.3.bb b/meta-python/recipes-devtools/python/python3-hexdump_3.3.bb
index cb04e17dfd..5325048039 100644
--- a/meta-python/recipes-devtools/python/python3-hexdump_3.3.bb
+++ b/meta-python/recipes-devtools/python/python3-hexdump_3.3.bb
@@ -19,9 +19,7 @@ S = "${WORKDIR}"
 
 BBCLASSEXTEND = "native nativesdk"
 
-do_cleanup_hexfile() {
+do_install_append() {
     rm ${D}${datadir}/data/hexfile.bin
     rmdir ${D}${datadir}/data ${D}${datadir}
 }
-
-addtask cleanup_hexfile before do_package after do_install
-- 
2.31.0

Re: [meta-python][PATCH] python3-hexdump: Move cleanup_hexfile into install_append

[Andrew Jeffery]

On Tue, 23 Mar 2021, at 08:52, Khem Raj wrote:
> This fixes error seen during staging phase
> run.sysroot_stage_all.902827: line 182: cd: 
> TOPDIR/build/tmpfs/work/core2-32-yoe-linux-musl/python3-hexdump/3.3-r0/image/usr/share: No such file or directory
> 
> this happens because D is being altered outside pseudo's context, and
> alterning D is done after do_install ends so its likely going to race as
> well with subsequent functions and change pseudo context too
> 
> Fixes occasionally seen build failures on autobuilders
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Andrew Jeffery <andrew@aj.id.au>

Ah, interesting.

Thanks Khem.

Acked-by: Andrew Jeffery <andrew@aj.id.au>