All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: <linux-f2fs-devel@lists.sourceforge.net>,
	<linux-kernel@vger.kernel.org>, <chao@kernel.org>,
	Chao Yu <yuchao0@huawei.com>
Subject: [PATCH] Revert "f2fs: give a warning only for readonly partition"
Date: Tue, 23 Mar 2021 14:41:55 +0800	[thread overview]
Message-ID: <20210323064155.12582-1-yuchao0@huawei.com> (raw)

This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789.

Because that commit fails generic/050 testcase which expect failure
during mount a recoverable readonly partition.

Fixes: 938a184265d7 ("f2fs: give a warning only for readonly partition")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/super.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index b48281642e98..2b78ee11f093 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3952,10 +3952,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 		 * previous checkpoint was not done by clean system shutdown.
 		 */
 		if (f2fs_hw_is_readonly(sbi)) {
-			if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG))
+			if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) {
+				err = -EROFS;
 				f2fs_err(sbi, "Need to recover fsync data, but write access unavailable");
-			else
-				f2fs_info(sbi, "write access unavailable, skipping recovery");
+				goto free_meta;
+			}
+			f2fs_info(sbi, "write access unavailable, skipping recovery");
 			goto reset_checkpoint;
 		}
 
-- 
2.29.2


WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com>
To: <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: [f2fs-dev] [PATCH] Revert "f2fs: give a warning only for readonly partition"
Date: Tue, 23 Mar 2021 14:41:55 +0800	[thread overview]
Message-ID: <20210323064155.12582-1-yuchao0@huawei.com> (raw)

This reverts commit 938a184265d75ea474f1c6fe1da96a5196163789.

Because that commit fails generic/050 testcase which expect failure
during mount a recoverable readonly partition.

Fixes: 938a184265d7 ("f2fs: give a warning only for readonly partition")
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/super.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index b48281642e98..2b78ee11f093 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -3952,10 +3952,12 @@ static int f2fs_fill_super(struct super_block *sb, void *data, int silent)
 		 * previous checkpoint was not done by clean system shutdown.
 		 */
 		if (f2fs_hw_is_readonly(sbi)) {
-			if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG))
+			if (!is_set_ckpt_flags(sbi, CP_UMOUNT_FLAG)) {
+				err = -EROFS;
 				f2fs_err(sbi, "Need to recover fsync data, but write access unavailable");
-			else
-				f2fs_info(sbi, "write access unavailable, skipping recovery");
+				goto free_meta;
+			}
+			f2fs_info(sbi, "write access unavailable, skipping recovery");
 			goto reset_checkpoint;
 		}
 
-- 
2.29.2



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

             reply	other threads:[~2021-03-23  6:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-23  6:41 Chao Yu [this message]
2021-03-23  6:41 ` [f2fs-dev] [PATCH] Revert "f2fs: give a warning only for readonly partition" Chao Yu
2021-03-23 18:39 ` Jaegeuk Kim
2021-03-23 18:39   ` [f2fs-dev] " Jaegeuk Kim
2021-03-24  1:57   ` Chao Yu
2021-03-24  1:57     ` [f2fs-dev] " Chao Yu
2021-03-24  4:22     ` Jaegeuk Kim
2021-03-24  4:22       ` [f2fs-dev] " Jaegeuk Kim
2021-03-24  7:48       ` Chao Yu
2021-03-24  7:48         ` [f2fs-dev] " Chao Yu
2021-03-24 22:44         ` Jaegeuk Kim
2021-03-24 22:44           ` [f2fs-dev] " Jaegeuk Kim
2021-03-25  1:59           ` Chao Yu
2021-03-25  1:59             ` [f2fs-dev] " Chao Yu
2021-03-26  1:08             ` Chao Yu
2021-03-26  1:08               ` Chao Yu
2021-03-26  1:19               ` Jaegeuk Kim
2021-03-26  1:19                 ` Jaegeuk Kim
2021-03-26  1:34                 ` Chao Yu
2021-03-26  1:34                   ` Chao Yu
2021-03-26 17:30                   ` Jaegeuk Kim
2021-03-26 17:30                     ` Jaegeuk Kim
2021-03-27  1:52                     ` Chao Yu
2021-03-27  1:52                       ` Chao Yu
2021-03-27 10:03                       ` Chao Yu
2021-03-27 10:03                         ` Chao Yu
2021-03-31  1:57                         ` Jaegeuk Kim
2021-03-31  1:57                           ` Jaegeuk Kim
2021-03-31  3:17                           ` Chao Yu
2021-03-31  3:17                             ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210323064155.12582-1-yuchao0@huawei.com \
    --to=yuchao0@huawei.com \
    --cc=chao@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.